diff mbox series

[v12] dt-bindings: ufs: Add bindings for Samsung ufs host

Message ID 20210915111844.42752-1-chanho61.park@samsung.com
State New
Headers show
Series [v12] dt-bindings: ufs: Add bindings for Samsung ufs host | expand

Commit Message

Chanho Park Sept. 15, 2021, 11:18 a.m. UTC 
From: Alim Akhtar <alim.akhtar@samsung.com>

This patch adds DT bindings for Samsung ufs hci

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
Changes since v11
* remove below warning by dt_binding_check
./Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml:26:6:
[warning] wrong indentation: expected 6 but found 5 (indentation)

Changes since v10
* Rebased on v5.14-rc2
* removed Rob Herring earlier Reviewed-by tag

This patch was part of exynos ufs driver series, somehow
this got missed to applied on the tree, sending again as a new
patch v11, removing Rob's earlier Reviewed-by tag.

 .../bindings/ufs/samsung,exynos-ufs.yaml      | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml

Comments

Rob Herring (Arm) Sept. 16, 2021, 3:07 p.m. UTC | #1 
On Wed, 15 Sep 2021 20:18:44 +0900, Chanho Park wrote:
> From: Alim Akhtar <alim.akhtar@samsung.com>

> 

> This patch adds DT bindings for Samsung ufs hci

> 

> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>

> Signed-off-by: Chanho Park <chanho61.park@samsung.com>

> ---

> Changes since v11

> * remove below warning by dt_binding_check

> ./Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml:26:6:

> [warning] wrong indentation: expected 6 but found 5 (indentation)

> 

> Changes since v10

> * Rebased on v5.14-rc2

> * removed Rob Herring earlier Reviewed-by tag

> 

> This patch was part of exynos ufs driver series, somehow

> this got missed to applied on the tree, sending again as a new

> patch v11, removing Rob's earlier Reviewed-by tag.

> 

>  .../bindings/ufs/samsung,exynos-ufs.yaml      | 89 +++++++++++++++++++

>  1 file changed, 89 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml

> 


Applied, thanks!


Sorry it fell thru the cracks, but it taking a year to notice is not 
great. If no one cares enough to notice, why are we applying any of it.

Rob
Chanho Park Sept. 17, 2021, 12:33 a.m. UTC | #2 
> Applied, thanks!

> 

> 

> Sorry it fell thru the cracks, but it taking a year to notice is not

great.
> If no one cares enough to notice, why are we applying any of it.

> 


Thanks. Take care of the patches next time not to delay :).

Best Regards,
Chanho Park
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
new file mode 100644
index 000000000000..b9ca8ef4f2be
--- /dev/null
+++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
@@ -0,0 +1,89 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ufs/samsung,exynos-ufs.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung SoC series UFS host controller Device Tree Bindings
+
+maintainers:
+  - Alim Akhtar <alim.akhtar@samsung.com>
+
+description: |
+  Each Samsung UFS host controller instance should have its own node.
+  This binding define Samsung specific binding other then what is used
+  in the common ufshcd bindings
+  [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+
+properties:
+
+  compatible:
+    enum:
+      - samsung,exynos7-ufs
+
+  reg:
+    items:
+      - description: HCI register
+      - description: vendor specific register
+      - description: unipro register
+      - description: UFS protector register
+
+  reg-names:
+    items:
+      - const: hci
+      - const: vs_hci
+      - const: unipro
+      - const: ufsp
+
+  clocks:
+    items:
+      - description: ufs link core clock
+      - description: unipro main clock
+
+  clock-names:
+    items:
+      - const: core_clk
+      - const: sclk_unipro_main
+
+  interrupts:
+    maxItems: 1
+
+  phys:
+    maxItems: 1
+
+  phy-names:
+    const: ufs-phy
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - phys
+  - phy-names
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/exynos7-clk.h>
+
+    ufs: ufs@15570000 {
+       compatible = "samsung,exynos7-ufs";
+       reg = <0x15570000 0x100>,
+             <0x15570100 0x100>,
+             <0x15571000 0x200>,
+             <0x15572000 0x300>;
+       reg-names = "hci", "vs_hci", "unipro", "ufsp";
+       interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
+       clocks = <&clock_fsys1 ACLK_UFS20_LINK>,
+                <&clock_fsys1 SCLK_UFSUNIPRO20_USER>;
+       clock-names = "core_clk", "sclk_unipro_main";
+       pinctrl-names = "default";
+       pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>;
+       phys = <&ufs_phy>;
+       phy-names = "ufs-phy";
+    };
+...