mbox series

[v7,0/2] Add temperature notification support

Message ID 20210915060407.40-1-avri.altman@wdc.com
Headers show
Series Add temperature notification support | expand

Message

Avri Altman Sept. 15, 2021, 6:04 a.m. UTC 
v6 -> v7:
 - some more useless initializations
 
v5 -> v6:
 - remove useless initializations
 
v4 - > v5:
 - Fix improper return error values
 
v3 -> v4:
 - Attend Guenter's comments

v2 -> v3:
 - Attend Bart's & Guenter's comments

v1 -> v2:
 - Add a hw monitor device if both the platform & the device support it
 - Remove the sysfs patch: no need to duplicate /sys/class/hwmon

UFS3.0 allows using the ufs device as a temperature sensor. The purpose
of this optional feature is to provide notification to the host of the
UFS device case temperature. It allows reading of a rough estimate
(+-10 degrees centigrade) of the current case temperature, and setting a
lower and upper temperature bounds, in which the device will trigger an
applicable exception event.

A previous attempt [1] tried a comprehensive approach.  Still, it was
unsuccessful. Here is a more modest approach that introduces just the
bare minimum to support temperature notification.

Thanks,
Avri

[1] https://lore.kernel.org/lkml/1582450522-13256-1-git-send-email-avi.shchislowski@wdc.com/


Avri Altman (2):
  scsi: ufs: Probe for temperature notification support
  scsi: ufs: Add temperature notification exception handling

 drivers/scsi/ufs/Kconfig     |   9 ++
 drivers/scsi/ufs/Makefile    |   1 +
 drivers/scsi/ufs/ufs-hwmon.c | 210 +++++++++++++++++++++++++++++++++++
 drivers/scsi/ufs/ufs.h       |   7 ++
 drivers/scsi/ufs/ufshcd.c    |  47 ++++++++
 drivers/scsi/ufs/ufshcd.h    |  20 ++++
 6 files changed, 294 insertions(+)
 create mode 100644 drivers/scsi/ufs/ufs-hwmon.c

Comments

Daejun Park Sept. 16, 2021, 2:31 a.m. UTC | #1 
Hi Avri,

>The device may notify the host of an extreme temperature by using the

>exception event mechanism. The exception can be raised when the device’s

>Tcase temperature is either too high or too low.

> 

>It is essentially up to the platform to decide what further actions need

>to be taken. leave a placeholder for a designated vop for that.

> 

>Signed-off-by: Avri Altman <avri.altman@wdc.com>


Reviewed-by: Daejun Park <daejun7.park@samsung.com>
Martin K. Petersen Sept. 22, 2021, 4:08 a.m. UTC | #2 
Avri,

> UFS3.0 allows using the ufs device as a temperature sensor. The purpose

> of this optional feature is to provide notification to the host of the

> UFS device case temperature. It allows reading of a rough estimate

> (+-10 degrees centigrade) of the current case temperature, and setting a

> lower and upper temperature bounds, in which the device will trigger an

> applicable exception event.


Applied to 5.16/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen Sept. 29, 2021, 4:20 a.m. UTC | #3 
On Wed, 15 Sep 2021 09:04:05 +0300, Avri Altman wrote:

> v6 -> v7:

>  - some more useless initializations

> 

> v5 -> v6:

>  - remove useless initializations

> 

> v4 - > v5:

>  - Fix improper return error values

> 

> [...]


Applied to 5.16/scsi-queue, thanks!

[1/2] scsi: ufs: Probe for temperature notification support
      https://git.kernel.org/mkp/scsi/c/e88e2d32200a
[2/2] scsi: ufs: Add temperature notification exception handling
      https://git.kernel.org/mkp/scsi/c/322c4b29ee1f

-- 
Martin K. Petersen	Oracle Linux Engineering