mbox series

[0/1] sound: add quirk for Huawei D15

Message ID cover.1640351150.git.mchehab@kernel.org
Headers show
Series sound: add quirk for Huawei D15 | expand

Message

Mauro Carvalho Chehab Dec. 24, 2021, 1:09 p.m. UTC 
Hi Pierre-Louis,

Based on my tests, Huawei D15 (Intel) uses SSP0 on es8336.

Add a quirk for it.

Please notice that, currently, only the internal speaker is working.
The topology for the internal microphone and for the headphones
is wrong. Enabling/disabling the other two quirks (GPIO and/or DMIC) 
doesn't cause any audible results, nor change the devices listed
on pavucontrol (tested with pipewire-pulse).

Mauro Carvalho Chehab (1):
  ASoC: Intel: sof_es8336: add quirk for Huawei D15 2021

 sound/soc/intel/boards/sof_es8336.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Mark Brown Feb. 18, 2022, 2:28 p.m. UTC | #1 
On Fri, 24 Dec 2021 14:09:48 +0100, Mauro Carvalho Chehab wrote:
> Based on my tests, Huawei D15 (Intel) uses SSP0 on es8336.
> 
> Add a quirk for it.
> 
> Please notice that, currently, only the internal speaker is working.
> The topology for the internal microphone and for the headphones
> is wrong. Enabling/disabling the other two quirks (GPIO and/or DMIC)
> doesn't cause any audible results, nor change the devices listed
> on pavucontrol (tested with pipewire-pulse).
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: sof_es8336: add quirk for Huawei D15 2021
      commit: ce6a70bfce21bb4edb7c0f29ecfb0522fa34ab71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Pierre-Louis Bossart Feb. 18, 2022, 6:11 p.m. UTC | #2 
On 2/18/22 08:28, Mark Brown wrote:
> On Fri, 24 Dec 2021 14:09:48 +0100, Mauro Carvalho Chehab wrote:
>> Based on my tests, Huawei D15 (Intel) uses SSP0 on es8336.
>>
>> Add a quirk for it.
>>
>> Please notice that, currently, only the internal speaker is working.
>> The topology for the internal microphone and for the headphones
>> is wrong. Enabling/disabling the other two quirks (GPIO and/or DMIC)
>> doesn't cause any audible results, nor change the devices listed
>> on pavucontrol (tested with pipewire-pulse).
>>
>> [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/1] ASoC: Intel: sof_es8336: add quirk for Huawei D15 2021
>       commit: ce6a70bfce21bb4edb7c0f29ecfb0522fa34ab71

I'll probably revert this change in my next update [1], I have a set of
changes where we can detect which SSP is used by parsing the NHTL
information in platform firmware.

I am still trying to figure out how to detect which MCLK is used, and
once this is done I'll send the patches upstream.

[1] https://github.com/thesofproject/linux/pull/3338
Mauro Carvalho Chehab Feb. 18, 2022, 11:46 p.m. UTC | #3 
Em Fri, 18 Feb 2022 12:11:59 -0600
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> escreveu:

> On 2/18/22 08:28, Mark Brown wrote:
> > On Fri, 24 Dec 2021 14:09:48 +0100, Mauro Carvalho Chehab wrote:  
> >> Based on my tests, Huawei D15 (Intel) uses SSP0 on es8336.
> >>
> >> Add a quirk for it.
> >>
> >> Please notice that, currently, only the internal speaker is working.
> >> The topology for the internal microphone and for the headphones
> >> is wrong. Enabling/disabling the other two quirks (GPIO and/or DMIC)
> >> doesn't cause any audible results, nor change the devices listed
> >> on pavucontrol (tested with pipewire-pulse).
> >>
> >> [...]  
> > 
> > Applied to
> > 
> >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> > 
> > Thanks!
> > 
> > [1/1] ASoC: Intel: sof_es8336: add quirk for Huawei D15 2021
> >       commit: ce6a70bfce21bb4edb7c0f29ecfb0522fa34ab71  
> 
> I'll probably revert this change in my next update [1], I have a set of
> changes where we can detect which SSP is used by parsing the NHTL
> information in platform firmware.

Mark,

Yeah, I tested Pierre-Louis pull request from:

	https://github.com/thesofproject/linux/pull/3338

and indeed this quirk is not needed anymore for the speaker to work.

So, once his new update gets merged upstream, feel free to revert
this one.

Pierre-Louis,

When you submit your next update from PR#3338, feel free to add:

Tested-by: Mauro Carvalho Chehab <mchehab@kernel.org>

and my Acked-by at the revert patch:

Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> 
> I am still trying to figure out how to detect which MCLK is used, and
> once this is done I'll send the patches upstream.
> 
> [1] https://github.com/thesofproject/linux/pull/3338



Thanks,
Mauro