| Message ID | 20220222183212.11580-1-srinivas.kandagatla@linaro.org |
|---|---|
| Headers | show |
| Series | ASoC: codecs: qcom fix validation failures | expand |
On Tue, Feb 22, 2022 at 06:32:06PM +0000, Srinivas Kandagatla wrote: > Also few return value of put functions, so that change notifications are > sent correctly. The unconditional change notifications are present in this patch and I'm guessing some others as well (they were there in a bunch previously): > tx->dec_mode[path] = value; > > - return 0; > + return 1; > }
On Tue, 22 Feb 2022 18:32:03 +0000, Srinivas Kandagatla wrote: > Thanks for pointing out to mixer kselftest and VALIDATION Kconfig. > > This patchset addresses some of the issues in Qualcomm codecs that are > discovered with recent mixer kselftest and validations added to ASoC. > > Mostly these are under > 1. accessing integer value type for enum controls, which is clearly an array out of bounds access. > 2. Fix incorrect ranges. > 3. Fix return values for put functions. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus Thanks! [1/9] ASoC: codecs: rx-macro: fix accessing compander for aux commit: 42c709c4e1ce4c136891530646c9abd5dff3524f [2/9] ASoC: codecs: rx-macro: fix accessing array out of bounds for enum type commit: bcfe5f76cc4051ea3f9eb5d2c8ea621641f290a5 [4/9] ASoC: codecs: va-macro: fix accessing array out of bounds for enum type commit: 0ea5eff7c6063a8f124188424f8e4c6727f35051 [6/9] ASoC: codecs: wc938x: fix accessing array out of bounds for enum type commit: cc587b7c8fbbe128f6bd0dad025a0caea5e6d164 [7/9] ASoC: codecs: wcd938x: fix kcontrol max values commit: b0217519236924f77a8382b4004e43ef8fd0dcbb [8/9] ASoC: codecs: wcd934x: fix kcontrol max values commit: 61163c3e7480106804269182e24db05244866493 [9/9] ASoC: codecs: wcd934x: fix return value of wcd934x_rx_hph_mode_put commit: 4b0bec6088588a120d33db85b1f0d9f096d1df71 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Thanks for pointing out to mixer kselftest and VALIDATION Kconfig. This patchset addresses some of the issues in Qualcomm codecs that are discovered with recent mixer kselftest and validations added to ASoC. Mostly these are under 1. accessing integer value type for enum controls, which is clearly an array out of bounds access. 2. Fix incorrect ranges. 3. Fix return values for put functions. Changes since v1: - removed tlv min max patches as "9bdd10d57a ("ASoC: ops: Shift tested values in snd_soc_put_volsw() by +min")" fixed the issue in core. - added checks in wcd934x_rx_hph_mode_put before returning thanks, srini Srinivas Kandagatla (9): ASoC: codecs: rx-macro: fix accessing compander for aux ASoC: codecs: rx-macro: fix accessing array out of bounds for enum type ASoC: codecs: tx-macro: fix accessing array out of bounds for enum type ASoC: codecs: va-macro: fix accessing array out of bounds for enum type ASoC: codecs: wsa-macro: fix accessing array out of bounds for enum type ASoC: codecs: wc938x: fix accessing array out of bounds for enum type ASoC: codecs: wcd938x: fix kcontrol max values ASoC: codecs: wcd934x: fix kcontrol max values ASoC: codecs: wcd934x: fix return value of wcd934x_rx_hph_mode_put sound/soc/codecs/lpass-rx-macro.c | 12 ++++++++---- sound/soc/codecs/lpass-tx-macro.c | 8 ++++---- sound/soc/codecs/lpass-va-macro.c | 4 ++-- sound/soc/codecs/lpass-wsa-macro.c | 10 +++++----- sound/soc/codecs/wcd934x.c | 11 +++++++---- sound/soc/codecs/wcd938x.c | 10 +++++----- 6 files changed, 31 insertions(+), 24 deletions(-)