mbox series

[v2,00/11] Support OVTI7251 on Microsoft Surface line

Message ID 20220225000753.511996-1-djrscally@gmail.com
Headers show
Series Support OVTI7251 on Microsoft Surface line | expand

Message

Daniel Scally Feb. 25, 2022, 12:07 a.m. UTC 
Hello all

This series extends the OV7251 driver so it's functional on the
Microsoft Surface line of laptops, where it's used as the IR
camera for face login. The camera sensor is connected to a CIO2
device which packs the 10-bit greyscale data into 25 pixels per 32
bytes similar to the IPU3 formats for Bayer data, so I also added
a new format to describe that and added it to the ipu3-cio2 driver's
list of supported formats. 

Series-level changes:

	- Added patch 5 removing per-mode frequency settings

Thanks
Dan

Daniel Scally (11):
  media: uapi: Add IPU3 packed Y10 format
  media: ipu3-cio2: Add support for V4L2_PIX_FMT_IPU3_Y10
  media: i2c: Add acpi support to ov7251
  media: i2c: Provide ov7251_check_hwcfg()
  media: i2c: Remove per-mode frequencies from ov7251
  media: i2c: Add ov7251_pll_configure()
  media: i2c: Add support for new frequencies to ov7251
  media: i2c: Add ov7251_detect_chip()
  media: i2c: Add pm_runtime support to ov7251
  media: i2c: Remove .s_power() from ov7251
  media: ipu3-cio2: Add INT347E to cio2-bridge

 .../media/v4l/pixfmt-yuv-luma.rst             |  14 +-
 drivers/media/i2c/ov7251.c                    | 565 ++++++++++++------
 drivers/media/pci/intel/ipu3/cio2-bridge.c    |   2 +
 drivers/media/pci/intel/ipu3/ipu3-cio2-main.c |   7 +-
 drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
 include/uapi/linux/videodev2.h                |   3 +-
 6 files changed, 412 insertions(+), 180 deletions(-)

Comments

Andy Shevchenko Feb. 25, 2022, 4:57 p.m. UTC | #1 
On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote:
> We have platforms where a camera sensor transmits Y10 data to
> the CIO2 device - add support for that (packed) format to the
> ipu3-cio2 driver.

...

> -	},

Why?

> +	}, {
> +		.mbus_code	= MEDIA_BUS_FMT_Y10_1X10,
> +		.fourcc		= V4L2_PIX_FMT_IPU3_Y10,
> +		.mipicode	= 0x2b,
> +		.bpp		= 10,
> +	}
Daniel Scally Feb. 25, 2022, 9:42 p.m. UTC | #2 
Hi Andy

On 25/02/2022 16:57, Andy Shevchenko wrote:
> On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote:
>> We have platforms where a camera sensor transmits Y10 data to
>> the CIO2 device - add support for that (packed) format to the
>> ipu3-cio2 driver.
> ...
>
>> -	},
> Why?


Why have the open and close brace on the same line you mean? Its just
the format that the other entries use, so I copied it.

>
>> +	}, {
>> +		.mbus_code	= MEDIA_BUS_FMT_Y10_1X10,
>> +		.fourcc		= V4L2_PIX_FMT_IPU3_Y10,
>> +		.mipicode	= 0x2b,
>> +		.bpp		= 10,
>> +	}
Andy Shevchenko Feb. 26, 2022, 6:14 p.m. UTC | #3 
On Sat, Feb 26, 2022 at 4:06 AM Daniel Scally <djrscally@gmail.com> wrote:
>
> Hi Andy
>
> On 25/02/2022 16:57, Andy Shevchenko wrote:
> > On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote:
> >> We have platforms where a camera sensor transmits Y10 data to
> >> the CIO2 device - add support for that (packed) format to the
> >> ipu3-cio2 driver.
> > ...
> >
> >> -    },
> > Why?
>
>
> Why have the open and close brace on the same line you mean? Its just
> the format that the other entries use, so I copied it.

I meant why you touched that line and as a consequence removed the comma.

> >> +    }, {
> >> +            .mbus_code      = MEDIA_BUS_FMT_Y10_1X10,
> >> +            .fourcc         = V4L2_PIX_FMT_IPU3_Y10,
> >> +            .mipicode       = 0x2b,
> >> +            .bpp            = 10,
> >> +    }
Daniel Scally Feb. 26, 2022, 10:25 p.m. UTC | #4 
On 26/02/2022 18:14, Andy Shevchenko wrote:
> On Sat, Feb 26, 2022 at 4:06 AM Daniel Scally <djrscally@gmail.com> wrote:
>> Hi Andy
>>
>> On 25/02/2022 16:57, Andy Shevchenko wrote:
>>> On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote:
>>>> We have platforms where a camera sensor transmits Y10 data to
>>>> the CIO2 device - add support for that (packed) format to the
>>>> ipu3-cio2 driver.
>>> ...
>>>
>>>> -    },
>>> Why?
>>
>> Why have the open and close brace on the same line you mean? Its just
>> the format that the other entries use, so I copied it.
> I meant why you touched that line and as a consequence removed the comma.


Ah - I didn't close my new entry in that table with a comma. I can fix 
that in the next version

>
>>>> +    }, {
>>>> +            .mbus_code      = MEDIA_BUS_FMT_Y10_1X10,
>>>> +            .fourcc         = V4L2_PIX_FMT_IPU3_Y10,
>>>> +            .mipicode       = 0x2b,
>>>> +            .bpp            = 10,
>>>> +    }
>
>