diff mbox series

[v2] Input: samsung-keypad - Properly state IOMEM dependency

Message ID 20220225041727.1902850-1-davidgow@google.com
State Accepted
Commit ba115adf61b36b8c167126425a62b0efc23f72c0
Headers show
Series [v2] Input: samsung-keypad - Properly state IOMEM dependency | expand

Commit Message

David Gow Feb. 25, 2022, 4:17 a.m. UTC 
Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
calls devm_ioremap(). This prevents compile errors in some configs (e.g,
allyesconfig/randconfig under UML):

/usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'

Signed-off-by: David Gow <davidgow@google.com>
Acked-by: anton ivanov <anton.ivanov@cambridgegreys.com>
---

Changes since v1:
http://lists.infradead.org/pipermail/linux-um/2022-February/002264.html
- Fix to depend on HAS_IOMEM, not IOMEM
- Add Acked-by tag.

---
 drivers/input/keyboard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Feb. 28, 2022, 5 a.m. UTC | #1 
On Fri, Feb 25, 2022 at 12:17:27PM +0800, David Gow wrote:
> Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
> calls devm_ioremap(). This prevents compile errors in some configs (e.g,
> allyesconfig/randconfig under UML):
> 
> /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
> samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
> 
> Signed-off-by: David Gow <davidgow@google.com>
> Acked-by: anton ivanov <anton.ivanov@cambridgegreys.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 0c607da9ee10..9417ee0b1eff 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -556,7 +556,7 @@  config KEYBOARD_PMIC8XXX
 
 config KEYBOARD_SAMSUNG
 	tristate "Samsung keypad support"
-	depends on HAVE_CLK
+	depends on HAS_IOMEM && HAVE_CLK
 	select INPUT_MATRIXKMAP
 	help
 	  Say Y here if you want to use the keypad on your Samsung mobile