| Message ID | 20220301080448.112813-1-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] scsi: Remove ignoring unreachable code warning | expand |
On Tue, 1 Mar 2022 16:04:48 +0800, Yang Li wrote: > The smatch tool reported the following warning: > drivers/scsi/scsi_error.c:1988 scsi_decide_disposition() warn: ignoring > unreachable code. > > Remove the "default:return FAILED;" instead of "return FAILED;" reported > by smatch, because compilers can provide more useful diagnostics about > switch/case statements that do not have a default statement, especially > if the "switch" applies to a value with enumeration type. > > [...] Applied to 5.18/scsi-queue, thanks! [1/1] scsi: Remove ignoring unreachable code warning https://git.kernel.org/mkp/scsi/c/e1b353e7a31d
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 9c237b223e63..ee752b4512f8 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -1982,8 +1982,6 @@ enum scsi_disposition scsi_decide_disposition(struct scsi_cmnd *scmd) "reservation conflict\n"); set_host_byte(scmd, DID_NEXUS_FAILURE); return SUCCESS; /* causes immediate i/o error */ - default: - return FAILED; } return FAILED;
The smatch tool reported the following warning: drivers/scsi/scsi_error.c:1988 scsi_decide_disposition() warn: ignoring unreachable code. Remove the "default:return FAILED;" instead of "return FAILED;" reported by smatch, because compilers can provide more useful diagnostics about switch/case statements that do not have a default statement, especially if the "switch" applies to a value with enumeration type. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/scsi/scsi_error.c | 2 -- 1 file changed, 2 deletions(-)