mbox series

[V2,0/12] misc iscsi patches

Message ID 20220320004402.6707-1-michael.christie@oracle.com
Headers show
Series misc iscsi patches | expand

Message

Mike Christie March 20, 2022, 12:43 a.m. UTC 
The following patches were made over Martin's 5.18 branches which
contain Bart's SCp.ptr changes and some other iscsi patches.

They are mix of minor fixes and perf improvements and cleanups.

V2:
- Fix up git commit messages.
- Rename modparam that controls if we create sessions using the
network softirq or iscsi_q.
- Drop zero copy patch but leave the part that set the sendpage
version of MSG_MORE. It turns out we were never using zero copy for the
header and it was the MSG_SENDPAGE_NOTLAST that was helping.

Comments

Lee Duncan March 21, 2022, 4:57 p.m. UTC | #1 
On 3/19/22 17:43, Mike Christie wrote:
> If we have more data set the MSG_SENDPAGE_NOTLAST in case we go down the
> sendpage path.
> 
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
>   drivers/scsi/iscsi_tcp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
> index 4e467918f4e2..067f71a418c3 100644
> --- a/drivers/scsi/iscsi_tcp.c
> +++ b/drivers/scsi/iscsi_tcp.c
> @@ -306,7 +306,7 @@ static int iscsi_sw_tcp_xmit_segment(struct iscsi_tcp_conn *tcp_conn,
>   		copy = segment->size - offset;
>   
>   		if (segment->total_copied + segment->size < segment->total_size)
> -			flags |= MSG_MORE;
> +			flags |= MSG_MORE | MSG_SENDPAGE_NOTLAST;
>   
>   		/* Use sendpage if we can; else fall back to sendmsg */
>   		if (!segment->data) {

Reviewed-by: Lee Duncan <lduncan@suse.com>