| Message ID | 20220402184011.132465-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | dt-bindings: qcom: convert entire GSBI (QUP I2C/SPI/UART) to DT schema | expand |
On 02/04/2022 22:29, Kuldeep Singh wrote: > On Sat, Apr 02, 2022 at 08:40:11PM +0200, Krzysztof Kozlowski wrote: >> Convert the Qualcomm General Serial Bus Interface (GSBI) to DT >> Schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../bindings/soc/qcom/qcom,gsbi.txt | 87 ------------ >> .../bindings/soc/qcom/qcom,gsbi.yaml | 133 ++++++++++++++++++ >> 2 files changed, 133 insertions(+), 87 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml > > Great initiative to convert everything in one go! > > [...] > >> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml >> new file mode 100644 >> index 000000000000..b97e359f3f90 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml >> @@ -0,0 +1,133 @@ >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/soc/qcom/qcom,gsbi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm General Serial Bus Interface (GSBI) >> + >> +maintainers: >> + - Andy Gross <agross@kernel.org> >> + - Bjorn Andersson <bjorn.andersson@linaro.org> >> + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> + >> +description: >> + The GSBI controller is modeled as a node with zero or more child nodes, each >> + representing a serial sub-node device that is mux'd as part of the GSBI >> + configuration settings. The mode setting will govern the input/output mode >> + of the 4 GSBI IOs. >> + >> + A GSBI controller node can contain 0 or more child nodes representing serial >> + devices. These serial devices can be a QCOM UART, I2C controller, spi >> + controller, or some combination of aforementioned devices. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,gsbi-v1.0.0 > > Only 1 entry? const. v1.0.0 looks like there could be some more, although they did not reach mainline. The GSBI seems to be replaced by different blocks, so maybe there will be no new entries here. Best regards, Krzysztof
On Sat, Apr 02, 2022 at 10:38:23PM +0200, Krzysztof Kozlowski wrote: > On 02/04/2022 22:29, Kuldeep Singh wrote: > > On Sat, Apr 02, 2022 at 08:40:11PM +0200, Krzysztof Kozlowski wrote: > >> Convert the Qualcomm General Serial Bus Interface (GSBI) to DT > >> Schema. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> .../bindings/soc/qcom/qcom,gsbi.txt | 87 ------------ > >> .../bindings/soc/qcom/qcom,gsbi.yaml | 133 ++++++++++++++++++ > >> 2 files changed, 133 insertions(+), 87 deletions(-) > >> delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt > >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml > > > > Great initiative to convert everything in one go! > > > > [...] > > > >> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml > >> new file mode 100644 > >> index 000000000000..b97e359f3f90 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml > >> @@ -0,0 +1,133 @@ > >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/soc/qcom/qcom,gsbi.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Qualcomm General Serial Bus Interface (GSBI) > >> + > >> +maintainers: > >> + - Andy Gross <agross@kernel.org> > >> + - Bjorn Andersson <bjorn.andersson@linaro.org> > >> + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> + > >> +description: > >> + The GSBI controller is modeled as a node with zero or more child nodes, each > >> + representing a serial sub-node device that is mux'd as part of the GSBI > >> + configuration settings. The mode setting will govern the input/output mode > >> + of the 4 GSBI IOs. > >> + > >> + A GSBI controller node can contain 0 or more child nodes representing serial > >> + devices. These serial devices can be a QCOM UART, I2C controller, spi > >> + controller, or some combination of aforementioned devices. > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - qcom,gsbi-v1.0.0 > > > > Only 1 entry? const. > > v1.0.0 looks like there could be some more, although they did not reach > mainline. The GSBI seems to be replaced by different blocks, so maybe > there will be no new entries here. Yes, GSBI seems pretty old and only v1 rolled out. Don't think there are more revisions on the cards. Still can't say so.
Hi, Changes since v2 ================ 1. Several new schema patches (GSBI, I2C and UART schema). 2. Several DTS fixes for clocks and DMAs. The choice of dma tx-rx and clocks core-iface was by more-or-less number of fixes needed. 3. Add Kuldeep acks to patches without changes. Changes since v1 ================ 1. Fix path in com/qcom,gsbi.txt. 2. Merge clock-names in example, correct $ref path (Kuldeep). Merging ======= 1. The DTS patches are independent and silence warnings pointed out by schema. 2. The DT schema patches should be taken together as GSBI (final patch) depends on previous bindings. Best regards, Krzysztof Cc: Kuldeep Singh <singh.kuldeep87k@gmail.com> Krzysztof Kozlowski (9): arm64: dts: qcom: align dmas in I2C/SPI/UART with DT schema arm64: dts: qcom: align clocks in I2C/SPI with DT schema ARM: dts: qcom: ipq4019: align dmas in SPI/UART with DT schema ARM: dts: qcom: ipq4019: align clocks in I2C with DT schema ARM: dts: qcom: msm8660: disable GSBI8 spi: dt-bindings: qcom,spi-qup: convert to dtschema dt-bindings: serial: qcom,msm-uartdm: convert to dtschema dt-bindings: i2c: qcom,i2c-qup: convert to dtschema dt-bindings: qcom: qcom,gsbi: convert to dtschema .../devicetree/bindings/i2c/qcom,i2c-qup.txt | 40 ------ .../devicetree/bindings/i2c/qcom,i2c-qup.yaml | 89 ++++++++++++ .../bindings/serial/qcom,msm-uartdm.txt | 81 ----------- .../bindings/serial/qcom,msm-uartdm.yaml | 112 +++++++++++++++ .../bindings/soc/qcom/qcom,gsbi.txt | 87 ------------ .../bindings/soc/qcom/qcom,gsbi.yaml | 133 ++++++++++++++++++ .../devicetree/bindings/spi/qcom,spi-qup.txt | 103 -------------- .../devicetree/bindings/spi/qcom,spi-qup.yaml | 81 +++++++++++ arch/arm/boot/dts/qcom-ipq4019.dtsi | 36 ++--- arch/arm/boot/dts/qcom-msm8660.dtsi | 1 + arch/arm64/boot/dts/qcom/ipq6018.dtsi | 20 +-- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 40 +++--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 68 ++++----- arch/arm64/boot/dts/qcom/msm8953.dtsi | 48 +++---- arch/arm64/boot/dts/qcom/msm8994.dtsi | 42 +++--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 36 ++--- arch/arm64/boot/dts/qcom/qcs404.dtsi | 92 ++++++------ 17 files changed, 607 insertions(+), 502 deletions(-) delete mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt create mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml delete mode 100644 Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt create mode 100644 Documentation/devicetree/bindings/serial/qcom,msm-uartdm.yaml delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.txt create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml