| Message ID | 298162bfa2e7225ccc753865e1ffa39ce2722b2a.1649443080.git.hns@goldelico.com |
|---|---|
| State | New |
| Headers | show |
| Series | MIPS: DTS: fix some findings by "make ci20_defconfig dt_binding_check dtbs_check" | expand |
On 08/04/2022 20:37, H. Nikolaus Schaller wrote: > arch/mips/boot/dts/ingenic/ci20.dtb: usb@13500000: compatible: 'oneOf' conditional failed, one must be fixed: > ['ingenic,jz4780-otg', 'snps,dwc2'] is too long > ['ingenic,jz4780-otg', 'snps,dwc2'] is too short > 'brcm,bcm2835-usb' was expected > 'hisilicon,hi6220-usb' was expected > 'rockchip,rk3066-usb' was expected > 'ingenic,jz4780-otg' is not one of ['rockchip,px30-usb', 'rockchip,rk3036-usb', 'rockchip,rk3188-usb', 'rockchip,rk3228-usb', 'rockchip,rk3288-usb', 'rockchip,rk3308-usb', 'rockchip,rk3328-usb', 'rockchip,rk3368-usb', 'rockchip,rv1108-usb'] > 'lantiq,arx100-usb' was expected > 'lantiq,xrx200-usb' was expected > 'ingenic,jz4780-otg' is not one of ['amlogic,meson8-usb', 'amlogic,meson8b-usb', 'amlogic,meson-gxbb-usb', 'amlogic,meson-g12a-usb', 'intel,socfpga-agilex-hsotg'] > 'amcc,dwc-otg' was expected > 'apm,apm82181-dwc-otg' was expected > 'snps,dwc2' was expected > 'st,stm32f4x9-fsotg' was expected > 'st,stm32f4x9-hsotg' was expected > 'st,stm32f7-hsotg' was expected > 'st,stm32mp15-fsotg' was expected > 'st,stm32mp15-hsotg' was expected > 'samsung,s3c6400-hsotg' was expected > 'intel,socfpga-agilex-hsotg' was expected You really don't need to paste entire warning. > From schema: Documentation/devicetree/bindings/usb/dwc2.yaml > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index 2021836983c96..c5124459678b7 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -576,7 +576,7 @@ bch: bch@134d0000 { > }; > > otg: usb@13500000 { > - compatible = "ingenic,jz4780-otg", "snps,dwc2"; > + compatible = "snps,dwc2"; This looks wrong, the block usually should have a specific compatible. Please mention why it does not. Best regards, Best regards, Krzysztof
Hi, > Am 09.04.2022 um 14:27 schrieb Paul Cercueil <paul@crapouillou.net>: > > Hi, > > Le sam., avril 9 2022 at 13:15:37 +0200, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> a écrit : >> On 08/04/2022 20:37, H. Nikolaus Schaller wrote: >>> arch/mips/boot/dts/ingenic/ci20.dtb: usb@13500000: compatible: 'oneOf' conditional failed, one must be fixed: >>> ['ingenic,jz4780-otg', 'snps,dwc2'] is too long >>> ['ingenic,jz4780-otg', 'snps,dwc2'] is too short >>> 'brcm,bcm2835-usb' was expected >>> 'hisilicon,hi6220-usb' was expected >>> 'rockchip,rk3066-usb' was expected >>> 'ingenic,jz4780-otg' is not one of ['rockchip,px30-usb', 'rockchip,rk3036-usb', 'rockchip,rk3188-usb', 'rockchip,rk3228-usb', 'rockchip,rk3288-usb', 'rockchip,rk3308-usb', 'rockchip,rk3328-usb', 'rockchip,rk3368-usb', 'rockchip,rv1108-usb'] >>> 'lantiq,arx100-usb' was expected >>> 'lantiq,xrx200-usb' was expected >>> 'ingenic,jz4780-otg' is not one of ['amlogic,meson8-usb', 'amlogic,meson8b-usb', 'amlogic,meson-gxbb-usb', 'amlogic,meson-g12a-usb', 'intel,socfpga-agilex-hsotg'] >>> 'amcc,dwc-otg' was expected >>> 'apm,apm82181-dwc-otg' was expected >>> 'snps,dwc2' was expected >>> 'st,stm32f4x9-fsotg' was expected >>> 'st,stm32f4x9-hsotg' was expected >>> 'st,stm32f7-hsotg' was expected >>> 'st,stm32mp15-fsotg' was expected >>> 'st,stm32mp15-hsotg' was expected >>> 'samsung,s3c6400-hsotg' was expected >>> 'intel,socfpga-agilex-hsotg' was expected >> You really don't need to paste entire warning. >>> From schema: Documentation/devicetree/bindings/usb/dwc2.yaml >>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >>> --- >>> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi >>> index 2021836983c96..c5124459678b7 100644 >>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi >>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi >>> @@ -576,7 +576,7 @@ bch: bch@134d0000 { >>> }; >>> otg: usb@13500000 { >>> - compatible = "ingenic,jz4780-otg", "snps,dwc2"; >>> + compatible = "snps,dwc2"; >> This looks wrong, the block usually should have a specific compatible. >> Please mention why it does not. > > Agreed. The "snps,dwc2" should be a fallback string, otherwise there is no way to uniquely identify the JZ4780 implementation of the IP. Well, there is no specifc implementation and driver for it. So no need to uniquely identify it. BR and thanks, Nikolaus
> Am 09.04.2022 um 15:15 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: > > On 09/04/2022 15:05, H. Nikolaus Schaller wrote: >>> >>> This looks wrong, the block usually should have a specific compatible. >>> Please mention why it does not. >> >> Well, I did not even have that idea that it could need an explanation. >> >> There is no "ingenic,jz4780-otg" and none is needed here to make it work. > > Make it work in what terms? We talk about hardware description, right? Yes. > >> >> Therefore the generic "snps,dwc2" is sufficient. > > No, you are mixing now driver behavior (is sufficient) with hardware > description. No. "snps,dwc2" is a hardware description for a licensed block. Not a driver behavior. > Most of licensed blocks require the specific compatible to > differentiate it. If there is a need to differentiate.
On 09/04/2022 15:32, H. Nikolaus Schaller wrote: > > >> Am 09.04.2022 um 15:15 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: >> >> On 09/04/2022 15:05, H. Nikolaus Schaller wrote: >>>> >>>> This looks wrong, the block usually should have a specific compatible. >>>> Please mention why it does not. >>> >>> Well, I did not even have that idea that it could need an explanation. >>> >>> There is no "ingenic,jz4780-otg" and none is needed here to make it work. >> >> Make it work in what terms? We talk about hardware description, right? > > Yes. > >> >>> >>> Therefore the generic "snps,dwc2" is sufficient. >> >> No, you are mixing now driver behavior (is sufficient) with hardware >> description. > > No. "snps,dwc2" is a hardware description for a licensed block. > Not a driver behavior. snps,dwc2 matches the original block, not necessarily this implementation. Unless you are sure? > >> Most of licensed blocks require the specific compatible to >> differentiate it. > > If there is a need to differentiate. No, regardless whether there is a need currently, most of them have specific compatibles, because there are some minor differences. Even if difference is not visible from programming model or wiring, it might justify it's own specific compatible. For example because maybe once that tiny difference will require some changes. Someone added the ingenic compatible, so why do you assume that one tool (bindings) is correct but other piece of code (using specific compatible) is not? You use the argument "bindings warning" which is not enough. Argument that blocks are 100% same, is good enough, if you are sure. Just use it in commit msg. But are you sure that these are the same? Same pins, same programming model (entire model, not used by Linux)? Best regards, Krzysztof
diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi index 2021836983c96..c5124459678b7 100644 --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi @@ -576,7 +576,7 @@ bch: bch@134d0000 { }; otg: usb@13500000 { - compatible = "ingenic,jz4780-otg", "snps,dwc2"; + compatible = "snps,dwc2"; reg = <0x13500000 0x40000>; interrupt-parent = <&intc>;
arch/mips/boot/dts/ingenic/ci20.dtb: usb@13500000: compatible: 'oneOf' conditional failed, one must be fixed: ['ingenic,jz4780-otg', 'snps,dwc2'] is too long ['ingenic,jz4780-otg', 'snps,dwc2'] is too short 'brcm,bcm2835-usb' was expected 'hisilicon,hi6220-usb' was expected 'rockchip,rk3066-usb' was expected 'ingenic,jz4780-otg' is not one of ['rockchip,px30-usb', 'rockchip,rk3036-usb', 'rockchip,rk3188-usb', 'rockchip,rk3228-usb', 'rockchip,rk3288-usb', 'rockchip,rk3308-usb', 'rockchip,rk3328-usb', 'rockchip,rk3368-usb', 'rockchip,rv1108-usb'] 'lantiq,arx100-usb' was expected 'lantiq,xrx200-usb' was expected 'ingenic,jz4780-otg' is not one of ['amlogic,meson8-usb', 'amlogic,meson8b-usb', 'amlogic,meson-gxbb-usb', 'amlogic,meson-g12a-usb', 'intel,socfpga-agilex-hsotg'] 'amcc,dwc-otg' was expected 'apm,apm82181-dwc-otg' was expected 'snps,dwc2' was expected 'st,stm32f4x9-fsotg' was expected 'st,stm32f4x9-hsotg' was expected 'st,stm32f7-hsotg' was expected 'st,stm32mp15-fsotg' was expected 'st,stm32mp15-hsotg' was expected 'samsung,s3c6400-hsotg' was expected 'intel,socfpga-agilex-hsotg' was expected From schema: Documentation/devicetree/bindings/usb/dwc2.yaml Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)