| Message ID | 20220510091654.8498-2-warp5tw@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: npcm: Bug fixes timeout, spurious interrupts | expand |
On Tue, 10 May 2022 17:16:46 +0800, Tyrone Ting wrote: > From: Tyrone Ting <kfting@nuvoton.com> > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > --- > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 25 +++++++++++++++---- > 1 file changed, 20 insertions(+), 5 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Rob: Thank you for your review. I would like to apply Krzysztof's comment from the link https://www.spinics.net/lists/linux-i2c/msg56795.html and remove the quotes of the statement "$ref: "/schemas/types.yaml#/definitions/phandle"". If it's okay with you, I'll come up with a new patch with "Reviewed-by" from you and Krzysztof. Thank you. Rob Herring <robh@kernel.org> 於 2022年5月11日 週三 下午11:24寫道： > > On Tue, 10 May 2022 17:16:46 +0800, Tyrone Ting wrote: > > From: Tyrone Ting <kfting@nuvoton.com> > > > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > > > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > > --- > > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 25 +++++++++++++++---- > > 1 file changed, 20 insertions(+), 5 deletions(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Best Regards, Tyrone
On 12/05/2022 03:31, Tyrone Ting wrote: > Hi Rob: > > Thank you for your review. I would like to apply Krzysztof's comment > from the link https://www.spinics.net/lists/linux-i2c/msg56795.html > and remove the > quotes of the statement "$ref: "/schemas/types.yaml#/definitions/phandle"". > > If it's okay with you, I'll come up with a new patch with > "Reviewed-by" from you and Krzysztof. Go ahead and keep the review-tags in new patch. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml index 128444942aec..99fae8489771 100644 --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: nuvoton NPCM7XX I2C Controller Device Tree Bindings description: | - The NPCM750x includes sixteen I2C bus controllers. All Controllers support - both master and slave mode. Each controller can switch between master and slave - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and - RX. + I2C bus controllers of the NPCM series support both master and + slave mode. Each controller can switch between master and slave at run time + (i.e. IPMB mode). HW FIFO for TX and RX are supported. maintainers: - Tali Perry <tali.perry1@gmail.com> properties: compatible: - const: nuvoton,npcm750-i2c + enum: + - nuvoton,npcm750-i2c + - nuvoton,npcm845-i2c reg: maxItems: 1 @@ -36,6 +37,10 @@ properties: default: 100000 enum: [100000, 400000, 1000000] + nuvoton,sys-mgr: + $ref: "/schemas/types.yaml#/definitions/phandle" + description: The phandle of system manager register node. + required: - compatible - reg @@ -44,6 +49,15 @@ required: allOf: - $ref: /schemas/i2c/i2c-controller.yaml# + - if: + properties: + compatible: + contains: + const: nuvoton,npcm845-i2c + + then: + required: + - nuvoton,sys-mgr unevaluatedProperties: false @@ -57,6 +71,7 @@ examples: clock-frequency = <100000>; interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; compatible = "nuvoton,npcm750-i2c"; + nuvoton,sys-mgr = <&gcr>; }; ...