| Message ID | 20220518184825.1034976-6-robimarko@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/6] dt-bindings: regulator: qcom,spmi-regulator: Convert to dtschema | expand |
On 18/05/2022 20:48, Robert Marko wrote: > PMP8074 is a companion PMIC to the Qualcomm IPQ8074 series that is > controlled via SPMI. > > Since we now have support for the regulators inside of it add DTSI > for it. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > arch/arm64/boot/dts/qcom/pmp8074.dtsi | 38 +++++++++++++++++++++++++++ This file is not referenced by anything, thus not possible to compile nor verify. Best regards, Krzysztof
On Thu, 19 May 2022 at 13:07, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 18/05/2022 20:48, Robert Marko wrote: > > PMP8074 is a companion PMIC to the Qualcomm IPQ8074 series that is > > controlled via SPMI. > > > > Since we now have support for the regulators inside of it add DTSI > > for it. > > > > Signed-off-by: Robert Marko <robimarko@gmail.com> > > --- > > arch/arm64/boot/dts/qcom/pmp8074.dtsi | 38 +++++++++++++++++++++++++++ > > This file is not referenced by anything, thus not possible to compile > nor verify. That is correct, I can include it on HK01 which has an SDHCI controller and thus can consume L11 for VQMMC so that HS200 and higher work. I wanted to include the nodes directly in the SoC DTSI and set L11 as VQMMC for SDHCI there as this is a companion PMIC and always present, but the established procedure is for the PMIC to have its own DTSI and then be included per board. Regards, Robert > > > Best regards, > Krzysztof
On 19/05/2022 13:21, Robert Marko wrote: > On Thu, 19 May 2022 at 13:07, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 18/05/2022 20:48, Robert Marko wrote: >>> PMP8074 is a companion PMIC to the Qualcomm IPQ8074 series that is >>> controlled via SPMI. >>> >>> Since we now have support for the regulators inside of it add DTSI >>> for it. >>> >>> Signed-off-by: Robert Marko <robimarko@gmail.com> >>> --- >>> arch/arm64/boot/dts/qcom/pmp8074.dtsi | 38 +++++++++++++++++++++++++++ >> >> This file is not referenced by anything, thus not possible to compile >> nor verify. > > That is correct, I can include it on HK01 which has an SDHCI controller > and thus can consume L11 for VQMMC so that HS200 and higher work. Yes, otherwise this does not have any effect. > > I wanted to include the nodes directly in the SoC DTSI and set L11 as VQMMC > for SDHCI there as this is a companion PMIC and always present, but > the established > procedure is for the PMIC to have its own DTSI and then be included per board. Which was correct suggestion but it is not relevant here. In your previous approach your PMIC would be included on every board via SoC DTSI. Now your PMIC is not included at all. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/pmp8074.dtsi b/arch/arm64/boot/dts/qcom/pmp8074.dtsi new file mode 100644 index 000000000000..0bda4997720b --- /dev/null +++ b/arch/arm64/boot/dts/qcom/pmp8074.dtsi @@ -0,0 +1,38 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include <dt-bindings/spmi/spmi.h> + +&spmi_bus { + pmic@1 { + compatible ="qcom,spmi-pmic"; + reg = <0x1 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + + regulators { + compatible = "qcom,pmp8074-regulators"; + + s3: s3 { + regulator-name = "vdd_s3"; + regulator-min-microvolt = <592000>; + regulator-max-microvolt = <1064000>; + regulator-always-on; + regulator-boot-on; + }; + + s4: s4 { + regulator-name = "vdd_s4"; + regulator-min-microvolt = <712000>; + regulator-max-microvolt = <992000>; + regulator-always-on; + regulator-boot-on; + }; + + l11: l11 { + regulator-name = "l11"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + }; + }; + }; +};
PMP8074 is a companion PMIC to the Qualcomm IPQ8074 series that is controlled via SPMI. Since we now have support for the regulators inside of it add DTSI for it. Signed-off-by: Robert Marko <robimarko@gmail.com> --- arch/arm64/boot/dts/qcom/pmp8074.dtsi | 38 +++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/pmp8074.dtsi