| Message ID | AM9PR10MB41185ADE95B92B4E6926BE639DD49@AM9PR10MB4118.EURPRD10.PROD.OUTLOOK.COM |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter | expand |
> On May 23, 2022, at 2:24 AM, Chesnokov Gleb <Chesnokov.G@raidix.com> wrote: > > The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64 > ("qla2xxx: Add Dual mode support in the driver"). Then the use of this parameter > was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add ql2xiniexchg parameter"). > > Thus, remove ql_dm_tgt_ex_pct since it is no longer used. > --- > drivers/scsi/qla2xxx/qla_target.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c > index 6dfcfd8e7337..d03b9223b75e 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -48,13 +48,6 @@ MODULE_PARM_DESC(qlini_mode, > "when ready " > "\"enabled\" (default) - initiator mode will always stay enabled."); > > -static int ql_dm_tgt_ex_pct = 0; > -module_param(ql_dm_tgt_ex_pct, int, S_IRUGO|S_IWUSR); > -MODULE_PARM_DESC(ql_dm_tgt_ex_pct, > - "For Dual Mode (qlini_mode=dual), this parameter determines " > - "the percentage of exchanges/cmds FW will allocate resources " > - "for Target mode."); > - > int ql2xuctrlirq = 1; > module_param(ql2xuctrlirq, int, 0644); > MODULE_PARM_DESC(ql2xuctrlirq, > -- > 2.36.1 Once s-o-b is fixed, Please add Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> -- Himanshu Madhani Oracle Linux Engineering
> Once s-o-b is fixed, Please add > > Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> I'm still newbie in linux kernel contribution, so I'm not sure what exactly I need to do. Do I need to resend the patch with fixed s-o-b as a second version? Thanks, Gleb.
> On May 25, 2022, at 7:52 AM, Chesnokov Gleb <Chesnokov.G@raidix.com> wrote: > >> Once s-o-b is fixed, Please add >> >> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> > > I'm still newbie in linux kernel contribution, so I'm not sure what exactly I need to do. > Do I need to resend the patch with fixed s-o-b as a second version? It will be easier for the maintainer to pick up the patch if you resend with SOB and RB added. > > Thanks, > Gleb. -- Himanshu Madhani Oracle Linux Engineering
The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64
("qla2xxx: Add Dual mode support in the driver"). Then the use of this parameter
was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add ql2xiniexchg parameter").
Thus, remove ql_dm_tgt_ex_pct since it is no longer used.
Signed-off-by: Gleb Chesnokov <Chesnokov.G@raidix.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
---
drivers/scsi/qla2xxx/qla_target.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 6dfcfd8e7337..d03b9223b75e 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -48,13 +48,6 @@ MODULE_PARM_DESC(qlini_mode,
"when ready "
"\"enabled\" (default) - initiator mode will always stay enabled.");
-static int ql_dm_tgt_ex_pct = 0;
-module_param(ql_dm_tgt_ex_pct, int, S_IRUGO|S_IWUSR);
-MODULE_PARM_DESC(ql_dm_tgt_ex_pct,
- "For Dual Mode (qlini_mode=dual), this parameter determines "
- "the percentage of exchanges/cmds FW will allocate resources "
- "for Target mode.");
-
int ql2xuctrlirq = 1;
module_param(ql2xuctrlirq, int, 0644);
MODULE_PARM_DESC(ql2xuctrlirq,
Chesnokov, > The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64 > ("qla2xxx: Add Dual mode support in the driver"). Then the use of this > parameter was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add > ql2xiniexchg parameter"). Applied to 5.19/scsi-staging, thanks!
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 6dfcfd8e7337..d03b9223b75e 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -48,13 +48,6 @@ MODULE_PARM_DESC(qlini_mode, "when ready " "\"enabled\" (default) - initiator mode will always stay enabled."); -static int ql_dm_tgt_ex_pct = 0; -module_param(ql_dm_tgt_ex_pct, int, S_IRUGO|S_IWUSR); -MODULE_PARM_DESC(ql_dm_tgt_ex_pct, - "For Dual Mode (qlini_mode=dual), this parameter determines " - "the percentage of exchanges/cmds FW will allocate resources " - "for Target mode."); - int ql2xuctrlirq = 1; module_param(ql2xuctrlirq, int, 0644); MODULE_PARM_DESC(ql2xuctrlirq,
The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64 ("qla2xxx: Add Dual mode support in the driver"). Then the use of this parameter was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add ql2xiniexchg parameter"). Thus, remove ql_dm_tgt_ex_pct since it is no longer used. --- drivers/scsi/qla2xxx/qla_target.c | 7 ------- 1 file changed, 7 deletions(-)