| Message ID | 20220607134057.2427663-1-bryan.odonoghue@linaro.org |
|---|---|
| Headers | show |
| Series | Add imx577 compatible to imx412 | expand |
On 07/06/2022 22:56, Kieran Bingham wrote: > Quoting Bryan O'Donoghue (2022-06-07 14:40:55) >> Right now the imx412 and imx577 are code and pin compatible however, they >> are distinct pieces of silicon. >> >> Document imx577 as a compatible enum and add the compat string to imx412.c. >> This allows us to differentiate these chips in DTS and potentially to apply >> any future imx412 or imx577 specific changes appropriately. > While I think this is probably fine to get things working, there seems to > be quite a few extra features in the IMX577 [0] compared with the IMX412 [1]. > > [0]https://www.sony-semicon.co.jp/products/common/pdf/IMX412-AACK_Flyer03.pdf > [1]https://www.sony-semicon.co.jp/products/common/pdf/IMX577-AACK_Flyer.pdf > > I certainly agree though that it's better to declare the camera > correctly in the DT - so it's better to add this support than 'fake' the > DT to say it's an IMX412 on the platform. Agreed the specs differ but the only silicon enabling code I have access to - from the qcom camx release is a 1:1 for 412 and 577. The init process works for me on rb5 to obtain 10 bit bayer @ 30 fps. Agreed the 577 does a whole bunch of extra stuff I just have no reference either in PDF or code on how to do any of it. Its "good enough" for me in 412 mode. --- bod
On Tue, 07 Jun 2022 14:40:56 +0100, Bryan O'Donoghue wrote: > The Sony IMX577 uses the same silicon enabling reference code from Sony in > the available examples provided. > > Add an imx577 compatible string to allow for chip differentiation and > accurate description of hardware in dts. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>