| Message ID | 1656062391-14567-4-git-send-email-quic_krichai@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | PCI: qcom: sc7280: add missing clocks | expand |
On 24/06/2022 11:19, Krishna chaitanya chundru wrote: > Add missing pcie clocks. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > Thank you for your patch. There is something to discuss/improve. > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index e66fc67..a5ce095 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -2043,6 +2043,8 @@ > <&gcc GCC_PCIE_1_SLV_AXI_CLK>, > <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>, > <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_CENTER_SF_AXI_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>, > <&gcc GCC_DDRSS_PCIE_SF_CLK>; > > clock-names = "pipe", > @@ -2055,6 +2057,8 @@ > "bus_slave", > "slave_q2a", > "tbu", > + "aggre0", > + "aggre1", > "ddrss_sf_tbu"; Unfortunately wrong order. Please test your patches with `make dtbs_check`. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index e66fc67..a5ce095 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2043,6 +2043,8 @@ <&gcc GCC_PCIE_1_SLV_AXI_CLK>, <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>, <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>, + <&gcc GCC_AGGRE_NOC_PCIE_CENTER_SF_AXI_CLK>, + <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>, <&gcc GCC_DDRSS_PCIE_SF_CLK>; clock-names = "pipe", @@ -2055,6 +2057,8 @@ "bus_slave", "slave_q2a", "tbu", + "aggre0", + "aggre1", "ddrss_sf_tbu"; assigned-clocks = <&gcc GCC_PCIE_1_AUX_CLK>;
Add missing pcie clocks. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++ 1 file changed, 4 insertions(+)