| Message ID | 20220717184336.1197723-1-mairacanal@riseup.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/tests: Split up test cases in igt_check_drm_format_min_pitch | expand |
Hi all, Friendly ping: is someone available to take this, please? Best Regards, - Maíra Canal On 7/17/22 15:43, Maíra Canal wrote: > The igt_check_drm_format_min_pitch() function had a lot of > KUNIT_EXPECT_* calls, all of which ended up allocating and initializing > various test assertion structures on the stack. > > This behavior was producing -Wframe-larger-than warnings on PowerPC, i386, > and MIPS architectures, such as: > > drivers/gpu/drm/tests/drm_format_test.c: In function 'igt_check_drm_format_min_pitch': > drivers/gpu/drm/tests/drm_format_test.c:271:1: error: the frame size of > 3712 bytes is larger than 2048 bytes > > So, the igt_check_drm_format_min_pitch() test case was split into three > smaller functions: one testing single plane formats, one testing multiple > planes formats, and the other testing tiled formats. > > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Maíra Canal <mairacanal@riseup.net> > --- > drivers/gpu/drm/tests/drm_format_test.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tests/drm_format_test.c b/drivers/gpu/drm/tests/drm_format_test.c > index 056cb8599d6d..28f2b8f88818 100644 > --- a/drivers/gpu/drm/tests/drm_format_test.c > +++ b/drivers/gpu/drm/tests/drm_format_test.c > @@ -91,7 +91,7 @@ static void igt_check_drm_format_block_height(struct kunit *test) > KUNIT_EXPECT_FALSE(test, drm_format_info_block_height(info, -1)); > } > > -static void igt_check_drm_format_min_pitch(struct kunit *test) > +static void igt_check_drm_format_min_pitch_for_single_plane(struct kunit *test) > { > const struct drm_format_info *info = NULL; > > @@ -175,6 +175,11 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > (uint64_t)UINT_MAX * 4); > KUNIT_EXPECT_EQ(test, drm_format_info_min_pitch(info, 0, (UINT_MAX - 1)), > (uint64_t)(UINT_MAX - 1) * 4); > +} > + > +static void igt_check_drm_format_min_pitch_for_multiple_planes(struct kunit *test) > +{ > + const struct drm_format_info *info = NULL; > > /* Test 2 planes format */ > info = drm_format_info(DRM_FORMAT_NV12); > @@ -249,6 +254,11 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > (uint64_t)(UINT_MAX - 1) / 2); > KUNIT_EXPECT_EQ(test, drm_format_info_min_pitch(info, 2, (UINT_MAX - 1) / 2), > (uint64_t)(UINT_MAX - 1) / 2); > +} > + > +static void igt_check_drm_format_min_pitch_for_tiled_format(struct kunit *test) > +{ > + const struct drm_format_info *info = NULL; > > /* Test tiled format */ > info = drm_format_info(DRM_FORMAT_X0L2); > @@ -273,7 +283,9 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > static struct kunit_case drm_format_tests[] = { > KUNIT_CASE(igt_check_drm_format_block_width), > KUNIT_CASE(igt_check_drm_format_block_height), > - KUNIT_CASE(igt_check_drm_format_min_pitch), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_single_plane), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_multiple_planes), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_tiled_format), > { } > }; >
Às 15:43 de 17/07/22, Maíra Canal escreveu: > The igt_check_drm_format_min_pitch() function had a lot of > KUNIT_EXPECT_* calls, all of which ended up allocating and initializing > various test assertion structures on the stack. > > This behavior was producing -Wframe-larger-than warnings on PowerPC, i386, > and MIPS architectures, such as: > > drivers/gpu/drm/tests/drm_format_test.c: In function 'igt_check_drm_format_min_pitch': > drivers/gpu/drm/tests/drm_format_test.c:271:1: error: the frame size of > 3712 bytes is larger than 2048 bytes > > So, the igt_check_drm_format_min_pitch() test case was split into three > smaller functions: one testing single plane formats, one testing multiple > planes formats, and the other testing tiled formats. > > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Maíra Canal <mairacanal@riseup.net> > --- Reviewed-by: André Almeida <andrealmeid@igalia.com> > drivers/gpu/drm/tests/drm_format_test.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tests/drm_format_test.c b/drivers/gpu/drm/tests/drm_format_test.c > index 056cb8599d6d..28f2b8f88818 100644 > --- a/drivers/gpu/drm/tests/drm_format_test.c > +++ b/drivers/gpu/drm/tests/drm_format_test.c > @@ -91,7 +91,7 @@ static void igt_check_drm_format_block_height(struct kunit *test) > KUNIT_EXPECT_FALSE(test, drm_format_info_block_height(info, -1)); > } > > -static void igt_check_drm_format_min_pitch(struct kunit *test) > +static void igt_check_drm_format_min_pitch_for_single_plane(struct kunit *test) > { > const struct drm_format_info *info = NULL; > > @@ -175,6 +175,11 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > (uint64_t)UINT_MAX * 4); > KUNIT_EXPECT_EQ(test, drm_format_info_min_pitch(info, 0, (UINT_MAX - 1)), > (uint64_t)(UINT_MAX - 1) * 4); > +} > + > +static void igt_check_drm_format_min_pitch_for_multiple_planes(struct kunit *test) Minor nit: I think the wording is usually "multi-planar" > +{ > + const struct drm_format_info *info = NULL; > > /* Test 2 planes format */ > info = drm_format_info(DRM_FORMAT_NV12); > @@ -249,6 +254,11 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > (uint64_t)(UINT_MAX - 1) / 2); > KUNIT_EXPECT_EQ(test, drm_format_info_min_pitch(info, 2, (UINT_MAX - 1) / 2), > (uint64_t)(UINT_MAX - 1) / 2); > +} > + > +static void igt_check_drm_format_min_pitch_for_tiled_format(struct kunit *test) > +{ > + const struct drm_format_info *info = NULL; > > /* Test tiled format */ > info = drm_format_info(DRM_FORMAT_X0L2); > @@ -273,7 +283,9 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > static struct kunit_case drm_format_tests[] = { > KUNIT_CASE(igt_check_drm_format_block_width), > KUNIT_CASE(igt_check_drm_format_block_height), > - KUNIT_CASE(igt_check_drm_format_min_pitch), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_single_plane), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_multiple_planes), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_tiled_format), > { } > }; >
On 07/17, Maíra Canal wrote: > The igt_check_drm_format_min_pitch() function had a lot of > KUNIT_EXPECT_* calls, all of which ended up allocating and initializing > various test assertion structures on the stack. > > This behavior was producing -Wframe-larger-than warnings on PowerPC, i386, > and MIPS architectures, such as: > > drivers/gpu/drm/tests/drm_format_test.c: In function 'igt_check_drm_format_min_pitch': > drivers/gpu/drm/tests/drm_format_test.c:271:1: error: the frame size of > 3712 bytes is larger than 2048 bytes > > So, the igt_check_drm_format_min_pitch() test case was split into three > smaller functions: one testing single plane formats, one testing multiple > planes formats, and the other testing tiled formats. > Hi Maíra, Could you add a Fixes tag to indicate the commit that introduces the issue? Thanks, Melissa > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Maíra Canal <mairacanal@riseup.net> > --- > drivers/gpu/drm/tests/drm_format_test.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tests/drm_format_test.c b/drivers/gpu/drm/tests/drm_format_test.c > index 056cb8599d6d..28f2b8f88818 100644 > --- a/drivers/gpu/drm/tests/drm_format_test.c > +++ b/drivers/gpu/drm/tests/drm_format_test.c > @@ -91,7 +91,7 @@ static void igt_check_drm_format_block_height(struct kunit *test) > KUNIT_EXPECT_FALSE(test, drm_format_info_block_height(info, -1)); > } > > -static void igt_check_drm_format_min_pitch(struct kunit *test) > +static void igt_check_drm_format_min_pitch_for_single_plane(struct kunit *test) > { > const struct drm_format_info *info = NULL; > > @@ -175,6 +175,11 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > (uint64_t)UINT_MAX * 4); > KUNIT_EXPECT_EQ(test, drm_format_info_min_pitch(info, 0, (UINT_MAX - 1)), > (uint64_t)(UINT_MAX - 1) * 4); > +} > + > +static void igt_check_drm_format_min_pitch_for_multiple_planes(struct kunit *test) > +{ > + const struct drm_format_info *info = NULL; > > /* Test 2 planes format */ > info = drm_format_info(DRM_FORMAT_NV12); > @@ -249,6 +254,11 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > (uint64_t)(UINT_MAX - 1) / 2); > KUNIT_EXPECT_EQ(test, drm_format_info_min_pitch(info, 2, (UINT_MAX - 1) / 2), > (uint64_t)(UINT_MAX - 1) / 2); > +} > + > +static void igt_check_drm_format_min_pitch_for_tiled_format(struct kunit *test) > +{ > + const struct drm_format_info *info = NULL; > > /* Test tiled format */ > info = drm_format_info(DRM_FORMAT_X0L2); > @@ -273,7 +283,9 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) > static struct kunit_case drm_format_tests[] = { > KUNIT_CASE(igt_check_drm_format_block_width), > KUNIT_CASE(igt_check_drm_format_block_height), > - KUNIT_CASE(igt_check_drm_format_min_pitch), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_single_plane), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_multiple_planes), > + KUNIT_CASE(igt_check_drm_format_min_pitch_for_tiled_format), > { } > }; > > -- > 2.36.1 >
diff --git a/drivers/gpu/drm/tests/drm_format_test.c b/drivers/gpu/drm/tests/drm_format_test.c index 056cb8599d6d..28f2b8f88818 100644 --- a/drivers/gpu/drm/tests/drm_format_test.c +++ b/drivers/gpu/drm/tests/drm_format_test.c @@ -91,7 +91,7 @@ static void igt_check_drm_format_block_height(struct kunit *test) KUNIT_EXPECT_FALSE(test, drm_format_info_block_height(info, -1)); } -static void igt_check_drm_format_min_pitch(struct kunit *test) +static void igt_check_drm_format_min_pitch_for_single_plane(struct kunit *test) { const struct drm_format_info *info = NULL; @@ -175,6 +175,11 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) (uint64_t)UINT_MAX * 4); KUNIT_EXPECT_EQ(test, drm_format_info_min_pitch(info, 0, (UINT_MAX - 1)), (uint64_t)(UINT_MAX - 1) * 4); +} + +static void igt_check_drm_format_min_pitch_for_multiple_planes(struct kunit *test) +{ + const struct drm_format_info *info = NULL; /* Test 2 planes format */ info = drm_format_info(DRM_FORMAT_NV12); @@ -249,6 +254,11 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) (uint64_t)(UINT_MAX - 1) / 2); KUNIT_EXPECT_EQ(test, drm_format_info_min_pitch(info, 2, (UINT_MAX - 1) / 2), (uint64_t)(UINT_MAX - 1) / 2); +} + +static void igt_check_drm_format_min_pitch_for_tiled_format(struct kunit *test) +{ + const struct drm_format_info *info = NULL; /* Test tiled format */ info = drm_format_info(DRM_FORMAT_X0L2); @@ -273,7 +283,9 @@ static void igt_check_drm_format_min_pitch(struct kunit *test) static struct kunit_case drm_format_tests[] = { KUNIT_CASE(igt_check_drm_format_block_width), KUNIT_CASE(igt_check_drm_format_block_height), - KUNIT_CASE(igt_check_drm_format_min_pitch), + KUNIT_CASE(igt_check_drm_format_min_pitch_for_single_plane), + KUNIT_CASE(igt_check_drm_format_min_pitch_for_multiple_planes), + KUNIT_CASE(igt_check_drm_format_min_pitch_for_tiled_format), { } };
The igt_check_drm_format_min_pitch() function had a lot of KUNIT_EXPECT_* calls, all of which ended up allocating and initializing various test assertion structures on the stack. This behavior was producing -Wframe-larger-than warnings on PowerPC, i386, and MIPS architectures, such as: drivers/gpu/drm/tests/drm_format_test.c: In function 'igt_check_drm_format_min_pitch': drivers/gpu/drm/tests/drm_format_test.c:271:1: error: the frame size of 3712 bytes is larger than 2048 bytes So, the igt_check_drm_format_min_pitch() test case was split into three smaller functions: one testing single plane formats, one testing multiple planes formats, and the other testing tiled formats. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Maíra Canal <mairacanal@riseup.net> --- drivers/gpu/drm/tests/drm_format_test.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)