| Message ID | 20220804184908.470216-2-shenwei.wang@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add IMX8 SCU GPIO support | expand |
On Thu, 04 Aug 2022 13:49:06 -0500, Shenwei Wang wrote: > Add binding document for the imx-scu gpio driver. > > Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com> > --- > .../bindings/gpio/fsl,imx8-scu-gpio.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.example.dts:18.18-22.11: Warning (unit_address_vs_reg): /example-0/gpio@scu: node has a unit name, but no reg or ranges property doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 04/08/2022 20:49, Shenwei Wang wrote: > + > +properties: > + compatible: > + enum: > + - fsl,imx8-scu-gpio > + > + "#gpio-cells": > + const: 2 > + > + gpio-controller: true > + > +required: > + - compatible > + - "#gpio-cells" > + - gpio-controller > + > +additionalProperties: false > + > +examples: > + - | > + gpio@scu { Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml new file mode 100644 index 000000000000..d06e91402666 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/fsl,imx8-scu-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO driver over IMX SCU firmware API + +maintainers: + - Shenwei Wang <shenwei.wang@nxp.com> + +description: | + This module provides the standard interface to control the + resource pins in SCU domain on i.MX8 platforms. + +properties: + compatible: + enum: + - fsl,imx8-scu-gpio + + "#gpio-cells": + const: 2 + + gpio-controller: true + +required: + - compatible + - "#gpio-cells" + - gpio-controller + +additionalProperties: false + +examples: + - | + gpio@scu { + compatible = "fsl,imx8-scu-gpio"; + gpio-controller; + #gpio-cells = <2>; + };
Add binding document for the imx-scu gpio driver. Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com> --- .../bindings/gpio/fsl,imx8-scu-gpio.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml