| Message ID | 6d75855ad4e2470e9ed99e0df21bc30f0c925a29.1658862932.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] mmc: pxamci: Fix an error handling path in pxamci_probe() | expand |
On Tue, 26 Jul 2022 at 21:15, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > The commit in Fixes: has moved some code around without updating gotos to > the error handling path. > > Update it now and release some resources if pxamci_of_init() fails. > > Fixes: fa3a5115469c ("mmc: pxamci: call mmc_of_parse()") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied for fixes and by adding stable tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/pxamci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c > index 0db9490dc659..37bf362a0ed5 100644 > --- a/drivers/mmc/host/pxamci.c > +++ b/drivers/mmc/host/pxamci.c > @@ -648,7 +648,7 @@ static int pxamci_probe(struct platform_device *pdev) > > ret = pxamci_of_init(pdev, mmc); > if (ret) > - return ret; > + goto out; > > host = mmc_priv(mmc); > host->mmc = mmc; > -- > 2.34.1 >
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 0db9490dc659..37bf362a0ed5 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -648,7 +648,7 @@ static int pxamci_probe(struct platform_device *pdev) ret = pxamci_of_init(pdev, mmc); if (ret) - return ret; + goto out; host = mmc_priv(mmc); host->mmc = mmc;
The commit in Fixes: has moved some code around without updating gotos to the error handling path. Update it now and release some resources if pxamci_of_init() fails. Fixes: fa3a5115469c ("mmc: pxamci: call mmc_of_parse()") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/mmc/host/pxamci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)