| Message ID | 20220817130342.568396-5-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: improvements to TCSR mutex in DTS | expand |
On 17.08.2022 15:03, Krzysztof Kozlowski wrote: > The TCSR halt regs are next to TCSR mutex, so before converting the TCSR > mutex into device with address space, we need to split the halt regs to > its own syscon device. This also describes more accurately the devices > and their IO address space. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Not tested on a device, but looks good to the eye: Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index 02d21bff2198..f0806ed103f1 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -1049,7 +1049,12 @@ ufsphy_lanes: phy@1da7400 { > > tcsr_mutex_regs: syscon@1f40000 { > compatible = "syscon"; > - reg = <0x01f40000 0x40000>; > + reg = <0x01f40000 0x20000>; > + }; > + > + tcsr_regs_1: sycon@1f60000 { > + compatible = "qcom,msm8998-tcsr", "syscon"; > + reg = <0x01f60000 0x20000>; > }; > > tlmm: pinctrl@3400000 { > @@ -1340,7 +1345,7 @@ remoteproc_mss: remoteproc@4080000 { > resets = <&gcc GCC_MSS_RESTART>; > reset-names = "mss_restart"; > > - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; > + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; > > power-domains = <&rpmpd MSM8998_VDDCX>, > <&rpmpd MSM8998_VDDMX>;
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 02d21bff2198..f0806ed103f1 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1049,7 +1049,12 @@ ufsphy_lanes: phy@1da7400 { tcsr_mutex_regs: syscon@1f40000 { compatible = "syscon"; - reg = <0x01f40000 0x40000>; + reg = <0x01f40000 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible = "qcom,msm8998-tcsr", "syscon"; + reg = <0x01f60000 0x20000>; }; tlmm: pinctrl@3400000 { @@ -1340,7 +1345,7 @@ remoteproc_mss: remoteproc@4080000 { resets = <&gcc GCC_MSS_RESTART>; reset-names = "mss_restart"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; power-domains = <&rpmpd MSM8998_VDDCX>, <&rpmpd MSM8998_VDDMX>;
The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)