| Message ID | 20221029051449.30678-9-manivannan.sadhasivam@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | sc8280xp-pmic updates and X13s thermal zone support | expand |
On 29.10.2022 07:14, Manivannan Sadhasivam wrote: > Add VADC channels for measuring the on-chip die temperature and external > crystal osciallator temperature of PMK8280. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index 6aa8cf6d9776..18315743313b 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -7,6 +7,7 @@ > /dts-v1/; > > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > #include "sc8280xp.dtsi" > @@ -173,6 +174,23 @@ &pmk8280_pon_resin { > status = "okay"; > }; > > +&pmk8280_vadc { > + status = "okay"; As I mentioned in the patch adding this to the PMIC DTSI, it's enabled by default (perhaps by mistake). > + > + pmic-die-temp@3 { > + reg = <PMK8350_ADC7_DIE_TEMP>; > + label = "pmk8280_die_temp"; > + qcom,pre-scaling = <1 1>; > + }; > + > + xo-therm@44 { > + reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>; > + label = "pmk8280_xo_therm"; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; having qcom,hw-settle-time above qcom,ratiometric would make this more reverse-Christmas-tree-y, but maybe I'm just picky.. For the contents though: Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > + }; > +}; > + > &qup0 { > status = "okay"; > };
On 29/10/2022 01:14, Manivannan Sadhasivam wrote: > Add VADC channels for measuring the on-chip die temperature and external > crystal osciallator temperature of PMK8280. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index 6aa8cf6d9776..18315743313b 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -7,6 +7,7 @@ /dts-v1/; #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sc8280xp.dtsi" @@ -173,6 +174,23 @@ &pmk8280_pon_resin { status = "okay"; }; +&pmk8280_vadc { + status = "okay"; + + pmic-die-temp@3 { + reg = <PMK8350_ADC7_DIE_TEMP>; + label = "pmk8280_die_temp"; + qcom,pre-scaling = <1 1>; + }; + + xo-therm@44 { + reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>; + label = "pmk8280_xo_therm"; + qcom,ratiometric; + qcom,hw-settle-time = <200>; + }; +}; + &qup0 { status = "okay"; };
Add VADC channels for measuring the on-chip die temperature and external crystal osciallator temperature of PMK8280. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)