| Message ID | 1394862353-28963-7-git-send-email-takahiro.akashi@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Sat, Mar 15, 2014 at 05:45:52AM +0000, AKASHI Takahiro wrote: > CALLER_ADDRx returns caller's address at specified level in call stacks. > They are used for several tracers like irqsoff and preemptoff. > Strange to say, however, they are refered even without FTRACE. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > --- > arch/arm64/include/asm/ftrace.h | 13 ++++++++- > arch/arm64/kernel/Makefile | 3 ++- > arch/arm64/kernel/return_address.c | 55 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 69 insertions(+), 2 deletions(-) > create mode 100644 arch/arm64/kernel/return_address.c > > diff --git a/arch/arm64/include/asm/ftrace.h b/arch/arm64/include/asm/ftrace.h > index ed5c448..c44c4b1 100644 > --- a/arch/arm64/include/asm/ftrace.h > +++ b/arch/arm64/include/asm/ftrace.h > @@ -18,6 +18,7 @@ > > #ifndef __ASSEMBLY__ > extern void _mcount(unsigned long); > +extern void *return_address(unsigned int); > > struct dyn_arch_ftrace { > /* No extra data needed for arm64 */ > @@ -33,6 +34,16 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr) > */ > return addr; > } > -#endif /* __ASSEMBLY__ */ > + > +#define HAVE_ARCH_CALLER_ADDR > + > +#define CALLER_ADDR0 ((unsigned long)__builtin_return_address(0)) > +#define CALLER_ADDR1 ((unsigned long)return_address(1)) > +#define CALLER_ADDR2 ((unsigned long)return_address(2)) > +#define CALLER_ADDR3 ((unsigned long)return_address(3)) > +#define CALLER_ADDR4 ((unsigned long)return_address(4)) > +#define CALLER_ADDR5 ((unsigned long)return_address(5)) > +#define CALLER_ADDR6 ((unsigned long)return_address(6)) > +#endif /* ifndef __ASSEMBLY__ */ Hmm, I thought you were going to take a look at reworking the core code for this, as Steve and I suggested? http://lists.infradead.org/pipermail/linux-arm-kernel/2014-March/240239.html Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Hi Will, On 04/16/2014 10:52 PM, Will Deacon wrote: > On Sat, Mar 15, 2014 at 05:45:52AM +0000, AKASHI Takahiro wrote: >> CALLER_ADDRx returns caller's address at specified level in call stacks. >> They are used for several tracers like irqsoff and preemptoff. >> Strange to say, however, they are refered even without FTRACE. >> >> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> >> --- >> arch/arm64/include/asm/ftrace.h | 13 ++++++++- >> arch/arm64/kernel/Makefile | 3 ++- >> arch/arm64/kernel/return_address.c | 55 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 69 insertions(+), 2 deletions(-) >> create mode 100644 arch/arm64/kernel/return_address.c >> >> diff --git a/arch/arm64/include/asm/ftrace.h b/arch/arm64/include/asm/ftrace.h >> index ed5c448..c44c4b1 100644 >> --- a/arch/arm64/include/asm/ftrace.h >> +++ b/arch/arm64/include/asm/ftrace.h >> @@ -18,6 +18,7 @@ >> >> #ifndef __ASSEMBLY__ >> extern void _mcount(unsigned long); >> +extern void *return_address(unsigned int); >> >> struct dyn_arch_ftrace { >> /* No extra data needed for arm64 */ >> @@ -33,6 +34,16 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr) >> */ >> return addr; >> } >> -#endif /* __ASSEMBLY__ */ >> + >> +#define HAVE_ARCH_CALLER_ADDR >> + >> +#define CALLER_ADDR0 ((unsigned long)__builtin_return_address(0)) >> +#define CALLER_ADDR1 ((unsigned long)return_address(1)) >> +#define CALLER_ADDR2 ((unsigned long)return_address(2)) >> +#define CALLER_ADDR3 ((unsigned long)return_address(3)) >> +#define CALLER_ADDR4 ((unsigned long)return_address(4)) >> +#define CALLER_ADDR5 ((unsigned long)return_address(5)) >> +#define CALLER_ADDR6 ((unsigned long)return_address(6)) >> +#endif /* ifndef __ASSEMBLY__ */ > > Hmm, I thought you were going to take a look at reworking the core code for > this, as Steve and I suggested? > > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-March/240239.html Sorry that I've forgot to submit a new revision with this change. I will post it soon. Thanks, -Takahiro AKASHI > Will > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Tue, May 27, 2014 at 02:10:19PM +0100, Steven Rostedt wrote: > Will, > > I made a separate branch called ftrace/arm64 as shown below. You can > pull that branch to base the rest of Akashi-san's patches on top of it. > The branch is based on top of v3.15-rc5. Thanks Steve, I'll pull that in. Akashi: please can you re-send your series, based on the branch below and including the acks/reviewed-by tags you got for v6 of the patches? Cheers, Will > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > ftrace/arm64 > > Head SHA1: eed542d6962ba33a689b4007a389f466e407bd74 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Hi Will On 05/28/2014 03:49 AM, Will Deacon wrote: > On Tue, May 27, 2014 at 02:10:19PM +0100, Steven Rostedt wrote: >> Will, >> >> I made a separate branch called ftrace/arm64 as shown below. You can >> pull that branch to base the rest of Akashi-san's patches on top of it. >> The branch is based on top of v3.15-rc5. > > Thanks Steve, I'll pull that in. > > Akashi: please can you re-send your series, based on the branch below and > including the acks/reviewed-by tags you got for v6 of the patches? Sorry again to have missed your e-mail :-) I'm sure that you can successfully apply all my patch series, without any modification, from: v6 arm64: prerequisites for audit and ftrace v8 arm64: Add ftrace support except for the patch, "[v8 1/8] ftrace: make CALLER_ADDRx macros more generic," which was replaced by a new version and already appears in Steven's repo. Thank you, -Takahiro AKASHI > Cheers, > > Will > >> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git >> ftrace/arm64 >> >> Head SHA1: eed542d6962ba33a689b4007a389f466e407bd74 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Thu, May 29, 2014 at 06:27:31AM +0100, AKASHI Takahiro wrote: > Hi Will Hi Akashi, > On 05/28/2014 03:49 AM, Will Deacon wrote: > > On Tue, May 27, 2014 at 02:10:19PM +0100, Steven Rostedt wrote: > >> Will, > >> > >> I made a separate branch called ftrace/arm64 as shown below. You can > >> pull that branch to base the rest of Akashi-san's patches on top of it. > >> The branch is based on top of v3.15-rc5. > > > > Thanks Steve, I'll pull that in. > > > > Akashi: please can you re-send your series, based on the branch below and > > including the acks/reviewed-by tags you got for v6 of the patches? > > Sorry again to have missed your e-mail :-) You should fix your filters! > I'm sure that you can successfully apply all my patch series, without any > modification, from: > v6 arm64: prerequisites for audit and ftrace > v8 arm64: Add ftrace support > except for the patch, "[v8 1/8] ftrace: make CALLER_ADDRx macros more generic," > which was replaced by a new version and already appears in Steven's repo. Yeah, you're right, I've managed to pick patches 2-8 from that posting -- thanks. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/arch/arm64/include/asm/ftrace.h b/arch/arm64/include/asm/ftrace.h index ed5c448..c44c4b1 100644 --- a/arch/arm64/include/asm/ftrace.h +++ b/arch/arm64/include/asm/ftrace.h @@ -18,6 +18,7 @@ #ifndef __ASSEMBLY__ extern void _mcount(unsigned long); +extern void *return_address(unsigned int); struct dyn_arch_ftrace { /* No extra data needed for arm64 */ @@ -33,6 +34,16 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr) */ return addr; } -#endif /* __ASSEMBLY__ */ + +#define HAVE_ARCH_CALLER_ADDR + +#define CALLER_ADDR0 ((unsigned long)__builtin_return_address(0)) +#define CALLER_ADDR1 ((unsigned long)return_address(1)) +#define CALLER_ADDR2 ((unsigned long)return_address(2)) +#define CALLER_ADDR3 ((unsigned long)return_address(3)) +#define CALLER_ADDR4 ((unsigned long)return_address(4)) +#define CALLER_ADDR5 ((unsigned long)return_address(5)) +#define CALLER_ADDR6 ((unsigned long)return_address(6)) +#endif /* ifndef __ASSEMBLY__ */ #endif /* __ASM_FTRACE_H */ diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile index ac67fd0..b5bfa7f 100644 --- a/arch/arm64/kernel/Makefile +++ b/arch/arm64/kernel/Makefile @@ -7,12 +7,13 @@ AFLAGS_head.o := -DTEXT_OFFSET=$(TEXT_OFFSET) CFLAGS_REMOVE_ftrace.o = -pg CFLAGS_REMOVE_insn.o = -pg +CFLAGS_REMOVE_return_address.o = -pg # Object file lists. arm64-obj-y := cputable.o debug-monitors.o entry.o irq.o fpsimd.o \ entry-fpsimd.o process.o ptrace.o setup.o signal.o \ sys.o stacktrace.o time.o traps.o io.o vdso.o \ - hyp-stub.o psci.o cpu_ops.o insn.o + hyp-stub.o psci.o cpu_ops.o insn.o return_address.o arm64-obj-$(CONFIG_COMPAT) += sys32.o kuser32.o signal32.o \ sys_compat.o diff --git a/arch/arm64/kernel/return_address.c b/arch/arm64/kernel/return_address.c new file mode 100644 index 0000000..89102a6 --- /dev/null +++ b/arch/arm64/kernel/return_address.c @@ -0,0 +1,55 @@ +/* + * arch/arm64/kernel/return_address.c + * + * Copyright (C) 2013 Linaro Limited + * Author: AKASHI Takahiro <takahiro.akashi@linaro.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include <linux/export.h> +#include <linux/ftrace.h> + +#include <asm/stacktrace.h> + +struct return_address_data { + unsigned int level; + void *addr; +}; + +static int save_return_addr(struct stackframe *frame, void *d) +{ + struct return_address_data *data = d; + + if (!data->level) { + data->addr = (void *)frame->pc; + return 1; + } else { + --data->level; + return 0; + } +} + +void *return_address(unsigned int level) +{ + struct return_address_data data; + struct stackframe frame; + register unsigned long current_sp asm ("sp"); + + data.level = level + 2; + data.addr = NULL; + + frame.fp = (unsigned long)__builtin_frame_address(0); + frame.sp = current_sp; + frame.pc = (unsigned long)return_address; /* dummy */ + + walk_stackframe(&frame, save_return_addr, &data); + + if (!data.level) + return data.addr; + else + return NULL; +} +EXPORT_SYMBOL_GPL(return_address);
CALLER_ADDRx returns caller's address at specified level in call stacks. They are used for several tracers like irqsoff and preemptoff. Strange to say, however, they are refered even without FTRACE. Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> --- arch/arm64/include/asm/ftrace.h | 13 ++++++++- arch/arm64/kernel/Makefile | 3 ++- arch/arm64/kernel/return_address.c | 55 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 69 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/kernel/return_address.c