Message ID | 20221117-b4-amlogic-bindings-convert-v1-0-3f025599b968@linaro.org |
---|---|
Headers | show |
Series | dt-bindings: first batch of dt-schema conversions for Amlogic Meson bindings | expand |
Hi Neil, thanks for your work on this! On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: [...] > + #address-cells = <1>; > + #size-cells = <1>; > + > + sn: sn@14 { > + reg = <0x14 0x10>; > + }; > + > + eth_mac: mac@34 { > + reg = <0x34 0x10>; > + }; > + > + bid: bid@46 { > + reg = <0x46 0x30>; > + }; I assume you took these examples from the newer, GX eFuse? Unfortunately on boards with these older SoCs the serial number and MAC address are often not stored in the eFuse. This is just an example, so I won't be sad if we keep them. To avoid confusion I suggest switching to different examples: ethernet_mac_address: mac@1b4 { reg = <0x1b4 0x6>; }; temperature_calib: calib@1f4 { reg = <0x1f4 0x4>; }; What do you think? Best regards, Martin
On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Convert the Amlogic Meson GXL USB2 PHY bindings to dt-schema. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Hi Neil, On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: [...] > + phy-names: > + const: pcie At least SM1 has a PCIe power domain So we need to allow this property as well [...] > +required: > + - compatible clocks and clock-names are missing (you have them in your example though) Best regards, Martin
Hi Neil, On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Convert the Amlogic Meson IR remote control receiver bindings to > dt-schema. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Before this is applied we need an additional patch removing the un-documented "amlogic,meson-gx-ir" compatible string from arch/arm64/boot/dts/amlogic/meson-gx.dtsi though.
On 26/11/2022 00:04, Martin Blumenstingl wrote: > Hi Neil, > > thanks for your work on this! > > On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong > <neil.armstrong@linaro.org> wrote: > [...] >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + sn: sn@14 { >> + reg = <0x14 0x10>; >> + }; >> + >> + eth_mac: mac@34 { >> + reg = <0x34 0x10>; >> + }; >> + >> + bid: bid@46 { >> + reg = <0x46 0x30>; >> + }; > I assume you took these examples from the newer, GX eFuse? > Unfortunately on boards with these older SoCs the serial number and > MAC address are often not stored in the eFuse. > This is just an example, so I won't be sad if we keep them. To avoid > confusion I suggest switching to different examples: > ethernet_mac_address: mac@1b4 { > reg = <0x1b4 0x6>; > }; > temperature_calib: calib@1f4 { > reg = <0x1f4 0x4>; > }; > > What do you think? Sure switched to it ! Neil > > > Best regards, > Martin
Batch conversion of the following bindings: - meson_sm.txt - amlogic-efuse.txt - amlogic-meson-mx-efuse.txt - meson-wdt.txt - meson-ir.txt - rtc-meson.txt - amlogic,meson6-timer.txt - meson-gxl-usb2-phy.txt - amlogic,meson-gx.txt - amlogic,meson-pcie.txt - mdio-mux-meson-g12a.txt The amlogic,meson-gx-pwrc.txt is removed since deprecated and unused for a few releases now. Martin Blumenstingl was also added as bindings maintainer for Meson6/8/8b related bindings. Remaining conversions: - meson,pinctrl.txt - pwm-meson.txt - amlogic,meson-gpio-intc.txt - amlogic,meson-mx-sdio.txt - rtc-meson-vrtc.txt - amlogic,axg-sound-card.txt - amlogic,axg-fifo.txt - amlogic,axg-pdm.txt - amlogic,axg-spdifout.txt - amlogic,axg-tdm-formatters.txt - amlogic,axg-spdifin.txt - amlogic,axg-tdm-iface.txt - amlogic,g12a-tohdmitx.txt - amlogic,axg-audio-clkc.txt - amlogic,gxbb-clkc.txt - amlogic,gxbb-aoclkc.txt - amlogic,meson8b-clkc.txt To: Rob Herring <robh+dt@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> To: Kevin Hilman <khilman@baylibre.com> To: Jerome Brunet <jbrunet@baylibre.com> To: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> To: Wim Van Sebroeck <wim@linux-watchdog.org> To: Guenter Roeck <linux@roeck-us.net> To: Mauro Carvalho Chehab <mchehab@kernel.org> To: Alessandro Zummo <a.zummo@towertech.it> To: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Daniel Lezcano <daniel.lezcano@linaro.org> To: Thomas Gleixner <tglx@linutronix.de> To: Vinod Koul <vkoul@kernel.org> To: Kishon Vijay Abraham I <kishon@kernel.org> To: Ulf Hansson <ulf.hansson@linaro.org> To: Bjorn Helgaas <bhelgaas@google.com> To: "David S. Miller" <davem@davemloft.net> To: Eric Dumazet <edumazet@google.com> To: Jakub Kicinski <kuba@kernel.org> To: Paolo Abeni <pabeni@redhat.com> To: Andrew Lunn <andrew@lunn.ch> To: Heiner Kallweit <hkallweit1@gmail.com> To: Russell King <linux@armlinux.org.uk> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-watchdog@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-rtc@vger.kernel.org Cc: linux-phy@lists.infradead.org Cc: linux-mmc@vger.kernel.org Cc: linux-pci@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- Neil Armstrong (12): dt-bindings: firmware: convert meson_sm.txt to dt-schema dt-bindings: nvmem: convert amlogic-efuse.txt to dt-schema dt-bindings: nvmem: convert amlogic-meson-mx-efuse.txt to dt-schema dt-bindings: watchdog: convert meson-wdt.txt to dt-schema dt-bindings: media: convert meson-ir.txt to dt-schema dt-bindings: rtc: convert rtc-meson.txt to dt-schema dt-bindings: power: remove deprecated amlogic,meson-gx-pwrc.txt bindings dt-bindings: timer: convert timer/amlogic,meson7-timer.txt to dt-schema dt-bindings: phy: convert meson-gxl-usb2-phy.txt to dt-schema dt-bindings: mmc: convert amlogic,meson-gx.txt to dt-schema dt-bindings: pcie: convert amlogic,meson-pcie.txt to dt-schema dt-bindings: net: convert mdio-mux-meson-g12a.txt to dt-schema .../bindings/firmware/amlogic,meson-gxbb-sm.yaml | 36 ++++++ .../bindings/firmware/meson/meson_sm.txt | 15 --- .../bindings/media/amlogic,meson6-ir.yaml | 43 +++++++ .../devicetree/bindings/media/meson-ir.txt | 20 ---- .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 78 +++++++++++++ .../devicetree/bindings/mmc/amlogic,meson-gx.txt | 39 ------- .../bindings/net/amlogic,g12a-mdio-mux.yaml | 80 +++++++++++++ .../bindings/net/mdio-mux-meson-g12a.txt | 48 -------- .../bindings/nvmem/amlogic,meson-gxbb-efuse.yaml | 52 +++++++++ .../bindings/nvmem/amlogic,meson6-efuse.yaml | 64 ++++++++++ .../devicetree/bindings/nvmem/amlogic-efuse.txt | 48 -------- .../bindings/nvmem/amlogic-meson-mx-efuse.txt | 22 ---- .../devicetree/bindings/pci/amlogic,axg-pcie.yaml | 129 +++++++++++++++++++++ .../devicetree/bindings/pci/amlogic,meson-pcie.txt | 70 ----------- .../bindings/phy/amlogic,meson-gxl-usb2-phy.yaml | 56 +++++++++ .../devicetree/bindings/phy/meson-gxl-usb2-phy.txt | 21 ---- .../bindings/power/amlogic,meson-gx-pwrc.txt | 63 ---------- .../bindings/rtc/amlogic,meson6-rtc.yaml | 62 ++++++++++ .../devicetree/bindings/rtc/rtc-meson.txt | 35 ------ .../bindings/timer/amlogic,meson6-timer.txt | 22 ---- .../bindings/timer/amlogic,meson6-timer.yaml | 53 +++++++++ .../bindings/watchdog/amlogic,meson6-wdt.yaml | 39 +++++++ .../devicetree/bindings/watchdog/meson-wdt.txt | 21 ---- 23 files changed, 692 insertions(+), 424 deletions(-) --- base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa change-id: 20221117-b4-amlogic-bindings-convert-8ef1d75d426d Best regards,