| Message ID | 20221129151959.26052-2-l.ellero@asem.it |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ads7846: fix support for ADS7845 | expand |
On 29/11/2022 17:23, Andy Shevchenko wrote: > On Tue, Nov 29, 2022 at 04:19:57PM +0100, Luca Ellero wrote: >> ADS7845 doesn't support pressure. >> This patch avoids the following error reported by libinput-list-devices: >> "ADS7845 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE". > > Fixes tag? > > If you run > > git log --no-merges -- drivers/input/touchscreen/ads7846.c > > you can get what prefix should be for these patches. > Hi Andy, thank you for your comments. I will fix the patches and resend. Regards
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index bed68a68f330..24605c40d039 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -1316,8 +1316,9 @@ static int ads7846_probe(struct spi_device *spi) pdata->y_min ? : 0, pdata->y_max ? : MAX_12BIT, 0, 0); - input_set_abs_params(input_dev, ABS_PRESSURE, - pdata->pressure_min, pdata->pressure_max, 0, 0); + if (ts->model != 7845) + input_set_abs_params(input_dev, ABS_PRESSURE, + pdata->pressure_min, pdata->pressure_max, 0, 0); /* * Parse common framework properties. Must be done here to ensure the
ADS7845 doesn't support pressure. This patch avoids the following error reported by libinput-list-devices: "ADS7845 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE". Signed-off-by: Luca Ellero <l.ellero@asem.it> --- drivers/input/touchscreen/ads7846.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)