| Message ID | 20221208084523.9733-1-walker.chen@starfivetech.com |
|---|---|
| Headers | show |
| Series | JH7110 PMU Support | expand |
On 08/12/2022 09:45, Walker Chen wrote: > Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. > > Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > --- > .../bindings/power/starfive,jh71xx-pmu.yaml | 45 +++++++++++++++++++ > .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ > 2 files changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml Filename matching compatible, so: starfive,jh7110-pmu.yaml > create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h > > diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > new file mode 100644 > index 000000000000..f308ae136a57 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/starfive,jh71xx-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH71xx Power Management Unit > + > +maintainers: > + - Walker Chen <walker.chen@starfivetech.com> > + > +description: | > + StarFive JH71xx SoCs include support for multiple power domains which can be > + powered on/off by software based on different application scenes to save power. > + > +properties: > + compatible: > + - enum: Wrong indentation. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + - starfive,jh7110-pmu > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#power-domain-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#power-domain-cells" > + Best regards, Krzysztof
On Thu, 08 Dec 2022 16:45:21 +0800, Walker Chen wrote: > Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. > > Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > --- > .../bindings/power/starfive,jh71xx-pmu.yaml | 45 +++++++++++++++++++ > .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ > 2 files changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml: properties:compatible: [{'enum': ['starfive,jh7110-pmu']}] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml: ignoring, error in schema: properties: compatible Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.example.dtb:0:0: /example-0/power-controller@17030000: failed to match any schema with compatible: ['starfive,jh7110-pmu'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221208084523.9733-2-walker.chen@starfivetech.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 2022/12/8 16:59, Krzysztof Kozlowski wrote: > On 08/12/2022 09:45, Walker Chen wrote: >> Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. >> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >> --- >> .../bindings/power/starfive,jh71xx-pmu.yaml | 45 +++++++++++++++++++ >> .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ >> 2 files changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > > Filename matching compatible, so: > starfive,jh7110-pmu.yaml OK, will be fixed. > > >> create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h >> >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml >> new file mode 100644 >> index 000000000000..f308ae136a57 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/starfive,jh71xx-pmu.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH71xx Power Management Unit >> + >> +maintainers: >> + - Walker Chen <walker.chen@starfivetech.com> >> + >> +description: | >> + StarFive JH71xx SoCs include support for multiple power domains which can be >> + powered on/off by software based on different application scenes to save power. >> + >> +properties: >> + compatible: >> + - enum: > > Wrong indentation. > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). This is my mistake, I forgot to make dt_binding_check for .yaml file. > >> + - starfive,jh7110-pmu >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + "#power-domain-cells": >> + const: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - "#power-domain-cells" >> + > > Best regards, > Krzysztof >
On 2022/12/8 21:31, Rob Herring wrote: > > On Thu, 08 Dec 2022 16:45:21 +0800, Walker Chen wrote: >> Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. >> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >> --- >> .../bindings/power/starfive,jh71xx-pmu.yaml | 45 +++++++++++++++++++ >> .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ >> 2 files changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml >> create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation) > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml: properties:compatible: [{'enum': ['starfive,jh7110-pmu']}] is not of type 'object', 'boolean' > from schema $id: http://json-schema.org/draft-07/schema# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml: ignoring, error in schema: properties: compatible > Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.example.dtb:0:0: /example-0/power-controller@17030000: failed to match any schema with compatible: ['starfive,jh7110-pmu'] > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221208084523.9733-2-walker.chen@starfivetech.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Please forgive my mistake, I forgot to make dt_binding_check for .yaml file. Now there is no complain after syntax and indentation are fixed. Thank you for your comment. Best regards, Walker Chen