| Message ID | 20221223193403.781355-4-rayyan@ansari.sh |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: dts: qcom: pm8226: style fixes and new nodes | expand |
Hi Rayyan, On Freitag, 23. Dezember 2022 20:34:03 CET Rayyan Ansari wrote: > Add a node for the current ADC (IADC) found in PM8226. > > Signed-off-by: Rayyan Ansari <rayyan@ansari.sh> > --- > arch/arm/boot/dts/qcom-pm8226.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi > b/arch/arm/boot/dts/qcom-pm8226.dtsi index 403324a35cf5..82470549f240 > 100644 > --- a/arch/arm/boot/dts/qcom-pm8226.dtsi > +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi > @@ -88,6 +88,12 @@ adc-chan@f { > }; > }; > > + pm8226_iadc: iadc@3600 { Make this adc@ to conform to qcom,spmi-pmic.yaml docs > + compatible = "qcom,spmi-iadc"; Make this "qcom,pm8226-iadc", "qcom,spmi-iadc" and add to docs to conform to qcom,spmi-iadc.yaml Regards Luca > + reg = <0x3600>; > + interrupts = <0x0 0x36 0x0 IRQ_TYPE_EDGE_RISING>; > + }; > + > rtc@6000 { > compatible = "qcom,pm8941-rtc"; > reg = <0x6000>, <0x6100>;
On Mon, Dec 26, 2022 at 01:14:59PM +0100, Luca Weiss wrote: > Hi Rayyan, > > On Freitag, 23. Dezember 2022 20:34:03 CET Rayyan Ansari wrote: > > Add a node for the current ADC (IADC) found in PM8226. > > > > Signed-off-by: Rayyan Ansari <rayyan@ansari.sh> > > --- > > arch/arm/boot/dts/qcom-pm8226.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi > > b/arch/arm/boot/dts/qcom-pm8226.dtsi index 403324a35cf5..82470549f240 > > 100644 > > --- a/arch/arm/boot/dts/qcom-pm8226.dtsi > > +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi > > @@ -88,6 +88,12 @@ adc-chan@f { > > }; > > }; > > > > + pm8226_iadc: iadc@3600 { > > Make this adc@ to conform to qcom,spmi-pmic.yaml docs > > > + compatible = "qcom,spmi-iadc"; > > Make this "qcom,pm8226-iadc", "qcom,spmi-iadc" and add to docs to conform to > qcom,spmi-iadc.yaml > I adjusted the patch according to your requests and applied it. Rayyan, please update dt binding documentation per Luca's request. Thanks, Bjorn > Regards > Luca > > > + reg = <0x3600>; > > + interrupts = <0x0 0x36 0x0 > IRQ_TYPE_EDGE_RISING>; > > + }; > > + > > rtc@6000 { > > compatible = "qcom,pm8941-rtc"; > > reg = <0x6000>, <0x6100>; > > > >
diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi index 403324a35cf5..82470549f240 100644 --- a/arch/arm/boot/dts/qcom-pm8226.dtsi +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi @@ -88,6 +88,12 @@ adc-chan@f { }; }; + pm8226_iadc: iadc@3600 { + compatible = "qcom,spmi-iadc"; + reg = <0x3600>; + interrupts = <0x0 0x36 0x0 IRQ_TYPE_EDGE_RISING>; + }; + rtc@6000 { compatible = "qcom,pm8941-rtc"; reg = <0x6000>, <0x6100>;
Add a node for the current ADC (IADC) found in PM8226. Signed-off-by: Rayyan Ansari <rayyan@ansari.sh> --- arch/arm/boot/dts/qcom-pm8226.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)