mbox series

[v2,0/4] SDM670 Interconnects

Message ID 20221230001442.369608-1-mailingradian@gmail.com
Headers show
Series SDM670 Interconnects | expand

Message

Richard Acayan Dec. 30, 2022, 12:14 a.m. UTC 
This series adds interconnects and consumers to the Snapdragon 670.

Changes:
 - change qcom,sdm670.h to qcom,sdm670-rpmh.h (1/4, 4/4)

Richard Acayan (4):
  dt-bindings: interconnect: add sdm670 interconnects
  interconnect: qcom: add sdm670 interconnects
  arm64: dts: qcom: sdm670: add interconnects
  arm64: dts: qcom: sdm670: add opps for peripherals

 .../bindings/interconnect/qcom,rpmh.yaml      |   8 +
 arch/arm64/boot/dts/qcom/sdm670.dtsi          | 165 +++++++
 drivers/interconnect/qcom/Kconfig             |   9 +
 drivers/interconnect/qcom/Makefile            |   2 +
 drivers/interconnect/qcom/sdm670.c            | 440 ++++++++++++++++++
 drivers/interconnect/qcom/sdm670.h            | 128 +++++
 .../interconnect/qcom,sdm670-rpmh.h           | 136 ++++++
 7 files changed, 888 insertions(+)
 create mode 100644 drivers/interconnect/qcom/sdm670.c
 create mode 100644 drivers/interconnect/qcom/sdm670.h
 create mode 100644 include/dt-bindings/interconnect/qcom,sdm670-rpmh.h

Comments

Krzysztof Kozlowski Dec. 30, 2022, 7:51 a.m. UTC | #1 
On 30/12/2022 01:14, Richard Acayan wrote:
> There are controllable interconnects on Snapdragon 670. Add the
> compatible strings to the documentation and interconnect ID definitions.
> 
> The device tree header was generated by
> linux-interconnect-driver-generator and the copyright year was changed.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
>  .../bindings/interconnect/qcom,rpmh.yaml      |   8 ++
>  .../interconnect/qcom,sdm670-rpmh.h           | 136 ++++++++++++++++++
>  2 files changed, 144 insertions(+)
>  create mode 100644 include/dt-bindings/interconnect/qcom,sdm670-rpmh.h


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Rob Herring Dec. 30, 2022, 4:34 p.m. UTC | #2 
On Thu, 29 Dec 2022 19:14:39 -0500, Richard Acayan wrote:
> There are controllable interconnects on Snapdragon 670. Add the
> compatible strings to the documentation and interconnect ID definitions.
> 
> The device tree header was generated by
> linux-interconnect-driver-generator and the copyright year was changed.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
>  .../bindings/interconnect/qcom,rpmh.yaml      |   8 ++
>  .../interconnect/qcom,sdm670-rpmh.h           | 136 ++++++++++++++++++
>  2 files changed, 144 insertions(+)
>  create mode 100644 include/dt-bindings/interconnect/qcom,sdm670-rpmh.h
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221230001442.369608-2-mailingradian@gmail.com


interconnect-0: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sm8450-hdk.dtb
	arch/arm64/boot/dts/qcom/sm8450-qrd.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb

interconnect@16e0000: Unevaluated properties are not allowed ('clocks' was unexpected)
	arch/arm64/boot/dts/qcom/sm8450-hdk.dtb
	arch/arm64/boot/dts/qcom/sm8450-qrd.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb

interconnect@1700000: Unevaluated properties are not allowed ('clocks' was unexpected)
	arch/arm64/boot/dts/qcom/sm8450-hdk.dtb
	arch/arm64/boot/dts/qcom/sm8450-qrd.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb

interconnect-1: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sm8450-hdk.dtb
	arch/arm64/boot/dts/qcom/sm8450-qrd.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dtb
	arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx224.dtb

interconnect-aggre1-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-aggre2-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-clk-virt: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-config-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-dc-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-gem-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-lpass-ag-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-mc-virt: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb
	arch/arm/boot/dts/qcom-sdx65-mtp.dtb

interconnect-mmss-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-nspa-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect-nspb-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb

interconnect: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtb
	arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb
	arch/arm64/boot/dts/qcom/sc7280-idp2.dtb
	arch/arm64/boot/dts/qcom/sc7280-idp.dtb

interconnect-system-noc: 'reg' is a required property
	arch/arm64/boot/dts/qcom/sa8295p-adp.dtb
	arch/arm64/boot/dts/qcom/sa8540p-ride.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dtb