| Message ID | 20230112152855.216072-1-bchihi@baylibre.com |
|---|---|
| Headers | show |
| Series | Add LVTS thermal architecture | expand |
On 12/01/2023 16:28, bchihi@baylibre.com wrote: > From: Balsam CHIHI <bchihi@baylibre.com> > > Add efuse node. > This will be required by the thermal driver to get the calibration data. > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 5d31536f4c48..09df105f4606 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -1380,6 +1380,12 @@ pciephy_glb_intr: pciephy-glb-intr@193 { > dp_calibration: dp-data@1ac { > reg = <0x1ac 0x10>; > }; > + lvts_efuse_data1: lvts1-calib@1bc { > + reg = <0x1bc 0x14>; > + }; > + lvts_efuse_data2: lvts2-calib@1d0 { > + reg = <0x1d0 0x38>; > + }; > }; > > u3phy2: t-phy@11c40000 {
On 12/01/2023 16:28, bchihi@baylibre.com wrote: > From: Balsam CHIHI <bchihi@baylibre.com> > > The mt8195 board has several hotspots around the CPUs. Specify the > targeted temperature threshold when to apply the mitigation and define > the associated cooling devices. > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 153 ++++++++++++++++++++--- > 1 file changed, 137 insertions(+), 16 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 683e5057d68d..0d6642603095 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -14,6 +14,7 @@ > #include <dt-bindings/pinctrl/mt8195-pinfunc.h> > #include <dt-bindings/power/mt8195-power.h> > #include <dt-bindings/reset/mt8195-resets.h> > +#include <dt-bindings/thermal/thermal.h> > #include <dt-bindings/thermal/mediatek-lvts.h> > > / { > @@ -2413,107 +2414,227 @@ dp_tx: dp-tx@1c600000 { > > thermal_zones: thermal-zones { > cpu0-thermal { > - polling-delay = <0>; > - polling-delay-passive = <0>; > + polling-delay = <1000>; > + polling-delay-passive = <250>; > thermal-sensors = <&lvts_mcu MT819x_MCU_LITTLE_CPU0>; New line here please. > trips { > + cpu0_alert: trip-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; New line here please and on other trip point definitions. Regards, Matthias
On Fri, Jan 13, 2023 at 12:49 PM Matthias Brugger <matthias.bgg@gmail.com> wrote: > > > > On 12/01/2023 16:28, bchihi@baylibre.com wrote: > > From: Balsam CHIHI <bchihi@baylibre.com> > > > > The mt8195 board has several hotspots around the CPUs. Specify the > > targeted temperature threshold when to apply the mitigation and define > > the associated cooling devices. > > > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 153 ++++++++++++++++++++--- > > 1 file changed, 137 insertions(+), 16 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > index 683e5057d68d..0d6642603095 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > @@ -14,6 +14,7 @@ > > #include <dt-bindings/pinctrl/mt8195-pinfunc.h> > > #include <dt-bindings/power/mt8195-power.h> > > #include <dt-bindings/reset/mt8195-resets.h> > > +#include <dt-bindings/thermal/thermal.h> > > #include <dt-bindings/thermal/mediatek-lvts.h> > > > > / { > > @@ -2413,107 +2414,227 @@ dp_tx: dp-tx@1c600000 { > > > > thermal_zones: thermal-zones { > > cpu0-thermal { > > - polling-delay = <0>; > > - polling-delay-passive = <0>; > > + polling-delay = <1000>; > > + polling-delay-passive = <250>; > > thermal-sensors = <&lvts_mcu MT819x_MCU_LITTLE_CPU0>; > > New line here please. > > > trips { > > + cpu0_alert: trip-alert { > > + temperature = <85000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > New line here please and on other trip point definitions. > Hi Matthias, Thank you for the feedback! It will be added in the next version. Best regards, Balsam > Regards, > Matthias
From: Balsam CHIHI <bchihi@baylibre.com> The LVTS (Low Voltage Thermal Sensor) driver is capable of monitoring multiple hot points. For that, it contains 7 thermal control blocks dedicated to specific devices on the die. Each control block can handle up to 4 sensors. The thermal controller supports several interrupts. One for the cold trip point, the hot trip point, the return to the normal trip point, and a specific programmable trip point to monitor the temperature dynamically. The temperature measurement can be done in two ways, the immediate mode where the temperature read is instantaneous and the filtered mode where the controller uses, by configuration, an average of a set of values removing the minimum and the maximum. Finally, it is composed of 2 finite-state machines responsible for the state of the temperature (cold, hot, hot 2 normal, hot hot), the triggering of the interrupts, and the monitoring of the temperature. As requested, the thermal driver has been reworked to reduce the complexity of the code. At this time, the 4 little CPUs and the 4 big CPUs are supported by the thermal driver.They are described in a data structure and more devices can be added later. The calibration routine has been simplified also. The series provide the following changes: - Move the Mediatek drivers inside a dedicated folder as their number is increasing - Add the DT bindings for the controller - Add the efuse node for the mt8195 - The LVTS driver - The thermal zones description in the DT Changelog: v10: - Rebase on top of "thermal/linux-next" - Rework the LVTS driver - Add the thermal trip temperature and cooling devices for the sensors supported by the driver v9: - Rebase on top of 6.0.0-rc1 - Fix coding style issues - Fix commit titles and commit messages - Update dt-bindings : - Add "allOf:if:then:" - Use mt8192 as example (instead of mt8195) - Fix dt-binding errors - Fix DTS errors v8: - Fix coding style issues - Rebase on top of next-20220803 - Add multi-instance support : - Rewrite DT-binding and DTS : - Add DT-binding and DTS for LVTS_v4 (MT8192 and MT8195) - One LVTS node for each HW Domain (AP and MCU) - One SW Instance for each HW Domain - Add a Kconfig sub-menu entry for LVTS and LVTS_v4 SoCs - Replace platform_get_resource by platform_get_mem_or_io to get Base Address - Replace platform_get_resource by platform_get_irq to get Interrupt Number - Add "lvts_" prefix to functions and structs v7: - Fix coding style issues - Rewrite dt bindings - was not accurate - Use mt8195 for example (instead of mt8192) - Rename mt6873 to mt8192 - Remove clock name - Rebased on top of to series: - patchwork.kernel.org/project/linux-mediatek/list/?series=637849 - patchwork.kernel.org/project/linux-pm/list/?series=639386 v6: - Remove temperature aggregation (it will be added in another series) - Update the way to read the temperature (read one sensor instead of all) - Add support of mt8195 v5: - Use 'git mv' for the relocated file. v4: - Rebase to kernel-v5.13-rc1 v3: - change the expression in the lvts_temp_to_raw to dev_s64. v2: - Rebase to kernel-5.11-rc1. - sort headers - remove initial value 0 of msr_raw in the lvts_temp_to_raw. - disconstruct the api of lvts_read_tc_msr_raw. - add the initial value max_temp = 0 and compare e.q. in the lvts_read_all_tc_temperature. - add the return with an invalid number in the lvts_init. Balsam CHIHI (6): thermal/drivers/mediatek: Relocate driver to mediatek folder dt-bindings/thermal/mediatek: Add dt-binding document for LVTS thermal controllers arm64/dts/mt8195: Add efuse node to mt8195 thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver arm64/dts/mt8195: Add thermal zones and thermal nodes arm64/dts/mt8195: Add temperature mitigation threshold .../thermal/mediatek,lvts-thermal.yaml | 140 ++ arch/arm64/boot/dts/mediatek/mt8195.dtsi | 256 ++++ drivers/thermal/Kconfig | 14 +- drivers/thermal/Makefile | 2 +- drivers/thermal/mediatek/Kconfig | 36 + drivers/thermal/mediatek/Makefile | 2 + .../auxadc_thermal.c} | 2 +- drivers/thermal/mediatek/lvts_thermal.c | 1244 +++++++++++++++++ include/dt-bindings/thermal/mediatek-lvts.h | 19 + 9 files changed, 1703 insertions(+), 12 deletions(-) create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml create mode 100644 drivers/thermal/mediatek/Kconfig create mode 100644 drivers/thermal/mediatek/Makefile rename drivers/thermal/{mtk_thermal.c => mediatek/auxadc_thermal.c} (99%) create mode 100644 drivers/thermal/mediatek/lvts_thermal.c create mode 100644 include/dt-bindings/thermal/mediatek-lvts.h