diff mbox series

efi_loader: update the error message of TCG protocol installation

Message ID 20230119142915.492407-1-ilias.apalodimas@linaro.org
State Accepted
Commit cd63e2d26c7c080c8bdb4ea40b4bfc1320ce2aee
Headers show
Series efi_loader: update the error message of TCG protocol installation | expand

Commit Message

Ilias Apalodimas Jan. 19, 2023, 2:29 p.m. UTC
"Unable to find TPMv2 device" doesn't explain much with regards to the
error origin. Update it to match what we have in the RNG protocol
installation.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 lib/efi_loader/efi_tcg2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.38.1

Comments

Heinrich Schuchardt Jan. 19, 2023, 4:15 p.m. UTC | #1
On 1/19/23 15:29, Ilias Apalodimas wrote:
> "Unable to find TPMv2 device" doesn't explain much with regards to the
> error origin. Update it to match what we have in the RNG protocol
> installation.
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

> ---
>   lib/efi_loader/efi_tcg2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c
> index a525ebf75b58..d7cce97ced5e 100644
> --- a/lib/efi_loader/efi_tcg2.c
> +++ b/lib/efi_loader/efi_tcg2.c
> @@ -2417,7 +2417,7 @@ efi_status_t efi_tcg2_register(void)
> 
>   	ret = platform_get_tpm2_device(&dev);
>   	if (ret != EFI_SUCCESS) {
> -		log_warning("Unable to find TPMv2 device\n");
> +		log_warning("Missing TPMv2 device for EFI_TCG_PROTOCOL\n");
>   		return EFI_SUCCESS;
>   	}
> 
> --
> 2.38.1
>
diff mbox series

Patch

diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c
index a525ebf75b58..d7cce97ced5e 100644
--- a/lib/efi_loader/efi_tcg2.c
+++ b/lib/efi_loader/efi_tcg2.c
@@ -2417,7 +2417,7 @@  efi_status_t efi_tcg2_register(void)

 	ret = platform_get_tpm2_device(&dev);
 	if (ret != EFI_SUCCESS) {
-		log_warning("Unable to find TPMv2 device\n");
+		log_warning("Missing TPMv2 device for EFI_TCG_PROTOCOL\n");
 		return EFI_SUCCESS;
 	}