| Message ID | 20230123023127.1186619-2-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Add MSM8939 SoC support with two devices | expand |
On 23/01/2023 03:31, Bryan O'Donoghue wrote: > The MSM8939 has two DSI controllers as opposed to the MSM8916 which has > one. As a consequence we need to document some additional clocks provided > by the MSM8939 GCC which are not provided by MSM8916. > > Move the declaration of the MSM8939 super-set of clocks to an MSM8939 > specific yaml file. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 23 Jan 2023 02:31:22 +0000, Bryan O'Donoghue wrote: > The MSM8939 has two DSI controllers as opposed to the MSM8916 which has > one. As a consequence we need to document some additional clocks provided > by the MSM8939 GCC which are not provided by MSM8916. > > Move the declaration of the MSM8939 super-set of clocks to an MSM8939 > specific yaml file. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/clock/qcom,gcc-msm8916.yaml | 7 +- > .../bindings/clock/qcom,gcc-msm8939.yaml | 87 +++++++++++++++++++ > 2 files changed, 89 insertions(+), 5 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.example.dts:18:18: fatal error: dt-bindings/clock/qcom,rpm.h: No such file or directory 18 | #include <dt-bindings/clock/qcom,rpm.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1508: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230123023127.1186619-2-bryan.odonoghue@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml index ad84c0f7680be..016d310be3c83 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8916.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/clock/qcom,gcc-msm8916.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Qualcomm Global Clock & Reset Controller on MSM8916 and MSM8939 +title: Qualcomm Global Clock & Reset Controller on MSM8916. maintainers: - Stephen Boyd <sboyd@kernel.org> @@ -12,19 +12,16 @@ maintainers: description: | Qualcomm global clock control module provides the clocks, resets and power - domains on MSM8916 or MSM8939. + domains on MSM8916. See also:: include/dt-bindings/clock/qcom,gcc-msm8916.h - include/dt-bindings/clock/qcom,gcc-msm8939.h include/dt-bindings/reset/qcom,gcc-msm8916.h - include/dt-bindings/reset/qcom,gcc-msm8939.h properties: compatible: enum: - qcom,gcc-msm8916 - - qcom,gcc-msm8939 clocks: items: diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.yaml new file mode 100644 index 0000000000000..92a811d6ad97b --- /dev/null +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8939.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Global Clock & Reset Controller on MSM8939. + +maintainers: + - Bryan O'Donoghue <bryan.odonoghue@linaro.org> + +description: | + Qualcomm global clock control module provides the clocks, resets and power + domains on MSM8939. + + See also:: + include/dt-bindings/clock/qcom,gcc-msm8939.h + include/dt-bindings/reset/qcom,gcc-msm8939.h + +properties: + compatible: + enum: + - qcom,gcc-msm8939 + + clocks: + items: + - description: XO source + - description: Sleep clock source + - description: DSI phy instance 0 dsi clock + - description: DSI phy instance 0 byte clock + - description: DSI phy instance 1 dsi clock + - description: DSI phy instance 1 byte clock + - description: External MCLK clock + - description: External Primary I2S clock + - description: External Secondary I2S clock + + clock-names: + items: + - const: xo + - const: sleep_clk + - const: dsi0pll + - const: dsi0pllbyte + - const: dsi1pll + - const: dsi1pllbyte + - const: ext_mclk + - const: ext_pri_i2s + - const: ext_sec_i2s + +required: + - compatible + - clocks + - clock-names + +allOf: + - $ref: qcom,gcc.yaml# + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,rpm.h> + clock-controller@1800000 { + compatible = "qcom,gcc-msm8939"; + reg = <0x01800000 0x80000>; + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, + <&sleep_clk>, + <&dsi_phy0 1>, + <&dsi_phy0 0>, + <&dsi_phy1 1>, + <&dsi_phy1 0>, + <0>, + <0>, + <0>; + clock-names = "xo", + "sleep_clk", + "dsi0pll", + "dsi0pllbyte", + "dsi1pll", + "dsi1pllbyte", + "ext_mclk", + "ext_pri_i2s", + "ext_sec_i2s"; + #clock-cells = <1>; + #reset-cells = <1>; + #power-domain-cells = <1>; + }; +...
The MSM8939 has two DSI controllers as opposed to the MSM8916 which has one. As a consequence we need to document some additional clocks provided by the MSM8939 GCC which are not provided by MSM8916. Move the declaration of the MSM8939 super-set of clocks to an MSM8939 specific yaml file. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../bindings/clock/qcom,gcc-msm8916.yaml | 7 +- .../bindings/clock/qcom,gcc-msm8939.yaml | 87 +++++++++++++++++++ 2 files changed, 89 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8939.yaml