mbox series

[v4,0/2] mmc: atmel-mci: Convert to gpio descriptors

Message ID 20230221094207.102006-1-balamanikandan.gunasundar@microchip.com
Headers show
Series mmc: atmel-mci: Convert to gpio descriptors | expand

Message

Balamanikandan Gunasundar Feb. 21, 2023, 9:42 a.m. UTC 
Replace legacy gpio apis with gpio descriptors. This v4 is just a
rebase to the "next" branch of
https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git

I would like to have the improvements suggested by Linus as a separate
patch. Please let me know your comments.
https://lore.kernel.org/all/CACRpkdbORVt9sFCnBFE1U206M92u4fjk9enbDJYZw7HJyAC=ng@mail.gmail.com/

v4:

- Rebase on top of next branch
  https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git 

v3:

- [PATCH v3 1/2] mmc: atmel-mci: Convert to gpio descriptors
  Convert devm_gpiod_get_from_of_node() into devm_fwnode_gpiod_get()

v2:

- [PATCH 1/2] mmc: atmel-mci: Convert to gpio descriptors
  Remove "#include <linux/gpio.h>" as it is not necessary

- [PATCH 2/2] mmc: atmel-mci: move atmel MCI header file
  Move linux/atmel-mci.h into drivers/mmc/host/atmel-mci.c as it is
  used only by one file

Balamanikandan Gunasundar (2):
  mmc: atmel-mci: Convert to gpio descriptors
  mmc: atmel-mci: move atmel MCI header file

 drivers/mmc/host/atmel-mci.c | 116 ++++++++++++++++++++++-------------
 include/linux/atmel-mci.h    |  46 --------------
 2 files changed, 75 insertions(+), 87 deletions(-)
 delete mode 100644 include/linux/atmel-mci.h

Comments

Linus Walleij Feb. 21, 2023, 11:10 a.m. UTC | #1 
On Tue, Feb 21, 2023 at 10:42 AM Balamanikandan Gunasundar
<balamanikandan.gunasundar@microchip.com> wrote:

> Replace the legacy GPIO APIs with gpio descriptor consumer interface.
> To maintain backward compatibility, we rely on the "cd-inverted"
> property to manage the invertion flag instead of GPIO property.
>
> Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@microchip.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij