mbox series

[v3,0/6] hw/vfio/ccw: hw: Use QOM macros and remove DO_UPCAST() uses

Message ID 20230213170145.45666-1-philmd@linaro.org
Headers show
Series hw/vfio/ccw: hw: Use QOM macros and remove DO_UPCAST() uses | expand

Message

Philippe Mathieu-Daudé Feb. 13, 2023, 5:01 p.m. UTC 
QOM housekeeping series which replace the DO_UPCAST() macro
uses by equivalent QOM ones (and few more trivial cleanups).

Since v2:
- Split of bigger series
- Split in simpler patches
- Added Eric R-b tags

v2:
https://lore.kernel.org/qemu-devel/20230213070820.76881-17-philmd@linaro.org/

Philippe Mathieu-Daudé (6):
  hw/s390x/event-facility: Replace DO_UPCAST(SCLPEvent) by SCLP_EVENT()
  hw/vfio/ccw: Simplify using DEVICE() macro
  hw/vfio/ccw: Use intermediate S390CCWDevice variable
  hw/vfio/ccw: Replace DO_UPCAST(S390CCWDevice) by S390_CCW_DEVICE()
  hw/vfio/ccw: Remove pointless S390CCWDevice variable
  hw/vfio/ccw: Replace DO_UPCAST(VFIOCCWDevice) by VFIO_CCW()

 hw/s390x/event-facility.c |  3 +--
 hw/vfio/ccw.c             | 40 ++++++++++++++++-----------------------
 2 files changed, 17 insertions(+), 26 deletions(-)

Comments

Philippe Mathieu-Daudé Feb. 27, 2023, 11:15 a.m. UTC | #1 
Hi Alex,

On 13/2/23 18:01, Philippe Mathieu-Daudé wrote:
> QOM housekeeping series which replace the DO_UPCAST() macro
> uses by equivalent QOM ones (and few more trivial cleanups).
> 
> Since v2:
> - Split of bigger series
> - Split in simpler patches
> - Added Eric R-b tags
> 
> v2:
> https://lore.kernel.org/qemu-devel/20230213070820.76881-17-philmd@linaro.org/
> 
> Philippe Mathieu-Daudé (6):
>    hw/s390x/event-facility: Replace DO_UPCAST(SCLPEvent) by SCLP_EVENT()

Thomas took the first patch,

>    hw/vfio/ccw: Simplify using DEVICE() macro
>    hw/vfio/ccw: Use intermediate S390CCWDevice variable
>    hw/vfio/ccw: Replace DO_UPCAST(S390CCWDevice) by S390_CCW_DEVICE()
>    hw/vfio/ccw: Remove pointless S390CCWDevice variable
>    hw/vfio/ccw: Replace DO_UPCAST(VFIOCCWDevice) by VFIO_CCW()

Could you take the other ones via your VFIO tree?
(all patches reviewed).

Thanks,

Phil.
Thomas Huth Feb. 27, 2023, 11:46 a.m. UTC | #2 
On 27/02/2023 12.15, Philippe Mathieu-Daudé wrote:
> Hi Alex,
> 
> On 13/2/23 18:01, Philippe Mathieu-Daudé wrote:
>> QOM housekeeping series which replace the DO_UPCAST() macro
>> uses by equivalent QOM ones (and few more trivial cleanups).
>>
>> Since v2:
>> - Split of bigger series
>> - Split in simpler patches
>> - Added Eric R-b tags
>>
>> v2:
>> https://lore.kernel.org/qemu-devel/20230213070820.76881-17-philmd@linaro.org/
>>
>> Philippe Mathieu-Daudé (6):
>>    hw/s390x/event-facility: Replace DO_UPCAST(SCLPEvent) by SCLP_EVENT()
> 
> Thomas took the first patch,
> 
>>    hw/vfio/ccw: Simplify using DEVICE() macro
>>    hw/vfio/ccw: Use intermediate S390CCWDevice variable
>>    hw/vfio/ccw: Replace DO_UPCAST(S390CCWDevice) by S390_CCW_DEVICE()
>>    hw/vfio/ccw: Remove pointless S390CCWDevice variable
>>    hw/vfio/ccw: Replace DO_UPCAST(VFIOCCWDevice) by VFIO_CCW()
> 
> Could you take the other ones via your VFIO tree?
> (all patches reviewed).

I've picked the other patches now, too (since they've got a Reviewed-by by 
one of the vfio-ccw maintainers now).

  Thomas
Philippe Mathieu-Daudé Feb. 27, 2023, 12:30 p.m. UTC | #3 
On 27/2/23 12:46, Thomas Huth wrote:
> On 27/02/2023 12.15, Philippe Mathieu-Daudé wrote:
>> Hi Alex,

>> Could you take the other ones via your VFIO tree?
>> (all patches reviewed).
> 
> I've picked the other patches now, too (since they've got a Reviewed-by 
> by one of the vfio-ccw maintainers now).

Thank you :)