| Message ID | 20230329222246.3292766-1-andreas@kemnade.info |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: omap: Convert omap.txt to yaml | expand |
* Andreas Kemnade <andreas@kemnade.info> [230329 22:22]: > From: Andrew Davis <afd@ti.com> > > Convert omap.txt to yaml. > Documentation/devicetree/bindings/arm/ti.yaml | 157 ++++++++++++++++++ > 1 file changed, 157 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/ti.yaml Great, can we also drop the old txt file or is more changes needed before we can do that? Regards, Tony
On 30/03/2023 13:39, Tony Lindgren wrote: > * Andreas Kemnade <andreas@kemnade.info> [230329 22:22]: >> From: Andrew Davis <afd@ti.com> >> >> Convert omap.txt to yaml. >> Documentation/devicetree/bindings/arm/ti.yaml | 157 ++++++++++++++++++ >> 1 file changed, 157 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/ti.yaml > > Great, can we also drop the old txt file or is more changes needed before > we can do that? Yeah, conversion is always a move (remove + add). Half of the process is missing here. Best regards, Krzysztof
On Thu, 30 Mar 2023 14:39:18 +0300 Tony Lindgren <tony@atomide.com> wrote: > * Andreas Kemnade <andreas@kemnade.info> [230329 22:22]: > > From: Andrew Davis <afd@ti.com> > > > > Convert omap.txt to yaml. > > Documentation/devicetree/bindings/arm/ti.yaml | 157 ++++++++++++++++++ > > 1 file changed, 157 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/ti.yaml > > Great, can we also drop the old txt file or is more changes needed before > we can do that? > we have still - ti,hwmods: list of hwmod names (ascii strings), that comes from the OMAP HW documentation, attached to a device. Must contain at least one hwmod. Optional properties: - ti,no_idle_on_suspend: When present, it prevents the PM to idle the module during suspend. - ti,no-reset-on-init: When present, the module should not be reset at init - ti,no-idle-on-init: When present, the module should not be idled at init - ti,no-idle: When present, the module is never allowed to idle. These optional properties are not in the root node but in subnodes. From my guts feeling this belongs in a separate file and should be somehow dealed with in a second step. So how to proceed? BTW: I think this file then also belongs into OMAP2+ SUPPORT section of MAINTAINERS Regards, Andreas
* Andreas Kemnade <andreas@kemnade.info> [230330 16:15]: > On Thu, 30 Mar 2023 14:39:18 +0300 > Tony Lindgren <tony@atomide.com> wrote: > > > * Andreas Kemnade <andreas@kemnade.info> [230329 22:22]: > > > From: Andrew Davis <afd@ti.com> > > > > > > Convert omap.txt to yaml. > > > Documentation/devicetree/bindings/arm/ti.yaml | 157 ++++++++++++++++++ > > > 1 file changed, 157 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/arm/ti.yaml > > > > Great, can we also drop the old txt file or is more changes needed before > > we can do that? > > > we have still > - ti,hwmods: list of hwmod names (ascii strings), that comes from the OMAP > HW documentation, attached to a device. Must contain at least > one hwmod. > > Optional properties: > - ti,no_idle_on_suspend: When present, it prevents the PM to idle the module > during suspend. > - ti,no-reset-on-init: When present, the module should not be reset at init > - ti,no-idle-on-init: When present, the module should not be idled at init > - ti,no-idle: When present, the module is never allowed to idle. These are documented in the ti-sysc.yaml for the current SoCs, but not for the legacy SoC still using ti,hwmods. > These optional properties are not in the root node but in subnodes. > From my guts feeling this belongs in a separate file and should > be somehow dealed with in a second step. Agreed. > So how to proceed? How about just rename the hwmods related parts of omap.txt to something like ti-hwmods.txt? > BTW: I think this file then also belongs into > OMAP2+ SUPPORT section of MAINTAINERS Yeah that helps for receiving related emails :) Regards, Tony
On 30/03/2023 18:15, Andreas Kemnade wrote: > On Thu, 30 Mar 2023 14:39:18 +0300 > Tony Lindgren <tony@atomide.com> wrote: > >> * Andreas Kemnade <andreas@kemnade.info> [230329 22:22]: >>> From: Andrew Davis <afd@ti.com> >>> >>> Convert omap.txt to yaml. >>> Documentation/devicetree/bindings/arm/ti.yaml | 157 ++++++++++++++++++ >>> 1 file changed, 157 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/ti.yaml >> >> Great, can we also drop the old txt file or is more changes needed before >> we can do that? >> > we have still > - ti,hwmods: list of hwmod names (ascii strings), that comes from the OMAP > HW documentation, attached to a device. Must contain at least > one hwmod. > > Optional properties: > - ti,no_idle_on_suspend: When present, it prevents the PM to idle the module > during suspend. > - ti,no-reset-on-init: When present, the module should not be reset at init > - ti,no-idle-on-init: When present, the module should not be idled at init > - ti,no-idle: When present, the module is never allowed to idle. > > These optional properties are not in the root node but in subnodes. > From my guts feeling this belongs in a separate file and should > be somehow dealed with in a second step. > > So how to proceed? Any compatible converted to DT Schema should be removed from TXT. It does not mean entire TXT has to be removed if it contains other pieces. Best regards, Krzysztof
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230331 09:43]: > On 30/03/2023 18:15, Andreas Kemnade wrote: > > On Thu, 30 Mar 2023 14:39:18 +0300 > > Tony Lindgren <tony@atomide.com> wrote: > > > >> * Andreas Kemnade <andreas@kemnade.info> [230329 22:22]: > >>> From: Andrew Davis <afd@ti.com> > >>> > >>> Convert omap.txt to yaml. > >>> Documentation/devicetree/bindings/arm/ti.yaml | 157 ++++++++++++++++++ > >>> 1 file changed, 157 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/arm/ti.yaml > >> > >> Great, can we also drop the old txt file or is more changes needed before > >> we can do that? > >> > > we have still > > - ti,hwmods: list of hwmod names (ascii strings), that comes from the OMAP > > HW documentation, attached to a device. Must contain at least > > one hwmod. > > > > Optional properties: > > - ti,no_idle_on_suspend: When present, it prevents the PM to idle the module > > during suspend. > > - ti,no-reset-on-init: When present, the module should not be reset at init > > - ti,no-idle-on-init: When present, the module should not be idled at init > > - ti,no-idle: When present, the module is never allowed to idle. > > > > These optional properties are not in the root node but in subnodes. > > From my guts feeling this belongs in a separate file and should > > be somehow dealed with in a second step. > > > > So how to proceed? > > Any compatible converted to DT Schema should be removed from TXT. It > does not mean entire TXT has to be removed if it contains other pieces. Sounds good to me. Tony
diff --git a/Documentation/devicetree/bindings/arm/ti.yaml b/Documentation/devicetree/bindings/arm/ti.yaml new file mode 100644 index 000000000000..735e3f0e8143 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/ti.yaml @@ -0,0 +1,157 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/ti.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments OMAP SoC architecture + +maintainers: + - Tony Lindgren <tony@atomide.com> + +description: Platforms based on Texas Instruments OMAP SoC architecture. + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: TI OMAP2420 SoC based platforms + items: + - enum: + - ti,omap2420-h4 + - nokia,n800 + - nokia,n810 + - nokia,n810-wimax + - const: ti,omap2420 + - const: ti,omap2 + + - description: TI OMAP2430 SoC based platforms + items: + - enum: + - ti,omap2430-sdp # TI OMAP2430 SDP + - const: ti,omap2430 + - const: ti,omap2 + + - description: TI OMAP3430 SoC based platforms + items: + - enum: + - logicpd,dm3730-som-lv-devkit # LogicPD Zoom OMAP35xx SOM-LV Development Kit + - logicpd,dm3730-torpedo-devkit # LogicPD Zoom OMAP35xx Torpedo Development Kit + - ti,omap3430-sdp + - ti,omap3-beagle + - compulab,omap3-cm-t3530 + - timll,omap3-devkit8000 + - ti,omap3-evm # TI OMAP35XX EVM (TMDSEVM3530) + - ti,omap3-ldp # TI OMAP3430 LDP (Zoom1 Labrador) + - nokia,omap3-n900 + - openpandora,omap3-pandora-600mhz + - const: ti,omap3430 + - const: ti,omap3 + + - description: TI OMAP3630 SoC based platforms + items: + - enum: + - logicpd,dm3730-som-lv-devkit # LogicPD Zoom DM3730 SOM-LV Development Kit + - logicpd,dm3730-torpedo-devkit # LogicPD Zoom DM3730 Torpedo + Wireless Development Kit + - ti,omap3-beagle-xm + - compulab,omap3-cm-t3730 + - amazon,omap3-echo # Amazon Echo (first generation) + - ti,omap3-evm-37xx # TI OMAP37XX EVM (TMDSEVM3730) + - goldelico,gta04 + - nokia,omap3-n9 + - nokia,omap3-n950 + - lg,omap3-sniper # LG Optimus Black + - ti,omap3-zoom3 + - openpandora,omap3-pandora-1ghz + - const: ti,omap3630 + - const: ti,omap3 + + - description: TI AM35 SoC based platforms + items: + - enum: + - teejet,mt_ventoux + - ti,am3517-craneboard # TI AM3517 CraneBoard (TMDSEVM3517) + - ti,am3517-evm # TI AM3517 EVM (AM3517/05 TMDSEVM3517) + - compulab,omap3-sbc-t3517 # CompuLab SBC-T3517 with CM-T3517 + - const: ti,am3517 + - const: ti,omap3 + + - description: TI OMAP4430 SoC based platforms + items: + - enum: + - motorola,droid4 # Motorola Droid 4 XT894 + - motorola,droid-bionic # Motorola Droid Bionic XT875 + - amazon,omap4-kc1 # Amazon Kindle Fire (first generation) + - ti,omap4-panda + - ti,omap4-sdp + - const: ti,omap4430 + - const: ti,omap4 + + - description: TI OMAP4460 SoC based platforms + items: + - enum: + - ti,omap4-panda-es + - epson,epson,embt2ws # Epson Moverio BT-200 + - const: ti,omap4460 + - const: ti,omap4 + + - description: TI OMAP5 SoC based platforms + items: + - enum: + - compulab,omap5-cm-t54 + - isee,omap5-igep0050 + - ti,omap5-uevm + - const: ti,omap5 + + - description: TI AM33 SoC based platforms + items: + - enum: + - ti,am335x-bone + - compulab,cm-t335 + - ti,am335x-evm + - ti,am335x-evmsk + - bosch,am335x-guardian + - ti,am3359-icev2 + - novatech,am335x-lxm # NovaTech OrionLXm + - moxa,uc-2101 + - moxa,uc-8100-me-t + - gumstix,am335x-pepper + - tcl,am335x-sl50 # Toby Churchill SL50 Series + - pattern: '^ti,am33(5[1246789]|xx)$' # ti,am33xx is legacy please use full SoC name + + - description: TI AM43 SoC based platforms + items: + - enum: + - compulab,am437x-cm-t43 + - ti,am437x-gp-evm + - ti,am437x-idk-evm + - ti,am437x-sk-evm + - pattern: '^ti,am4372[26789]$' + - const: ti,am43 + + - description: TI AM57 SoC based platforms + items: + - enum: + - beagle,am5729-beagleboneai + - compulab,cl-som-am57x + - ti,am5718-idk + - ti,am5728-idk + - ti,am5748-idk + - pattern: '^ti,am57[0124][689]$' + - const: ti,am57 + + - description: TI DRA7 SoC based platforms + items: + - enum: + - ti,dra718-evm + - ti,dra722-evm + - ti,dra742-evm + - ti,dra762-evm + - pattern: '^ti,dra7[12456][024568p]$' + - const: ti,dra7 + +additionalProperties: true + +...