| Message ID | 20230407050803.170773-2-andreas@kemnade.info |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds: Add a driver for the BD2606MVV | expand |
On 07/04/2023 07:08, Andreas Kemnade wrote: > Document ROHM BD2606MVV LED driver devicetree bindings. Subject: maybe drop "driver" (suggests it is for Linux drivers, although maybe it matches the actual hardware here?) and add missing verb, e.g. "Add ROHM ..." > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > .../bindings/leds/rohm,bd2606mvv.yaml | 83 +++++++++++++++++++ > 1 file changed, 83 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > > diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > new file mode 100644 > index 0000000000000..7f53d09e7b054 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/rohm,bd2606mvv.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: BD2606MVV LED controller ROHM BD.... > + > +maintainers: > + - Andreas Kemnade <andreas@kemnade.info> > + > +description: > + The BD2606 MVV is a programmable LED controller connected via I2C that can > + drive 6 separate lines. Each of them can be individually switched on and off > + but the brightness setting is shared between two of them. > + > + Datasheet is available at > + https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/led_driver/bd2606mvv_1-e.pdf > + > +properties: > + compatible: > + const: rohm,bd2606mvv > + > + reg: > + description: I2C slave address of the controller. Drop description, it's obvious. > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + enable-gpios: > + maxItems: 1 > + description: GPIO pin to enable/disable the device. > + > +patternProperties: > + "^led@[0-6]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + minimum: 0 > + maximum: 6 > + > + required: > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + Drop blank line > + #include <dt-bindings/leds/common.h> > + > + i2c0 { i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led-controller@66 { > + compatible = "rohm,bd2606mvv"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x66>; reg is always second property in DTS. > + > + led@0 { > + color = <LED_COLOR_ID_RED>; > + function = LED_FUNCTION_POWER; > + reg = <0x0>; Ditto Best regards, Krzysztof
On Mon, 10 Apr 2023 17:34:00 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: [...] > > + led-controller@66 { > > + compatible = "rohm,bd2606mvv"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0x66>; > > reg is always second property in DTS. > > > + > > + led@0 { > > + color = <LED_COLOR_ID_RED>; > > + function = LED_FUNCTION_POWER; > > + reg = <0x0>; > > Ditto > hmm, reg also second if no compatible first? I see it usually first in such cases. Regards, Andreas
On 11/04/2023 21:30, Andreas Kemnade wrote: > On Mon, 10 Apr 2023 17:34:00 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > [...] >>> + led-controller@66 { >>> + compatible = "rohm,bd2606mvv"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + reg = <0x66>; >> >> reg is always second property in DTS. >> >>> + >>> + led@0 { >>> + color = <LED_COLOR_ID_RED>; >>> + function = LED_FUNCTION_POWER; >>> + reg = <0x0>; >> >> Ditto >> > hmm, reg also second if no compatible first? I see it usually first in > such cases. Right, then reg is first. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml new file mode 100644 index 0000000000000..7f53d09e7b054 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml @@ -0,0 +1,83 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/rohm,bd2606mvv.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BD2606MVV LED controller + +maintainers: + - Andreas Kemnade <andreas@kemnade.info> + +description: + The BD2606 MVV is a programmable LED controller connected via I2C that can + drive 6 separate lines. Each of them can be individually switched on and off + but the brightness setting is shared between two of them. + + Datasheet is available at + https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/led_driver/bd2606mvv_1-e.pdf + +properties: + compatible: + const: rohm,bd2606mvv + + reg: + description: I2C slave address of the controller. + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + enable-gpios: + maxItems: 1 + description: GPIO pin to enable/disable the device. + +patternProperties: + "^led@[0-6]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + minimum: 0 + maximum: 6 + + required: + - reg + +additionalProperties: false + +examples: + - | + + #include <dt-bindings/leds/common.h> + + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@66 { + compatible = "rohm,bd2606mvv"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x66>; + + led@0 { + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_POWER; + reg = <0x0>; + }; + + led@2 { + color = <LED_COLOR_ID_WHITE>; + function = LED_FUNCTION_STATUS; + reg = <0x2>; + }; + }; + }; + +...
Document ROHM BD2606MVV LED driver devicetree bindings. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- .../bindings/leds/rohm,bd2606mvv.yaml | 83 +++++++++++++++++++ 1 file changed, 83 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml