diff mbox series

[v2,4/4] acpi: Add defines for CDAT SSLBIS

Message ID 168443480048.2966470.1931302851443645778.stgit@djiang5-mobl3
State Superseded
Headers show
Series acpi: Add CDAT parsing support to ACPI tables code | expand

Commit Message

Dave Jiang May 18, 2023, 6:33 p.m. UTC
Add upstream port and any port definition for SSLBIS.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>

---
See https://github.com/acpica/acpica/pull/874
Merged
---
 include/acpi/actbl1.h |    3 +++
 1 file changed, 3 insertions(+)

Comments

Dan Williams May 22, 2023, 11:24 p.m. UTC | #1
Dave Jiang wrote:
> Add upstream port and any port definition for SSLBIS.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> 
> ---
> See https://github.com/acpica/acpica/pull/874
> Merged
> ---
>  include/acpi/actbl1.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index 15df363b9144..c6189fafe87f 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -419,6 +419,9 @@ struct acpi_cdat_sslbe {
>  	u16 reserved;
>  };
>  
> +#define ACPI_CDAT_SSLBIS_US_PORT	0x0100
> +#define ACPI_CDAT_SSLBIS_ANY_PORT	0xffff
> +
>  /*******************************************************************************
>   *
>   * CEDT - CXL Early Discovery Table

Similar to the last patch, just define these locally outside of
include/acpi/actbl1.h in the patch that needs them and drop the ACPICA
entanglement.
Rafael J. Wysocki May 23, 2023, 10:49 a.m. UTC | #2
On Tue, May 23, 2023 at 1:25 AM Dan Williams <dan.j.williams@intel.com> wrote:
>
> Dave Jiang wrote:
> > Add upstream port and any port definition for SSLBIS.
> >
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> >
> > ---
> > See https://github.com/acpica/acpica/pull/874
> > Merged
> > ---
> >  include/acpi/actbl1.h |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > index 15df363b9144..c6189fafe87f 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -419,6 +419,9 @@ struct acpi_cdat_sslbe {
> >       u16 reserved;
> >  };
> >
> > +#define ACPI_CDAT_SSLBIS_US_PORT     0x0100
> > +#define ACPI_CDAT_SSLBIS_ANY_PORT    0xffff
> > +
> >  /*******************************************************************************
> >   *
> >   * CEDT - CXL Early Discovery Table
>
> Similar to the last patch, just define these locally outside of
> include/acpi/actbl1.h in the patch that needs them and drop the ACPICA
> entanglement.

Yes, if they are not used anywhere else, it's better to do that.

The local definitions can be dropped later when upstream ACPICA acquires them.

That said, it would be prudent to submit an upstream ACPICA pull
request adding them too.
diff mbox series

Patch

diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index 15df363b9144..c6189fafe87f 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -419,6 +419,9 @@  struct acpi_cdat_sslbe {
 	u16 reserved;
 };
 
+#define ACPI_CDAT_SSLBIS_US_PORT	0x0100
+#define ACPI_CDAT_SSLBIS_ANY_PORT	0xffff
+
 /*******************************************************************************
  *
  * CEDT - CXL Early Discovery Table