| Message ID | 5c12dbdb-5774-fc68-5c58-ca596383663e@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] Input: xpad: Delete a Razer DeathAdder mouse VID/PID entry from the gamepad list | expand |
On Wed, Jan 05, 2022 at 01:28:09AM +0100, Ismael Ferreras Morezuelas wrote: > While doing my research to improve the xpad device names I noticed > that the 1532:0037 VID/PID seems to be used by the DeathAdder 2013, > so that Razer Sabertooth instance looked wrong and very suspect to > me. I didn't see any mention in the official drivers, either. > > After doing more research, it turns out that the xpad list > is used by many other projects (like Steam) as-is [1], this > issue was reported [2] and Valve/Sam Lantinga fixed it [3]: > > [1]: https://github.com/libsdl-org/SDL/blob/dcc5eef0e2395854b254ea2873a4899edab347c6/src/joystick/controller_type.h#L251 > [2]: https://steamcommunity.com/app/353380/discussions/0/1743392486228754770/ > [3]: https://hg.libsdl.org/SDL/rev/29809f6f0271 > > (With multiple Internet users reporting similar issues, not linked here) > > After not being able to find the correct VID/PID combination anywhere > on the Internet and not receiving any reply from Razer support I did > some additional detective work, it seems like it presents itself as > "Razer Sabertooth Gaming Controller (XBOX360)", code 1689:FE00. > > Leaving us with this: > * Razer Sabertooth (1689:fe00) > * Razer Sabertooth Elite (24c6:5d04) > * Razer DeathAdder 2013 (1532:0037) [note: not a gamepad] > > So, to sum things up; remove this conflicting/duplicate entry: > > { 0x1532, 0x0037, "Razer Sabertooth", 0, XTYPE_XBOX360 }, > > As the real/correct one is already present there, even if > the Internet as a whole insists on presenting it as the > Razer Sabertooth Elite, which (by all accounts) is not: > > { 0x1689, 0xfe00, "Razer Sabertooth", 0, XTYPE_XBOX360 }, > > Actual change in SDL2 referencing this kernel issue: > https://github.com/libsdl-org/SDL/commit/e5e54169754ca5d3e86339d968b20126d9da0a15 > > For more information of the device, take a look here: > https://github.com/xboxdrv/xboxdrv/pull/59 > > You can see a lsusb dump here: https://github.com/xboxdrv/xboxdrv/files/76581/Qa6dBcrv.txt > > Cc: stable@vger.kernel.org > Cc: Cameron Gutman <aicommander@gmail.com> > Fixes: f554f619b70 ("Input: xpad - sync device IDs with xboxdrv") > Signed-off-by: Ismael Ferreras Morezuelas <swyterzone@gmail.com> > Reviewed-by: Cameron Gutman <aicommander@gmail.com> Applied, thank you.
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 4c914f75a902..6c9e709050a8 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -249,7 +249,6 @@ static const struct xpad_device { { 0x1430, 0x8888, "TX6500+ Dance Pad (first generation)", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX }, { 0x1430, 0xf801, "RedOctane Controller", 0, XTYPE_XBOX360 }, { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 }, - { 0x1532, 0x0037, "Razer Sabertooth", 0, XTYPE_XBOX360 }, { 0x1532, 0x0a00, "Razer Atrox Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE }, { 0x1532, 0x0a03, "Razer Wildcat", 0, XTYPE_XBOXONE }, { 0x15e4, 0x3f00, "Power A Mini Pro Elite", 0, XTYPE_XBOX360 },
While doing my research to improve the xpad device names I noticed that the 1532:0037 VID/PID seems to be used by the DeathAdder 2013, so that Razer Sabertooth instance looked wrong and very suspect to me. I didn't see any mention in the official drivers, either. After doing more research, it turns out that the xpad list is used by many other projects (like Steam) as-is [1], this issue was reported [2] and Valve/Sam Lantinga fixed it [3]: [1]: https://github.com/libsdl-org/SDL/blob/dcc5eef0e2395854b254ea2873a4899edab347c6/src/joystick/controller_type.h#L251 [2]: https://steamcommunity.com/app/353380/discussions/0/1743392486228754770/ [3]: https://hg.libsdl.org/SDL/rev/29809f6f0271 (With multiple Internet users reporting similar issues, not linked here) After not being able to find the correct VID/PID combination anywhere on the Internet and not receiving any reply from Razer support I did some additional detective work, it seems like it presents itself as "Razer Sabertooth Gaming Controller (XBOX360)", code 1689:FE00. Leaving us with this: * Razer Sabertooth (1689:fe00) * Razer Sabertooth Elite (24c6:5d04) * Razer DeathAdder 2013 (1532:0037) [note: not a gamepad] So, to sum things up; remove this conflicting/duplicate entry: { 0x1532, 0x0037, "Razer Sabertooth", 0, XTYPE_XBOX360 }, As the real/correct one is already present there, even if the Internet as a whole insists on presenting it as the Razer Sabertooth Elite, which (by all accounts) is not: { 0x1689, 0xfe00, "Razer Sabertooth", 0, XTYPE_XBOX360 }, Actual change in SDL2 referencing this kernel issue: https://github.com/libsdl-org/SDL/commit/e5e54169754ca5d3e86339d968b20126d9da0a15 For more information of the device, take a look here: https://github.com/xboxdrv/xboxdrv/pull/59 You can see a lsusb dump here: https://github.com/xboxdrv/xboxdrv/files/76581/Qa6dBcrv.txt Cc: stable@vger.kernel.org Cc: Cameron Gutman <aicommander@gmail.com> Fixes: f554f619b70 ("Input: xpad - sync device IDs with xboxdrv") Signed-off-by: Ismael Ferreras Morezuelas <swyterzone@gmail.com> Reviewed-by: Cameron Gutman <aicommander@gmail.com> --- Originally submitted here, now I have some time to try again: https://patchwork.kernel.org/project/linux-input/patch/b9e7cb27-1866-83bb-b453-ae265ab6bde6@gmail.com/ Tweaked the rationale a bit more and added some background information and sorted out the links to make more sense. TL;DR: This entry was imported from xboxdrv and it was wrong. drivers/input/joystick/xpad.c | 1 - 1 file changed, 1 deletion(-)