| Message ID | 20230601061844.492923-1-ilias.apalodimas@linaro.org |
|---|---|
| State | Accepted |
| Commit | aee56c035cfc843a0a98bf3bd1b7fed1a739c37f |
| Headers | show |
| Series | test: fix comment indentation on tpm tests | expand |
On Thu, 1 Jun 2023 at 00:18, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > > One out comments is off by one, adjust it > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > test/dm/tpm.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org> (I'm not sure I understand the commit message though) > diff --git a/test/dm/tpm.c b/test/dm/tpm.c > index 3defb3c3da1f..cde933ab2848 100644 > --- a/test/dm/tpm.c > +++ b/test/dm/tpm.c > @@ -98,10 +98,11 @@ static int test_tpm_autostart(struct unit_test_state *uts, > > if (reinit) > ut_assertok(tpm_init(dev)); > - /* > - * tpm_auto_start will rerun tpm_init() if reinit, but handles the > - * -EBUSY return code internally. > - */ > + > + /* > + * tpm_auto_start will rerun tpm_init() if reinit, but handles the > + * -EBUSY return code internally. > + */ > ut_assertok(tpm_auto_start(dev)); > > return 0; > -- > 2.39.2 >
Thanks Simon On Fri, 2 Jun 2023 at 00:51, Simon Glass <sjg@chromium.org> wrote: > > On Thu, 1 Jun 2023 at 00:18, Ilias Apalodimas > <ilias.apalodimas@linaro.org> wrote: > > > > One out comments is off by one, adjust it > > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > > --- > > test/dm/tpm.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > (I'm not sure I understand the commit message though) > I'll fix it during the merge, it was supposed to say "One of our comments" > > > diff --git a/test/dm/tpm.c b/test/dm/tpm.c > > index 3defb3c3da1f..cde933ab2848 100644 > > --- a/test/dm/tpm.c > > +++ b/test/dm/tpm.c > > @@ -98,10 +98,11 @@ static int test_tpm_autostart(struct unit_test_state *uts, > > > > if (reinit) > > ut_assertok(tpm_init(dev)); > > - /* > > - * tpm_auto_start will rerun tpm_init() if reinit, but handles the > > - * -EBUSY return code internally. > > - */ > > + > > + /* > > + * tpm_auto_start will rerun tpm_init() if reinit, but handles the > > + * -EBUSY return code internally. > > + */ > > ut_assertok(tpm_auto_start(dev)); > > > > return 0; > > -- > > 2.39.2 > >
On Thu, Jun 01, 2023 at 09:18:44AM +0300, Ilias Apalodimas wrote: > One out comments is off by one, adjust it > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/next, thanks!
diff --git a/test/dm/tpm.c b/test/dm/tpm.c index 3defb3c3da1f..cde933ab2848 100644 --- a/test/dm/tpm.c +++ b/test/dm/tpm.c @@ -98,10 +98,11 @@ static int test_tpm_autostart(struct unit_test_state *uts, if (reinit) ut_assertok(tpm_init(dev)); - /* - * tpm_auto_start will rerun tpm_init() if reinit, but handles the - * -EBUSY return code internally. - */ + + /* + * tpm_auto_start will rerun tpm_init() if reinit, but handles the + * -EBUSY return code internally. + */ ut_assertok(tpm_auto_start(dev)); return 0;
One out comments is off by one, adjust it Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> --- test/dm/tpm.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)