| Message ID | 20230603082853.44631-1-giovanni.cabiddu@intel.com |
|---|---|
| State | Accepted |
| Commit | 134e0dc6b73ab7e99464182356a8b3fa4ea3b499 |
| Headers | show |
| Series | crypto: qat - add missing function declaration in adf_dbgfs.h | expand |
On Sat, Jun 03, 2023 at 09:28:53AM +0100, Giovanni Cabiddu wrote: > The function adf_dbgfs_exit() was improperly named causing the build to > fail when CONFIG_DEBUG_FS=n. > > Rename adf_dbgfs_cleanup() as adf_dbgfs_exit(). > > This fixes the following build error: > CC [M] drivers/crypto/intel/qat/qat_c62x/adf_drv.o > drivers/crypto/intel/qat/qat_c62x/adf_drv.c: In function ‘adf_cleanup_accel’: > drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function ‘adf_dbgfs_exit’; did you mean ‘adf_dbgfs_init’? [-Werror=implicit-function-declaration] > 69 | adf_dbgfs_exit(accel_dev); > | ^~~~~~~~~~~~~~ > | adf_dbgfs_init > cc1: all warnings being treated as errors > make[2]: *** [scripts/Makefile.build:252: drivers/crypto/intel/qat/qat_c62x/adf_drv.o] Error 1 > make[1]: *** [scripts/Makefile.build:494: drivers/crypto/intel/qat/qat_c62x] Error 2 > make: *** [Makefile:2026: drivers/crypto/intel/qat] Error 2 > > Fixes: 9260db6640a6 ("crypto: qat - move dbgfs init to separate file") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202306030654.5t4qkyN1-lkp@intel.com/ > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> > --- > drivers/crypto/intel/qat/qat_common/adf_dbgfs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h b/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h index 1d64ad1a0037..e0cb2c2a2ed0 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h +++ b/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h @@ -22,7 +22,7 @@ static inline void adf_dbgfs_rm(struct adf_accel_dev *accel_dev) { } -static inline void adf_dbgfs_cleanup(struct adf_accel_dev *accel_dev) +static inline void adf_dbgfs_exit(struct adf_accel_dev *accel_dev) { } #endif
The function adf_dbgfs_exit() was improperly named causing the build to fail when CONFIG_DEBUG_FS=n. Rename adf_dbgfs_cleanup() as adf_dbgfs_exit(). This fixes the following build error: CC [M] drivers/crypto/intel/qat/qat_c62x/adf_drv.o drivers/crypto/intel/qat/qat_c62x/adf_drv.c: In function ‘adf_cleanup_accel’: drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function ‘adf_dbgfs_exit’; did you mean ‘adf_dbgfs_init’? [-Werror=implicit-function-declaration] 69 | adf_dbgfs_exit(accel_dev); | ^~~~~~~~~~~~~~ | adf_dbgfs_init cc1: all warnings being treated as errors make[2]: *** [scripts/Makefile.build:252: drivers/crypto/intel/qat/qat_c62x/adf_drv.o] Error 1 make[1]: *** [scripts/Makefile.build:494: drivers/crypto/intel/qat/qat_c62x] Error 2 make: *** [Makefile:2026: drivers/crypto/intel/qat] Error 2 Fixes: 9260db6640a6 ("crypto: qat - move dbgfs init to separate file") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202306030654.5t4qkyN1-lkp@intel.com/ Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> --- drivers/crypto/intel/qat/qat_common/adf_dbgfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)