| Message ID | 20230630110643.209761-13-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Commit | 0065b9374633f87e387c10c7461c8c728e17e74c |
| Headers | show |
| Series | media: ipu-bridge: Shared with atomisp, rework VCM instantiation | expand |
Hi Hans On 30/06/2023 13:06, Hans de Goede wrote: > The GalaxyCore GC0310 is used together with the atomisp no various s/no/on > devices, add it to ipu_supported_sensors[]. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > --- > drivers/media/pci/intel/ipu-bridge.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c > index eb7c56e8ef9f..07a34f20af8e 100644 > --- a/drivers/media/pci/intel/ipu-bridge.c > +++ b/drivers/media/pci/intel/ipu-bridge.c > @@ -36,6 +36,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = { > IPU_SENSOR_CONFIG("INT3537", 1, 437000000), > /* Omnivision ov13b10 */ > IPU_SENSOR_CONFIG("OVTIDB10", 1, 560000000), > + /* GalaxyCore GC0310 */ > + IPU_SENSOR_CONFIG("INT0310", 0), > }; > > static const struct ipu_property_names prop_names = {
Hi Hans, On Fri, Jun 30, 2023 at 01:06:40PM +0200, Hans de Goede wrote: > The GalaxyCore GC0310 is used together with the atomisp no various > devices, add it to ipu_supported_sensors[]. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/media/pci/intel/ipu-bridge.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c > index eb7c56e8ef9f..07a34f20af8e 100644 > --- a/drivers/media/pci/intel/ipu-bridge.c > +++ b/drivers/media/pci/intel/ipu-bridge.c > @@ -36,6 +36,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = { > IPU_SENSOR_CONFIG("INT3537", 1, 437000000), > /* Omnivision ov13b10 */ > IPU_SENSOR_CONFIG("OVTIDB10", 1, 560000000), > + /* GalaxyCore GC0310 */ > + IPU_SENSOR_CONFIG("INT0310", 0), Where is this HID from? A DSDT somewhere?? > }; > > static const struct ipu_property_names prop_names = {
Hi Sakari, On 7/4/23 12:49, Sakari Ailus wrote: > Hi Hans, > > On Fri, Jun 30, 2023 at 01:06:40PM +0200, Hans de Goede wrote: >> The GalaxyCore GC0310 is used together with the atomisp no various >> devices, add it to ipu_supported_sensors[]. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/media/pci/intel/ipu-bridge.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c >> index eb7c56e8ef9f..07a34f20af8e 100644 >> --- a/drivers/media/pci/intel/ipu-bridge.c >> +++ b/drivers/media/pci/intel/ipu-bridge.c >> @@ -36,6 +36,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = { >> IPU_SENSOR_CONFIG("INT3537", 1, 437000000), >> /* Omnivision ov13b10 */ >> IPU_SENSOR_CONFIG("OVTIDB10", 1, 560000000), >> + /* GalaxyCore GC0310 */ >> + IPU_SENSOR_CONFIG("INT0310", 0), > > > Where is this HID from? A DSDT somewhere?? This is used in many atomisp DSDTs on many atomisp devices, see below for a quick grep to my no disk "database" of DSDTs. This is also already used by the existing gc0310 driver for atomisp: https://git.linuxtv.org/media_stage.git/tree/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c Note with the latest media_stage.git branch, which has my "[GIT PULL] media: atomisp: Changes for 6.5-1" merged: https://lore.kernel.org/linux-media/4177be8a-7a77-c452-7b98-91d5e5af8e8b@redhat.com/ The gc0310 driver is now a fully standard v4l2 driver no longer using any atomisp-isms / custom API. As such I have a patch pending to move it to drivers/media/i2c : https://lore.kernel.org/linux-media/20230525190100.130010-6-hdegoede@redhat.com/ that patch is waiting for you to ack (or merge) it. Note if you chose to merge this yourself, this should be applied on top of the latest media_stage/master not on top of 6.4-rc1 . Regards, Hans p.s. The promised list of matching DSDT-s. Note not all of these necessary actually use the sensor (but some do) let me know if you want a DSDT of a device which actually uses the GC0310 : [hans@shalem ~]$ grep -l INT0310 hwinfo/*/dsdt.dsl hwinfo/CAT-T20-tablet/dsdt.dsl hwinfo/acer-One-S1003/dsdt.dsl hwinfo/acer-s1003-2/dsdt.dsl hwinfo/chuwi-hi8-Q32G22160505024/dsdt.dsl hwinfo/chuwi-hi8/dsdt.dsl hwinfo/chuwi-vi8-cwi501/dsdt.dsl hwinfo/chuwi-vi8/dsdt.dsl hwinfo/cube-iwork8-air/dsdt.dsl hwinfo/cyberbook-t116/dsdt.dsl hwinfo/endless-HKC/dsdt.dsl hwinfo/estar-beauty-hd-mid7316r/dsdt.dsl hwinfo/gp-electronics-7inch-win10/dsdt.dsl hwinfo/hp-stream7/dsdt.dsl hwinfo/insignia-flex8-NS-P08W7100/dsdt.dsl hwinfo/irbis-nb41/dsdt.dsl hwinfo/irbis-tw36/dsdt.dsl hwinfo/irbis-tw90/dsdt.dsl hwinfo/itworks-tw891/dsdt.dsl hwinfo/jumper-ezbook2/dsdt.dsl hwinfo/lamina-i8270/dsdt.dsl hwinfo/lenovo-ideapad-miix-310/dsdt.dsl hwinfo/lenovo-ideapad-miix-320/dsdt.dsl hwinfo/medion-akoya-e2212t/dsdt.dsl hwinfo/medion-e2215t/dsdt.dsl hwinfo/medion-e2228t/dsdt.dsl hwinfo/mele-pcg03/dsdt.dsl hwinfo/mele-pcg09/dsdt.dsl hwinfo/minix-neo-z83-4-xxx/dsdt.dsl hwinfo/minix-neo-z83-4-hans-de-goede/dsdt.dsl hwinfo/minix-neo-z83-4-unknown/dsdt.dsl hwinfo/mpman-converter9/dsdt.dsl hwinfo/mpman-mpwin895cl/dsdt.dsl hwinfo/nextbook-ares-8a/dsdt.dsl hwinfo/nuvision-TM800W560L/dsdt.dsl hwinfo/odys-vario-pro12/dsdt.dsl hwinfo/onda-v891w-ONDA.D890HBBNR0A/dsdt.dsl hwinfo/onda-v891w-ONDA.W89EBBN08/dsdt.dsl hwinfo/pipe-w2s/dsdt.dsl hwinfo/pipe-w4/dsdt.dsl hwinfo/ployer-momo7w/dsdt.dsl hwinfo/pov-mobii-tab-p1005w-232/dsdt.dsl hwinfo/pov-mobii-tab-p1006w-232-3g/dsdt.dsl hwinfo/rca-cambio-w101-v2/dsdt.dsl hwinfo/schneider-SCL141CTP/dsdt.dsl hwinfo/trekstor-surftab-wintron-7.0/dsdt.dsl hwinfo/trekstor-twin-10.1/dsdt.dsl hwinfo/umax-visionbook-10wi/dsdt.dsl hwinfo/yours-y8w81/dsdt.dsl [hans@shalem ~]$
Hi, On 7/5/23 13:38, Sakari Ailus wrote: > Hi Hans, > > On Tue, Jul 04, 2023 at 12:59:53PM +0200, Hans de Goede wrote: >> Hi Sakari, >> >> On 7/4/23 12:49, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Fri, Jun 30, 2023 at 01:06:40PM +0200, Hans de Goede wrote: >>>> The GalaxyCore GC0310 is used together with the atomisp no various >>>> devices, add it to ipu_supported_sensors[]. >>>> >>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >>>> --- >>>> drivers/media/pci/intel/ipu-bridge.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c >>>> index eb7c56e8ef9f..07a34f20af8e 100644 >>>> --- a/drivers/media/pci/intel/ipu-bridge.c >>>> +++ b/drivers/media/pci/intel/ipu-bridge.c >>>> @@ -36,6 +36,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = { >>>> IPU_SENSOR_CONFIG("INT3537", 1, 437000000), >>>> /* Omnivision ov13b10 */ >>>> IPU_SENSOR_CONFIG("OVTIDB10", 1, 560000000), >>>> + /* GalaxyCore GC0310 */ >>>> + IPU_SENSOR_CONFIG("INT0310", 0), >>> >>> >>> Where is this HID from? A DSDT somewhere?? >> >> This is used in many atomisp DSDTs on many atomisp devices, >> see below for a quick grep to my no disk "database" of DSDTs. >> >> This is also already used by the existing gc0310 driver for >> atomisp: >> >> https://git.linuxtv.org/media_stage.git/tree/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c >> >> Note with the latest media_stage.git branch, which has >> my "[GIT PULL] media: atomisp: Changes for 6.5-1" merged: >> >> https://lore.kernel.org/linux-media/4177be8a-7a77-c452-7b98-91d5e5af8e8b@redhat.com/ >> >> The gc0310 driver is now a fully standard v4l2 driver no longer using any >> atomisp-isms / custom API. As such I have a patch pending to move >> it to drivers/media/i2c : >> >> https://lore.kernel.org/linux-media/20230525190100.130010-6-hdegoede@redhat.com/ >> >> that patch is waiting for you to ack (or merge) it. Note if you chose to merge this >> yourself, this should be applied on top of the latest media_stage/master >> not on top of 6.4-rc1 . > > Ack, thanks for the info. Does this count as your Acked-by for the patch to mv gc0310.c to drivers/media/i2c in my next media-atomisp pull-req ? or ... ? > This seems to be from a different range than the > newer ones with INT34 prefix. Must be an older allocation I guess. Right. Regards, Hans
Hi Hans, On Wed, Jul 05, 2023 at 02:33:30PM +0200, Hans de Goede wrote: > Hi, > > On 7/5/23 14:10, Sakari Ailus wrote: > > Hi Hans, > > > > On Wed, Jul 05, 2023 at 01:50:27PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 7/5/23 13:38, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> On Tue, Jul 04, 2023 at 12:59:53PM +0200, Hans de Goede wrote: > >>>> Hi Sakari, > >>>> > >>>> On 7/4/23 12:49, Sakari Ailus wrote: > >>>>> Hi Hans, > >>>>> > >>>>> On Fri, Jun 30, 2023 at 01:06:40PM +0200, Hans de Goede wrote: > >>>>>> The GalaxyCore GC0310 is used together with the atomisp no various > >>>>>> devices, add it to ipu_supported_sensors[]. > >>>>>> > >>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > >>>>>> --- > >>>>>> drivers/media/pci/intel/ipu-bridge.c | 2 ++ > >>>>>> 1 file changed, 2 insertions(+) > >>>>>> > >>>>>> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c > >>>>>> index eb7c56e8ef9f..07a34f20af8e 100644 > >>>>>> --- a/drivers/media/pci/intel/ipu-bridge.c > >>>>>> +++ b/drivers/media/pci/intel/ipu-bridge.c > >>>>>> @@ -36,6 +36,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = { > >>>>>> IPU_SENSOR_CONFIG("INT3537", 1, 437000000), > >>>>>> /* Omnivision ov13b10 */ > >>>>>> IPU_SENSOR_CONFIG("OVTIDB10", 1, 560000000), > >>>>>> + /* GalaxyCore GC0310 */ > >>>>>> + IPU_SENSOR_CONFIG("INT0310", 0), > >>>>> > >>>>> > >>>>> Where is this HID from? A DSDT somewhere?? > >>>> > >>>> This is used in many atomisp DSDTs on many atomisp devices, > >>>> see below for a quick grep to my no disk "database" of DSDTs. > >>>> > >>>> This is also already used by the existing gc0310 driver for > >>>> atomisp: > >>>> > >>>> https://git.linuxtv.org/media_stage.git/tree/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > >>>> > >>>> Note with the latest media_stage.git branch, which has > >>>> my "[GIT PULL] media: atomisp: Changes for 6.5-1" merged: > >>>> > >>>> https://lore.kernel.org/linux-media/4177be8a-7a77-c452-7b98-91d5e5af8e8b@redhat.com/ > >>>> > >>>> The gc0310 driver is now a fully standard v4l2 driver no longer using any > >>>> atomisp-isms / custom API. As such I have a patch pending to move > >>>> it to drivers/media/i2c : > >>>> > >>>> https://lore.kernel.org/linux-media/20230525190100.130010-6-hdegoede@redhat.com/ > >>>> > >>>> that patch is waiting for you to ack (or merge) it. Note if you chose to merge this > >>>> yourself, this should be applied on top of the latest media_stage/master > >>>> not on top of 6.4-rc1 . > >>> > >>> Ack, thanks for the info. > >> > >> Does this count as your Acked-by for the patch to mv gc0310.c to > >> drivers/media/i2c in my next media-atomisp pull-req ? > >> > >> or ... ? > > > > Can I take the set once others think it's good? I have Wentong's patch that > > goes on top. > > Yes you can and I'm expecting you to take this set, the question about if > your "Ack" as your Acked-by is about: > > https://lore.kernel.org/linux-media/20230525190100.130010-6-hdegoede@redhat.com/ > > which is not part of the set. > > I hope this helps clarify our little mis-communication which we seem to > be heaving here. Sorry, I somehow ignored this part of your original message. I'll review the set soon.
diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c index eb7c56e8ef9f..07a34f20af8e 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -36,6 +36,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = { IPU_SENSOR_CONFIG("INT3537", 1, 437000000), /* Omnivision ov13b10 */ IPU_SENSOR_CONFIG("OVTIDB10", 1, 560000000), + /* GalaxyCore GC0310 */ + IPU_SENSOR_CONFIG("INT0310", 0), }; static const struct ipu_property_names prop_names = {
The GalaxyCore GC0310 is used together with the atomisp no various devices, add it to ipu_supported_sensors[]. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/media/pci/intel/ipu-bridge.c | 2 ++ 1 file changed, 2 insertions(+)