mbox series

[BlueZ,0/5] Couple of improvements to btmon

Message ID 20230729004552.1422547-1-lukasz.rymanowski@codecoup.pl
Headers show
Series Couple of improvements to btmon | expand

Message

Łukasz Rymanowski July 29, 2023, 12:45 a.m. UTC 
Szymon Czapracki (1):
  monitor/ll: Add support for connection parameter command.

Łukasz Rymanowski (4):
  monitor: Fix decoding Command Complete for Remove ISO Data path
  monitor: Update le event mask with bits 20-23
  monitor: Add support to decode le read ISO link quality
  monitor: Add parsing Service Data of UUID 128

 monitor/bt.h     | 51 +++++++++++++++++++++++++++++++++++++++
 monitor/ll.c     | 62 ++++++++++++++++++++++++++++++++++++++++++++++--
 monitor/packet.c | 58 +++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 168 insertions(+), 3 deletions(-)

Comments

Paul Menzel July 29, 2023, 4:42 a.m. UTC | #1 
Dear Łukasz,


Thank you for your patch.

Am 29.07.23 um 02:45 schrieb Łukasz Rymanowski:
> In the advertising report, instead of deciding EIR 0x21 into this:

Do you mean deciphering?

> 
> 	Unknown EIR field 0x21: 3a048f2ba97ea6ae1b49c619e973a4a701480d130d
> 
> We can do bit better
> 
>          Service Data UUID 128: Vendor specific
>            Data: 01480d130d
> ---
>   monitor/packet.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 3031b028f..21e08ccef 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -3997,6 +3997,18 @@ static void print_eir(const uint8_t *eir, uint8_t eir_len, bool le)
>   			print_service_data(data, data_len);
>   			break;
>   
> +		case BT_EIR_SERVICE_DATA128:
> +			if (data_len <= 16)
> +				break;
> +
> +			print_field("Service Data UUID 128: %s ",
> +						bt_uuid128_to_str(&data[0]));
> +
> +			if (data_len > 16)
> +				print_hex_field("  Data", &data[16],
> +								data_len - 16);
> +
> +			break;
>   		case BT_EIR_RANDOM_ADDRESS:
>   			if (data_len < 6)
>   				break;

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul
Łukasz Rymanowski July 29, 2023, 7:11 p.m. UTC | #2 
Hi Paul


On Sat, 29 Jul 2023 at 06:42, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Łukasz,
>
>
> Thank you for your patch.
>
> Am 29.07.23 um 02:45 schrieb Łukasz Rymanowski:
> > In the advertising report, instead of deciding EIR 0x21 into this:
>
> Do you mean deciphering?

Thanks for pointing it out. Just sent v2 for this patch.

>
> >
> >       Unknown EIR field 0x21: 3a048f2ba97ea6ae1b49c619e973a4a701480d130d
> >
> > We can do bit better
> >
> >          Service Data UUID 128: Vendor specific
> >            Data: 01480d130d
> > ---
> >   monitor/packet.c | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/monitor/packet.c b/monitor/packet.c
> > index 3031b028f..21e08ccef 100644
> > --- a/monitor/packet.c
> > +++ b/monitor/packet.c
> > @@ -3997,6 +3997,18 @@ static void print_eir(const uint8_t *eir, uint8_t eir_len, bool le)
> >                       print_service_data(data, data_len);
> >                       break;
> >
> > +             case BT_EIR_SERVICE_DATA128:
> > +                     if (data_len <= 16)
> > +                             break;
> > +
> > +                     print_field("Service Data UUID 128: %s ",
> > +                                             bt_uuid128_to_str(&data[0]));
> > +
> > +                     if (data_len > 16)
> > +                             print_hex_field("  Data", &data[16],
> > +                                                             data_len - 16);
> > +
> > +                     break;
> >               case BT_EIR_RANDOM_ADDRESS:
> >                       if (data_len < 6)
> >                               break;
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
>
> Kind regards,
>
> Paul

Best
Łukasz
patchwork-bot+bluetooth@kernel.org July 31, 2023, 6 p.m. UTC | #3 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sat, 29 Jul 2023 02:45:47 +0200 you wrote:
> Szymon Czapracki (1):
>   monitor/ll: Add support for connection parameter command.
> 
> Łukasz Rymanowski (4):
>   monitor: Fix decoding Command Complete for Remove ISO Data path
>   monitor: Update le event mask with bits 20-23
>   monitor: Add support to decode le read ISO link quality
>   monitor: Add parsing Service Data of UUID 128
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/5] monitor: Fix decoding Command Complete for Remove ISO Data path
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=86a4015659e3
  - [BlueZ,2/5] monitor: Update le event mask with bits 20-23
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7c6e030ac976
  - [BlueZ,3/5] monitor/ll: Add support for connection parameter command.
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=af3549724b0a
  - [BlueZ,4/5] monitor: Add support to decode le read ISO link quality
    (no matching commit)
  - [BlueZ,5/5] monitor: Add parsing Service Data of UUID 128
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8d60b555e8e1

You are awesome, thank you!