| Message ID | 20230819010946.916772-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | e77f06be7216c9e25de8fe74a56df962fcc96cf6 |
| Headers | show |
| Series | dt-bindings: pinctrl: Drop 'phandle' properties | expand |
On Sat, Aug 19, 2023 at 3:09 AM Rob Herring <robh@kernel.org> wrote: > 'phandle' properties are implicitly supported on all nodes, so it > shouldn't be listed in schemas. > > dtschema had a bug where 'phandle' and other implicit properties weren't > being added under 'additionalProperties' schemas. That was fixed in > v2023.07 release. > > Signed-off-by: Rob Herring <robh@kernel.org> Patch applied, thanks for fixing this! Yours, Linus Walleij
On Sat, Aug 19, 2023 at 3:09 AM Rob Herring <robh@kernel.org> wrote: > 'phandle' properties are implicitly supported on all nodes, so it > shouldn't be listed in schemas. > > dtschema had a bug where 'phandle' and other implicit properties weren't > being added under 'additionalProperties' schemas. That was fixed in > v2023.07 release. > > Signed-off-by: Rob Herring <robh@kernel.org> > Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml | 4 ---- > .../devicetree/bindings/pinctrl/renesas,rza1-ports.yaml | 4 ---- > .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ---- > .../devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml | 4 ---- > .../devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml | 4 ---- Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Fri, Aug 18, 2023 at 08:09:44PM -0500, Rob Herring wrote: > 'phandle' properties are implicitly supported on all nodes, so it > shouldn't be listed in schemas. > > dtschema had a bug where 'phandle' and other implicit properties weren't > being added under 'additionalProperties' schemas. That was fixed in > v2023.07 release. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/pinctrl/ingenic,pinctrl.yaml | 4 ---- > .../devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml | 2 -- > .../devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml | 2 -- > .../devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml | 2 -- > .../devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml | 2 -- > .../devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml | 2 -- > .../devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml | 2 -- > Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml | 4 ---- > .../devicetree/bindings/pinctrl/renesas,rza1-ports.yaml | 4 ---- > .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ---- > .../devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml | 4 ---- > .../devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml | 4 ---- > .../bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 -- > 13 files changed, 38 deletions(-) I see it's already applied, but for the record: Acked-by: Thierry Reding <treding@nvidia.com>
diff --git a/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml index 35723966b70a..890961826c6f 100644 --- a/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml @@ -135,7 +135,6 @@ additionalProperties: - $ref: pinmux-node.yaml# properties: - phandle: true function: true groups: true pins: true @@ -147,8 +146,6 @@ additionalProperties: additionalProperties: false - type: object - properties: - phandle: true additionalProperties: type: object allOf: @@ -156,7 +153,6 @@ additionalProperties: - $ref: pinmux-node.yaml# properties: - phandle: true function: true groups: true pins: true diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml index 065dedb3573a..1690c0ef553a 100644 --- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml @@ -22,8 +22,6 @@ properties: patternProperties: "^pinmux(-[a-z0-9-_]+)?$": type: object - properties: - phandle: true # pin groups additionalProperties: diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml index f924652bef0d..9b7368bd3862 100644 --- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml @@ -32,8 +32,6 @@ properties: patternProperties: "^pinmux(-[a-z0-9-_]+)?$": type: object - properties: - phandle: true # pin groups additionalProperties: diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml index 60a4bdf01bf2..87b6f4f42f25 100644 --- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml @@ -23,8 +23,6 @@ properties: patternProperties: "^pinmux(-[a-z0-9-_]+)?$": type: object - properties: - phandle: true # pin groups additionalProperties: diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml index 432ea40209a8..63cd743a30e0 100644 --- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml @@ -24,8 +24,6 @@ properties: patternProperties: "^pinmux(-[a-z0-9-_]+)?$": type: object - properties: - phandle: true # pin groups additionalProperties: diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml index 28ae2e6d0cbc..e99387a6da5e 100644 --- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml @@ -22,8 +22,6 @@ properties: patternProperties: "^pinmux(-[a-z0-9-_]+)?$": type: object - properties: - phandle: true # pin groups additionalProperties: diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml index c0eda7848767..36c8f3301a8f 100644 --- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml @@ -22,8 +22,6 @@ properties: patternProperties: "^pinmux(-[a-z0-9-_]+)?$": type: object - properties: - phandle: true # pin groups additionalProperties: diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml index 0fc3c0f52c19..181cd1676c0a 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml @@ -107,7 +107,6 @@ additionalProperties: Client device subnodes use below standard properties. properties: - phandle: true function: true groups: true pins: true @@ -127,9 +126,6 @@ additionalProperties: additionalProperties: false - type: object - properties: - phandle: true - additionalProperties: $ref: "#/additionalProperties/anyOf/0" diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml index 83800fcf0ce4..2bd7d47d0fdb 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml @@ -108,7 +108,6 @@ additionalProperties: Integers values in "pinmux" argument list are assembled as: ((PORT * 16 + PIN) | MUX_FUNC << 16) - phandle: true input-enable: true output-enable: true @@ -118,9 +117,6 @@ additionalProperties: additionalProperties: false - type: object - properties: - phandle: true - additionalProperties: $ref: "#/additionalProperties/anyOf/0" diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml index 9ce1a07fc015..145c5442f268 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml @@ -83,7 +83,6 @@ additionalProperties: Client device subnodes use below standard properties. properties: - phandle: true pinmux: description: Values are constructed from GPIO port number, pin number, and @@ -106,9 +105,6 @@ additionalProperties: line-name: true - type: object - properties: - phandle: true - additionalProperties: $ref: "#/additionalProperties/anyOf/0" diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml index 19d4d2facfb4..816688580e33 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml @@ -74,7 +74,6 @@ additionalProperties: offset by 10. Additional identifiers are provided to specify the MDIO source peripheral. - phandle: true bias-disable: true bias-pull-up: description: Pull up the pin with 50 kOhm @@ -91,9 +90,6 @@ additionalProperties: $ref: "#/additionalProperties/anyOf/0" - type: object - properties: - phandle: true - additionalProperties: $ref: "#/additionalProperties/anyOf/0" diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml index c87161f2954f..cb81a17bd0b1 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml @@ -63,7 +63,6 @@ additionalProperties: Client device subnodes use below standard properties. properties: - phandle: true pinmux: description: Values are constructed from GPIO port number, pin number, and @@ -87,9 +86,6 @@ additionalProperties: line-name: true - type: object - properties: - phandle: true - additionalProperties: $ref: "#/additionalProperties/anyOf/0" diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml index a6f34df82e90..880da721a927 100644 --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml @@ -32,7 +32,6 @@ additionalProperties: - $ref: pinmux-node.yaml# properties: - phandle: true function: true groups: true pins: true @@ -49,7 +48,6 @@ additionalProperties: - $ref: pinmux-node.yaml# properties: - phandle: true function: true groups: true pins: true
'phandle' properties are implicitly supported on all nodes, so it shouldn't be listed in schemas. dtschema had a bug where 'phandle' and other implicit properties weren't being added under 'additionalProperties' schemas. That was fixed in v2023.07 release. Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/pinctrl/ingenic,pinctrl.yaml | 4 ---- .../devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml | 2 -- .../devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml | 2 -- .../devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml | 2 -- .../devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml | 2 -- .../devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml | 2 -- .../devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml | 2 -- Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml | 4 ---- .../devicetree/bindings/pinctrl/renesas,rza1-ports.yaml | 4 ---- .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ---- .../devicetree/bindings/pinctrl/renesas,rzn1-pinctrl.yaml | 4 ---- .../devicetree/bindings/pinctrl/renesas,rzv2m-pinctrl.yaml | 4 ---- .../bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 -- 13 files changed, 38 deletions(-)