mbox series

[V6,0/5] Add camera clock controller support for SM8550

Message ID 20230707035744.22245-1-quic_jkona@quicinc.com
Headers show
Series Add camera clock controller support for SM8550 | expand

Message

Jagadeesh Kona July 7, 2023, 3:57 a.m. UTC
Add bindings, driver and devicetree node for camera clock controller on
SM8550.

Changes in v6:
 - Updated parent map and frequency table of cam_cc_xo_clk_src to use
   active only source P_BI_TCXO_AO instead of P_BI_TCXO

Changes in v5:
 - Added clk_lucid_ole_pll_configure() to configure lucid ole PLL's
 - Used module_platform_driver() instead of subsys_initcall()
 - Fixed overloading .l config with CAL_L and RINGOSC_CAL_L fields

Changes in v4:
 - Dropped the extra patches added in v2, since the review comments on
   v3 recommended an alternate solution

Changes in v3:
 - Squashed 2 extra patches added in v2 into single patch as per review
   comments

Changes in v2:
 - Took care of review comments from v1 
     + Removed new YAML file and reused SM8450 CAMCC YAML file for SM8550
     + Sorted the PLL names in proper order
     + Updated all PLL configurations to lower case hex
     + Reused evo ops instead of adding new ops for ole pll
     + Moved few clocks to separate patch to fix patch too long error
     + Padded non-zero address part to 8 hex digits in DT change
 - Added 2 extra patches updating .l config value across chipsets to
   include CAL_L and RINGOSC_CAL_L fields and removed setting CAL_L
   field explicitly in clk_lucid_evo_pll_configure().

v1:
  - Initial CAMCC changes for SM8550

Previous series:
v5 - https://patchwork.kernel.org/project/linux-clk/list/?series=759863
v4 - https://patchwork.kernel.org/project/linux-clk/list/?series=755683 
v3 - https://patchwork.kernel.org/project/linux-clk/list/?series=753150
v2 - https://patchwork.kernel.org/project/linux-clk/list/?series=751058
v1 - https://patchwork.kernel.org/project/linux-clk/list/?series=749294

Jagadeesh Kona (5):
  dt-bindings: clock: qcom: Add SM8550 camera clock controller
  clk: qcom: clk-alpha-pll: Add support for lucid ole pll configure
  clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550
  clk: qcom: camcc-sm8550: Add support for qdss, sleep and xo clocks
  arm64: dts: qcom: sm8550: Add camera clock controller

 .../bindings/clock/qcom,sm8450-camcc.yaml     |    8 +-
 arch/arm64/boot/dts/qcom/sm8550.dtsi          |   15 +
 drivers/clk/qcom/Kconfig                      |    7 +
 drivers/clk/qcom/Makefile                     |    1 +
 drivers/clk/qcom/camcc-sm8550.c               | 3564 +++++++++++++++++
 drivers/clk/qcom/clk-alpha-pll.c              |   29 +
 drivers/clk/qcom/clk-alpha-pll.h              |    2 +
 include/dt-bindings/clock/qcom,sm8550-camcc.h |  187 +
 8 files changed, 3811 insertions(+), 2 deletions(-)
 create mode 100644 drivers/clk/qcom/camcc-sm8550.c
 create mode 100644 include/dt-bindings/clock/qcom,sm8550-camcc.h

Comments

Jagadeesh Kona Aug. 31, 2023, 8:20 a.m. UTC | #1
On 7/7/2023 9:27 AM, Jagadeesh Kona wrote:
> Add bindings, driver and devicetree node for camera clock controller on
> SM8550.
> 
> Changes in v6:
>   - Updated parent map and frequency table of cam_cc_xo_clk_src to use
>     active only source P_BI_TCXO_AO instead of P_BI_TCXO
> 
> Changes in v5:
>   - Added clk_lucid_ole_pll_configure() to configure lucid ole PLL's
>   - Used module_platform_driver() instead of subsys_initcall()
>   - Fixed overloading .l config with CAL_L and RINGOSC_CAL_L fields
> 
> Changes in v4:
>   - Dropped the extra patches added in v2, since the review comments on
>     v3 recommended an alternate solution
> 
> Changes in v3:
>   - Squashed 2 extra patches added in v2 into single patch as per review
>     comments
> 
> Changes in v2:
>   - Took care of review comments from v1
>       + Removed new YAML file and reused SM8450 CAMCC YAML file for SM8550
>       + Sorted the PLL names in proper order
>       + Updated all PLL configurations to lower case hex
>       + Reused evo ops instead of adding new ops for ole pll
>       + Moved few clocks to separate patch to fix patch too long error
>       + Padded non-zero address part to 8 hex digits in DT change
>   - Added 2 extra patches updating .l config value across chipsets to
>     include CAL_L and RINGOSC_CAL_L fields and removed setting CAL_L
>     field explicitly in clk_lucid_evo_pll_configure().
> 
> v1:
>    - Initial CAMCC changes for SM8550
> 
> Previous series:
> v5 - https://patchwork.kernel.org/project/linux-clk/list/?series=759863
> v4 - https://patchwork.kernel.org/project/linux-clk/list/?series=755683
> v3 - https://patchwork.kernel.org/project/linux-clk/list/?series=753150
> v2 - https://patchwork.kernel.org/project/linux-clk/list/?series=751058
> v1 - https://patchwork.kernel.org/project/linux-clk/list/?series=749294
> 
> Jagadeesh Kona (5):
>    dt-bindings: clock: qcom: Add SM8550 camera clock controller
>    clk: qcom: clk-alpha-pll: Add support for lucid ole pll configure
>    clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550
>    clk: qcom: camcc-sm8550: Add support for qdss, sleep and xo clocks
>    arm64: dts: qcom: sm8550: Add camera clock controller
> 
>   .../bindings/clock/qcom,sm8450-camcc.yaml     |    8 +-
>   arch/arm64/boot/dts/qcom/sm8550.dtsi          |   15 +
>   drivers/clk/qcom/Kconfig                      |    7 +
>   drivers/clk/qcom/Makefile                     |    1 +
>   drivers/clk/qcom/camcc-sm8550.c               | 3564 +++++++++++++++++
>   drivers/clk/qcom/clk-alpha-pll.c              |   29 +
>   drivers/clk/qcom/clk-alpha-pll.h              |    2 +
>   include/dt-bindings/clock/qcom,sm8550-camcc.h |  187 +
>   8 files changed, 3811 insertions(+), 2 deletions(-)
>   create mode 100644 drivers/clk/qcom/camcc-sm8550.c
>   create mode 100644 include/dt-bindings/clock/qcom,sm8550-camcc.h
> 

Hi Bjorn,

All patches in this series are in reviewed state, could you please help 
to pick this series in the next release? Thanks!

Thanks,
Jagadeesh
Krzysztof Kozlowski Aug. 31, 2023, 8:24 a.m. UTC | #2
On 31/08/2023 10:20, Jagadeesh Kona wrote:
> 
> 
> On 7/7/2023 9:27 AM, Jagadeesh Kona wrote:
>> Add bindings, driver and devicetree node for camera clock controller on
>> SM8550.
>>
>> Changes in v6:
>>   - Updated parent map and frequency table of cam_cc_xo_clk_src to use
>>     active only source P_BI_TCXO_AO instead of P_BI_TCXO
>>
>> Changes in v5:
>>   - Added clk_lucid_ole_pll_configure() to configure lucid ole PLL's
>>   - Used module_platform_driver() instead of subsys_initcall()
>>   - Fixed overloading .l config with CAL_L and RINGOSC_CAL_L fields
>>
>> Changes in v4:
>>   - Dropped the extra patches added in v2, since the review comments on
>>     v3 recommended an alternate solution
>>
>> Changes in v3:
>>   - Squashed 2 extra patches added in v2 into single patch as per review
>>     comments
>>
>> Changes in v2:
>>   - Took care of review comments from v1
>>       + Removed new YAML file and reused SM8450 CAMCC YAML file for SM8550
>>       + Sorted the PLL names in proper order
>>       + Updated all PLL configurations to lower case hex
>>       + Reused evo ops instead of adding new ops for ole pll
>>       + Moved few clocks to separate patch to fix patch too long error
>>       + Padded non-zero address part to 8 hex digits in DT change
>>   - Added 2 extra patches updating .l config value across chipsets to
>>     include CAL_L and RINGOSC_CAL_L fields and removed setting CAL_L
>>     field explicitly in clk_lucid_evo_pll_configure().
>>
>> v1:
>>    - Initial CAMCC changes for SM8550
>>
>> Previous series:
>> v5 - https://patchwork.kernel.org/project/linux-clk/list/?series=759863
>> v4 - https://patchwork.kernel.org/project/linux-clk/list/?series=755683
>> v3 - https://patchwork.kernel.org/project/linux-clk/list/?series=753150
>> v2 - https://patchwork.kernel.org/project/linux-clk/list/?series=751058
>> v1 - https://patchwork.kernel.org/project/linux-clk/list/?series=749294
>>
>> Jagadeesh Kona (5):
>>    dt-bindings: clock: qcom: Add SM8550 camera clock controller
>>    clk: qcom: clk-alpha-pll: Add support for lucid ole pll configure
>>    clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550
>>    clk: qcom: camcc-sm8550: Add support for qdss, sleep and xo clocks
>>    arm64: dts: qcom: sm8550: Add camera clock controller
>>
>>   .../bindings/clock/qcom,sm8450-camcc.yaml     |    8 +-
>>   arch/arm64/boot/dts/qcom/sm8550.dtsi          |   15 +
>>   drivers/clk/qcom/Kconfig                      |    7 +
>>   drivers/clk/qcom/Makefile                     |    1 +
>>   drivers/clk/qcom/camcc-sm8550.c               | 3564 +++++++++++++++++
>>   drivers/clk/qcom/clk-alpha-pll.c              |   29 +
>>   drivers/clk/qcom/clk-alpha-pll.h              |    2 +
>>   include/dt-bindings/clock/qcom,sm8550-camcc.h |  187 +
>>   8 files changed, 3811 insertions(+), 2 deletions(-)
>>   create mode 100644 drivers/clk/qcom/camcc-sm8550.c
>>   create mode 100644 include/dt-bindings/clock/qcom,sm8550-camcc.h
>>
> 
> Hi Bjorn,
> 
> All patches in this series are in reviewed state, could you please help 
> to pick this series in the next release? Thanks!

We are in merge window, so please refrain from simple pings for
patchsets which are not fixes.

Best regards,
Krzysztof
Bjorn Andersson Sept. 19, 2023, 11:07 p.m. UTC | #3
On Fri, 07 Jul 2023 09:27:39 +0530, Jagadeesh Kona wrote:
> Add bindings, driver and devicetree node for camera clock controller on
> SM8550.
> 
> Changes in v6:
>  - Updated parent map and frequency table of cam_cc_xo_clk_src to use
>    active only source P_BI_TCXO_AO instead of P_BI_TCXO
> 
> [...]

Applied, thanks!

[5/5] arm64: dts: qcom: sm8550: Add camera clock controller
      commit: e271b59e39a6fbdc57784fdda7e68076f8e58ef7

Best regards,