| Message ID | 20230825112633.236607-8-ulf.hansson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm_scmi/cpufreq: Add generic performance scaling support | expand |
On Fri, Aug 25, 2023 at 01:26:27PM +0200, Ulf Hansson wrote: > We have stubs for devm_of_clk_add_hw_provider(), so there should be no need > to protect this with the '#ifdef CONFIG_COMMON_CLK'. Let's drop it to clean > up the code a bit. > No exactly. The stub is under !CONFIG_OF but we need it for !CONFIG_COMMON_CLK. The original build issue reported for which I add this was CONFIG_OF=y && CONFIG_COMMON_CLK=n. It looks like it is still valid combo though I don't have a handy randconfig to present to you. I prefer to drop this for now if that is OK with you.
On Thu, 21 Sept 2023 at 13:14, Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Fri, Aug 25, 2023 at 01:26:27PM +0200, Ulf Hansson wrote: > > We have stubs for devm_of_clk_add_hw_provider(), so there should be no need > > to protect this with the '#ifdef CONFIG_COMMON_CLK'. Let's drop it to clean > > up the code a bit. > > > > No exactly. The stub is under !CONFIG_OF but we need it for !CONFIG_COMMON_CLK. > The original build issue reported for which I add this was CONFIG_OF=y && > CONFIG_COMMON_CLK=n. > > It looks like it is still valid combo though I don't have a handy randconfig > to present to you. I prefer to drop this for now if that is OK with you. Sure, it's perfectly fine to drop it. It's just a thing I stumbled over that isn't really needed in the $subject series! Kind regards Uffe
On Thu, Sep 21, 2023 at 03:02:16PM +0200, Ulf Hansson wrote: > On Thu, 21 Sept 2023 at 13:14, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > On Fri, Aug 25, 2023 at 01:26:27PM +0200, Ulf Hansson wrote: > > > We have stubs for devm_of_clk_add_hw_provider(), so there should be no need > > > to protect this with the '#ifdef CONFIG_COMMON_CLK'. Let's drop it to clean > > > up the code a bit. > > > > > > > No exactly. The stub is under !CONFIG_OF but we need it for !CONFIG_COMMON_CLK. > > The original build issue reported for which I add this was CONFIG_OF=y && > > CONFIG_COMMON_CLK=n. > > > > It looks like it is still valid combo though I don't have a handy randconfig > > to present to you. I prefer to drop this for now if that is OK with you. > > Sure, it's perfectly fine to drop it. It's just a thing I stumbled > over that isn't really needed in the $subject series! > Thanks !
diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 78f53e388094..48bd393a1506 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -320,11 +320,9 @@ static int scmi_cpufreq_probe(struct scmi_device *sdev) if (IS_ERR(perf_ops)) return PTR_ERR(perf_ops); -#ifdef CONFIG_COMMON_CLK /* dummy clock provider as needed by OPP if clocks property is used */ if (of_property_present(dev->of_node, "#clock-cells")) devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, NULL); -#endif ret = cpufreq_register_driver(&scmi_cpufreq_driver); if (ret) {
We have stubs for devm_of_clk_add_hw_provider(), so there should be no need to protect this with the '#ifdef CONFIG_COMMON_CLK'. Let's drop it to clean up the code a bit. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- Changes in v3: - None. --- drivers/cpufreq/scmi-cpufreq.c | 2 -- 1 file changed, 2 deletions(-)