| Message ID | 20230925144854.1872513-5-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | September maintainer omnibus (tests, gdbstub, plugins) | expand |
Alex Bennée <alex.bennee@linaro.org> writes: > This might be premature but while streamling the avocado tests I > realised the only tests we have are "check-tcg" ones. The aging > fedora-criss-cross image works well enough for developers but can't be > used in CI as we need supported build platforms to build QEMU. > > Does this mean the writing is on the wall for this architecture? > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Rabin Vincent <rabinv@axis.com> > Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com> doh, I meant: Edgar E. Iglesias <edgar.iglesias@gmail.com> > --- > docs/about/deprecated.rst | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index dc4da95329..7cfe313aa6 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the command line using the > used instead, to refer to a ``--object secret...`` instance that provides > a password via a file, or encrypted. > > +TCG CPUs > +-------- > + > +CRIS CPU architecture (since 8.1) > +''''''''''''''''''''''''''''''''' > + > +The CRIS architecture was pulled from Linux in 4.17 and the compiler > +is no longer packaged in any distro making it harder to run the > +``check-tcg`` tests. Unless we can improve the testing situation there > +is a chance the code will bitrot without anyone noticing. > + > Backwards compatibility > -----------------------
On Mon, Sep 25, 2023 at 7:00 PM Alex Bennée <alex.bennee@linaro.org> wrote: > > Daniel P. Berrangé <berrange@redhat.com> writes: > > > On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote: > >> This might be premature but while streamling the avocado tests I > >> realised the only tests we have are "check-tcg" ones. The aging > >> fedora-criss-cross image works well enough for developers but can't be > >> used in CI as we need supported build platforms to build QEMU. > >> > >> Does this mean the writing is on the wall for this architecture? > >> > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > >> Cc: Rabin Vincent <rabinv@axis.com> > >> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > >> --- > >> docs/about/deprecated.rst | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > >> index dc4da95329..7cfe313aa6 100644 > >> --- a/docs/about/deprecated.rst > >> +++ b/docs/about/deprecated.rst > >> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the > command line using the > >> used instead, to refer to a ``--object secret...`` instance that > provides > >> a password via a file, or encrypted. > >> > >> +TCG CPUs > >> +-------- > >> + > >> +CRIS CPU architecture (since 8.1) > >> +''''''''''''''''''''''''''''''''' > >> + > >> +The CRIS architecture was pulled from Linux in 4.17 and the compiler > >> +is no longer packaged in any distro making it harder to run the > >> +``check-tcg`` tests. Unless we can improve the testing situation there > >> +is a chance the code will bitrot without anyone noticing. > > > > Deprecated is generally a warning that we intend to delete the > > feature. If we're just going to relegate it to untested > > status (what I'd call "tier 3" quality), then we should document > > that elsewhere. I don't mind which way we go. > > We do have reasonably good coverage with tests/tcg/cris but of course > without a compiler we can't build them. > > Both nios2 and microblaze have build-toolchain scripts which can be used > to re-create containers. However my preference is having pre-built > toolchains hosted by others like we do for loongarch, hexagon, xtensa > and tricore. Then the docker image can simply curl them into an image. > > Yeah, I guess it's time to deprecate it... Cheers, Edgar > -- > Alex Bennée > Virtualisation Tech Lead @ Linaro > >
On 25/9/23 19:17, Edgar E. Iglesias wrote: > > On Mon, Sep 25, 2023 at 7:00 PM Alex Bennée <alex.bennee@linaro.org > <mailto:alex.bennee@linaro.org>> wrote: > > > Daniel P. Berrangé <berrange@redhat.com > <mailto:berrange@redhat.com>> writes: > > > On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote: > >> This might be premature but while streamling the avocado tests I > >> realised the only tests we have are "check-tcg" ones. The aging > >> fedora-criss-cross image works well enough for developers but > can't be > >> used in CI as we need supported build platforms to build QEMU. > >> > >> Does this mean the writing is on the wall for this architecture? > >> > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org > <mailto:alex.bennee@linaro.org>> > >> Cc: Rabin Vincent <rabinv@axis.com <mailto:rabinv@axis.com>> > >> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com > <mailto:edgar.iglesias@xilinx.com>> > >> --- > >> docs/about/deprecated.rst | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > >> index dc4da95329..7cfe313aa6 100644 > >> --- a/docs/about/deprecated.rst > >> +++ b/docs/about/deprecated.rst > >> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text > on the command line using the > >> used instead, to refer to a ``--object secret...`` instance > that provides > >> a password via a file, or encrypted. > >> > >> +TCG CPUs > >> +-------- > >> + > >> +CRIS CPU architecture (since 8.1) > >> +''''''''''''''''''''''''''''''''' > >> + > >> +The CRIS architecture was pulled from Linux in 4.17 and the > compiler > >> +is no longer packaged in any distro making it harder to run the > >> +``check-tcg`` tests. Unless we can improve the testing > situation there > >> +is a chance the code will bitrot without anyone noticing. > > > > Deprecated is generally a warning that we intend to delete the > > feature. If we're just going to relegate it to untested > > status (what I'd call "tier 3" quality), then we should document > > that elsewhere. I don't mind which way we go. > > We do have reasonably good coverage with tests/tcg/cris but of course > without a compiler we can't build them. > > Both nios2 and microblaze have build-toolchain scripts which can be used > to re-create containers. However my preference is having pre-built > toolchains hosted by others like we do for loongarch, hexagon, xtensa > and tricore. Then the docker image can simply curl them into an image. > > > Yeah, I guess it's time to deprecate it... Is that an informal Acked-by? (: > > Cheers, > Edgar
On Wed, Jan 24, 2024 at 12:06 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > On 25/9/23 19:17, Edgar E. Iglesias wrote: > > > > On Mon, Sep 25, 2023 at 7:00 PM Alex Bennée <alex.bennee@linaro.org > > <mailto:alex.bennee@linaro.org>> wrote: > > > > > > Daniel P. Berrangé <berrange@redhat.com > > <mailto:berrange@redhat.com>> writes: > > > > > On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote: > > >> This might be premature but while streamling the avocado tests I > > >> realised the only tests we have are "check-tcg" ones. The aging > > >> fedora-criss-cross image works well enough for developers but > > can't be > > >> used in CI as we need supported build platforms to build QEMU. > > >> > > >> Does this mean the writing is on the wall for this architecture? > > >> > > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org > > <mailto:alex.bennee@linaro.org>> > > >> Cc: Rabin Vincent <rabinv@axis.com <mailto:rabinv@axis.com>> > > >> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com > > <mailto:edgar.iglesias@xilinx.com>> > > >> --- > > >> docs/about/deprecated.rst | 11 +++++++++++ > > >> 1 file changed, 11 insertions(+) > > >> > > >> diff --git a/docs/about/deprecated.rst > b/docs/about/deprecated.rst > > >> index dc4da95329..7cfe313aa6 100644 > > >> --- a/docs/about/deprecated.rst > > >> +++ b/docs/about/deprecated.rst > > >> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text > > on the command line using the > > >> used instead, to refer to a ``--object secret...`` instance > > that provides > > >> a password via a file, or encrypted. > > >> > > >> +TCG CPUs > > >> +-------- > > >> + > > >> +CRIS CPU architecture (since 8.1) > > >> +''''''''''''''''''''''''''''''''' > > >> + > > >> +The CRIS architecture was pulled from Linux in 4.17 and the > > compiler > > >> +is no longer packaged in any distro making it harder to run the > > >> +``check-tcg`` tests. Unless we can improve the testing > > situation there > > >> +is a chance the code will bitrot without anyone noticing. > > > > > > Deprecated is generally a warning that we intend to delete the > > > feature. If we're just going to relegate it to untested > > > status (what I'd call "tier 3" quality), then we should document > > > that elsewhere. I don't mind which way we go. > > > > We do have reasonably good coverage with tests/tcg/cris but of course > > without a compiler we can't build them. > > > > Both nios2 and microblaze have build-toolchain scripts which can be > used > > to re-create containers. However my preference is having pre-built > > toolchains hosted by others like we do for loongarch, hexagon, xtensa > > and tricore. Then the docker image can simply curl them into an > image. > > > > > > Yeah, I guess it's time to deprecate it... > > Is that an informal Acked-by? (: > > OK with me! Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index dc4da95329..7cfe313aa6 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the command line using the used instead, to refer to a ``--object secret...`` instance that provides a password via a file, or encrypted. +TCG CPUs +-------- + +CRIS CPU architecture (since 8.1) +''''''''''''''''''''''''''''''''' + +The CRIS architecture was pulled from Linux in 4.17 and the compiler +is no longer packaged in any distro making it harder to run the +``check-tcg`` tests. Unless we can improve the testing situation there +is a chance the code will bitrot without anyone noticing. + Backwards compatibility -----------------------
This might be premature but while streamling the avocado tests I realised the only tests we have are "check-tcg" ones. The aging fedora-criss-cross image works well enough for developers but can't be used in CI as we need supported build platforms to build QEMU. Does this mean the writing is on the wall for this architecture? Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Cc: Rabin Vincent <rabinv@axis.com> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com> --- docs/about/deprecated.rst | 11 +++++++++++ 1 file changed, 11 insertions(+)