mbox series

[V2,0/2] Add watchdog support for Amlogic C3 SoCs

Message ID 20230926055512.2355390-1-huqiang.qin@amlogic.com
Headers show
Series Add watchdog support for Amlogic C3 SoCs | expand

Message

Huqiang Qin Sept. 26, 2023, 5:55 a.m. UTC 
Amlogic C3 has the same watchdog controller as Amlogic T7.

[PATCH 1/2]: 
  V1 -> V2: Added compatibles.

[PATCH 2/2]:
  V1 -> V2: Increase compatibles of C3 watchdog.

Huqiang Qin (2):
  dt-bindings: watchdog: Add support for Amlogic C3 SoCs
  arm64: dts: Add watchdog node for Amlogic C3 SoCs

 .../bindings/watchdog/amlogic,meson-gxbb-wdt.yaml           | 1 +
 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi                 | 6 ++++++
 2 files changed, 7 insertions(+)


base-commit: 8fff9184d1b5810dca5dd1a02726d4f844af88fc

Comments

Huqiang Qin Sept. 27, 2023, 5:59 a.m. UTC | #1 
On 2023/9/26 16:03, Conor Dooley wrote:
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> @@ -81,6 +81,12 @@ apb4: bus@fe000000 {
>>  			#size-cells = <2>;
>>  			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>>  
>> +			watchdog@2100 {
>> +				compatible = "amlogic,c3-wdt", "amlogic,t7-wdt";
> Does this pass dtbs_check?
> The binding patch doesn't seem to permit this combo..
> 

Ah... I ran dtbs_check again, and there is indeed
`watchdog@2100: compatible: ['amlogic,c3-wdt', 'amlogic,t7-wdt'] is too long`
in the output.

I'll correct it in the next version, thanks for pointing it out.


Best regards,
Huqiang Qin