mbox series

[v8,00/30] Add support for QMC HDLC, framer infrastructure and PEF2256 framer

Message ID 20231011061437.64213-1-herve.codina@bootlin.com
Headers show
Series Add support for QMC HDLC, framer infrastructure and PEF2256 framer | expand

Message

Herve Codina Oct. 11, 2023, 6:14 a.m. UTC 
Hi,

I have a system where I need to handle an HDLC interface and some audio
data.

The HDLC data are transferred using a TDM bus on which a PEF2256
(E1/T1 framer) is present. The PEF2256 transfers data from/to the TDM
bus to/from the E1 line. This PEF2256 is connected to a PowerQUICC SoC
for the control path and the TDM is connected to the SoC (QMC component)
for the data path.

Comments

Jakub Kicinski Oct. 13, 2023, 11:43 p.m. UTC | #1 
On Wed, 11 Oct 2023 08:14:27 +0200 Herve Codina wrote:
> QMC channels support runtime timeslots changes but nothing is done at
> the QMC HDLC driver to handle these changes.
> 
> Use existing IFACE ioctl in order to configure the timeslots to use.
> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

Acked-by: Jakub Kicinski <kuba@kernel.org>
Jakub Kicinski Oct. 13, 2023, 11:43 p.m. UTC | #2 
On Wed, 11 Oct 2023 08:14:28 +0200 Herve Codina wrote:
> A framer is a component in charge of an E1/T1 line interface.
> Connected usually to a TDM bus, it converts TDM frames to/from E1/T1
> frames. It also provides information related to the E1/T1 line.
> 
> The framer framework provides a set of APIs for the framer drivers
> (framer provider) to create/destroy a framer and APIs for the framer
> users (framer consumer) to obtain a reference to the framer, and
> use the framer.
> 
> This basic implementation provides a framer abstraction for:
>  - power on/off the framer
>  - get the framer status (line state)
>  - be notified on framer status changes
>  - get/set the framer configuration

Acked-by: Jakub Kicinski <kuba@kernel.org>
Jakub Kicinski Oct. 13, 2023, 11:46 p.m. UTC | #3 
On Wed, 11 Oct 2023 08:14:04 +0200 Herve Codina wrote:
> Compare to the previous iteration
>   https://lore.kernel.org/linux-kernel/20230928070652.330429-1-herve.codina@bootlin.com/
> This v8 series:
>  - Fixes a race condition
>  - Uses menuconfig instead of menu and hides CONFIG_GENERIC_FRAMER
>  - Performs minor changes

Which way will those patches go? Via some FSL SoC tree?
Rob Herring (Arm) Oct. 30, 2023, 9:31 p.m. UTC | #4 
On Wed, Oct 25, 2023 at 12:32:15PM -0700, Jakub Kicinski wrote:
> On Wed, 25 Oct 2023 17:00:51 +0200 Herve Codina wrote:
> > > Which way will those patches go? Via some FSL SoC tree?  
> > 
> > This series seems mature now.
> > What is the plan next in order to have it applied ?
> > 
> > Don't hesitate to tell me if you prefer split series.
> 
> FWIW we are happy to take the drivers/net/ parts if there is no hard
> dependency. But there's no point taking that unless the SoC bits
> also go in for 6.7.
> 
> Li Yang, what are your expectations WRT merging this series?

I think it is too late for SoC stuff for 6.7. 

I picked up binding patches 6, 7, and 8 because 6 and 7 are the same as 
an additionalProperties fix I have in my tree. As 8 depends on them, I 
just picked it up too.

Rob