| Message ID | 20231016153051.1409074-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/1] leds: core: Refactor led_update_brightness() to use standard pattern | expand |
Hi, On 10/16/23 17:30, Andy Shevchenko wrote: > The standard conditional pattern is to check for errors first and > bail out if any. Refactor led_update_brightness() accordingly. > > While at it, drop unneeded assignment and return 0 unconditionally > on success. > > Acked-by: Denis Osterland-Heim <denis.osterland@diehl.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > v2: added tag (Denis), Cc'ed to the updated list of LED maintainers > drivers/leds/led-core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > index 2230239283d0..89c9806cc97f 100644 > --- a/drivers/leds/led-core.c > +++ b/drivers/leds/led-core.c > @@ -364,17 +364,17 @@ EXPORT_SYMBOL_GPL(led_set_brightness_sync); > > int led_update_brightness(struct led_classdev *led_cdev) > { > - int ret = 0; > + int ret; > > if (led_cdev->brightness_get) { > ret = led_cdev->brightness_get(led_cdev); > - if (ret >= 0) { > - led_cdev->brightness = ret; > - return 0; > - } > + if (ret < 0) > + return ret; > + > + led_cdev->brightness = ret; > } > > - return ret; > + return 0; > } > EXPORT_SYMBOL_GPL(led_update_brightness); >
On Mon, 16 Oct 2023 18:30:51 +0300, Andy Shevchenko wrote: > The standard conditional pattern is to check for errors first and > bail out if any. Refactor led_update_brightness() accordingly. > > While at it, drop unneeded assignment and return 0 unconditionally > on success. > > > [...] Applied, thanks! [1/1] leds: core: Refactor led_update_brightness() to use standard pattern commit: 0e5bb700df6a6fe36d9487a4e0a82a4c7b1f7b4e -- Lee Jones [李琼斯]
diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 2230239283d0..89c9806cc97f 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -364,17 +364,17 @@ EXPORT_SYMBOL_GPL(led_set_brightness_sync); int led_update_brightness(struct led_classdev *led_cdev) { - int ret = 0; + int ret; if (led_cdev->brightness_get) { ret = led_cdev->brightness_get(led_cdev); - if (ret >= 0) { - led_cdev->brightness = ret; - return 0; - } + if (ret < 0) + return ret; + + led_cdev->brightness = ret; } - return ret; + return 0; } EXPORT_SYMBOL_GPL(led_update_brightness);