| Message ID | 20231026084735.3595944-3-enachman@marvell.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: cn913x: add device trees for COM Express boards | expand |
On 26/10/2023 10:47, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add dt bindings for AC5X RD COM Express Type 7 carrier board. > This board will Accept a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@marvell.com> > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..71bc94047d1b 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,12 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP > + items: > + - const: marvell,ac5x_rd_carrier No underscores in compatibles. Do you see them anywhere? Please use existing, recent code as start of your contributions, not something buggy 5 years old. Best regards, Krzysztof
On 26/10/2023 10:47, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add dt bindings for AC5X RD COM Express Type 7 carrier board. > This board will Accept a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@marvell.com> Please order your patches correctly, so bindings come before their users. You cannot have other way. > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) Best regards, Krzysztof
> > No underscores in compatibles. > > Oh shit, I didn't notice that somehow. Un-acked until that's removed. Not a problem. Its way too late for this merge window. The pull request for Marvell stuff has already been sent to arm-soc. There is plenty of time to fix this, and there are other problems to address as well. Andrew
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml index 52d78521e412..71bc94047d1b 100644 --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml @@ -60,4 +60,12 @@ properties: - const: marvell,armada-ap807-quad - const: marvell,armada-ap807 + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP + items: + - const: marvell,ac5x_rd_carrier + - const: marvell,cn9131 + - const: marvell,cn9130 + - const: marvell,armada-ap807-quad + - const: marvell,armada-ap807 + additionalProperties: true