diff mbox series

ARM: dts: omap4: embt2ws: add LED

Message ID 20230819143109.471615-1-andreas@kemnade.info
State New
Headers show
Series ARM: dts: omap4: embt2ws: add LED | expand

Commit Message

Andreas Kemnade Aug. 19, 2023, 2:31 p.m. UTC
Add LED since the driver is now available.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 .../boot/dts/ti/omap/omap4-epson-embt2ws.dts  | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

Comments

Tony Lindgren Sept. 26, 2023, 7:19 a.m. UTC | #1
* Andreas Kemnade <andreas@kemnade.info> [230819 17:31]:
> Add LED since the driver is now available.

Thanks applying into omap-for-v6.7/dt.

Tony
Pavel Machek Oct. 31, 2023, 9:16 a.m. UTC | #2
Hi!

> Add LED since the driver is now available.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Is it one LED or three LEDs?

If it is one, we should use multicolor...

BR,
										Pavel
										
> @@ -206,7 +207,31 @@ &i2c3 {
>  
>  	clock-frequency = <100000>;
>  
> -	/* TODO: BD2606MVV at 0x66 */
> +	led-controller@66 {
> +		compatible = "rohm,bd2606mvv";
> +		reg = <0x66>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		led@0 {
> +			reg = <0>;
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +
> +		led@2 {
> +			reg = <2>;
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +
> +		led@4 {
> +			reg = <4>;
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +	};
>  };
>  
>  &i2c4 {
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
index e119e2cccc4e1..f47d330fb6ee4 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
@@ -4,6 +4,7 @@ 
  */
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/input/input.h>
 #include "omap4460.dtsi"
 
@@ -206,7 +207,31 @@  &i2c3 {
 
 	clock-frequency = <100000>;
 
-	/* TODO: BD2606MVV at 0x66 */
+	led-controller@66 {
+		compatible = "rohm,bd2606mvv";
+		reg = <0x66>;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_STATUS;
+		};
+
+		led@2 {
+			reg = <2>;
+			color = <LED_COLOR_ID_BLUE>;
+			function = LED_FUNCTION_STATUS;
+		};
+
+		led@4 {
+			reg = <4>;
+			color = <LED_COLOR_ID_RED>;
+			function = LED_FUNCTION_STATUS;
+		};
+	};
 };
 
 &i2c4 {