| Message ID | 20231106-refclk_always_on-v1-0-17a7fd8b532b@quicinc.com |
|---|---|
| Headers | show |
| Series | phy: qcom-qmp-pcie: Add support to keep refclk always on | expand |
On Mon, 6 Nov 2023 at 13:53, Krishna chaitanya chundru <quic_krichai@quicinc.com> wrote: > > This series adds support to provide refclk to endpoint even in low > power states. > > Due to some platform specific issues with CLKREQ signal, it is not being > propagated to the host and as host doesn't know the clkreq signal host is > not sending refclk. Due to this endpoint is seeing linkdown and going > to bad state. Is this a board issue or an SoC issue? In the latter case this should go to the PHY configuration structure instead of being specified in the DT. > To avoid those ref clk should be provided always to the endpoint. The > issue is coming only when ep intiates the L1.1 or L1.2 exit and clkreq > is not being propagated properly to the host. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Krishna chaitanya chundru (2): > dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property > phy: qcom-qmp-pcie: Add support for keeping refclk always on > > .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 5 +++++ > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 21 +++++++++++++++++---- > 2 files changed, 22 insertions(+), 4 deletions(-) > --- > base-commit: 71e68e182e382e951d6248bccc3c960dcec5a718 > change-id: 20231106-refclk_always_on-9beae8297cb8 > > Best regards, > -- > Krishna chaitanya chundru <quic_krichai@quicinc.com> >
On 11/6/2023 9:50 PM, Bjorn Andersson wrote: > On Mon, Nov 06, 2023 at 05:22:34PM +0530, Krishna chaitanya chundru wrote: >> Document qcom,refclk-always-on property which is needed in some platforms >> to supply refclk even in PCIe low power states. >> >> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >> --- >> .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml >> index 2c3d6553a7ba..9daf0556ed3b 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml >> @@ -93,6 +93,11 @@ properties: >> "#phy-cells": >> const: 0 >> >> + qcom,refclk-always-on: >> + type: boolean >> + description: A boolean property indicating the refclk is >> + always on even in Low power states (optional) > As with the driver patch, please improve this description (and use your > 80 characters). > > > It would also be preferable to capture (or at least indicate) the > problem that this flash is working around - so that future readers > doesn't need to go look in the commit history for the phy driver to > figure out what this is doing. > > Regards, > Bjorn Sure I will update this in my next patch. - Krishna Chaitanya. >> + >> required: >> - compatible >> - reg >> >> -- >> 2.42.0 >>
This series adds support to provide refclk to endpoint even in low power states. Due to some platform specific issues with CLKREQ signal, it is not being propagated to the host and as host doesn't know the clkreq signal host is not sending refclk. Due to this endpoint is seeing linkdown and going to bad state. To avoid those ref clk should be provided always to the endpoint. The issue is coming only when ep intiates the L1.1 or L1.2 exit and clkreq is not being propagated properly to the host. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- Krishna chaitanya chundru (2): dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property phy: qcom-qmp-pcie: Add support for keeping refclk always on .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 5 +++++ drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 21 +++++++++++++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) --- base-commit: 71e68e182e382e951d6248bccc3c960dcec5a718 change-id: 20231106-refclk_always_on-9beae8297cb8 Best regards,