| Message ID | 20231205-b4-qcom-dt-compat-v6-6-61d104a8f920@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Qualcomm PMIC fixes | expand |
Hi Caleb, On Tue, 5 Dec 2023 at 06:48, Caleb Connolly <caleb.connolly@linaro.org> wrote: > > Use the upstream gpio-ranges property instead of gpio-count, and drop > the bank-name property for Qualcomm boards. > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > Reviewed-by: Sumit Garg <sumit.garg@linaro.org> > Tested-by: Sumit Garg <sumit.garg@linaro.org> > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > arch/arm/dts/dragonboard410c.dts | 3 +-- > arch/arm/dts/dragonboard820c.dts | 3 +-- > arch/arm/dts/qcs404-evb.dts | 3 +-- > arch/arm/dts/sdm845.dtsi | 3 +-- > 4 files changed, 4 insertions(+), 8 deletions(-) > What is the replacement for the GPIO bank name? Regards, Simon
Hi Simon, On 06/12/2023 03:54, Simon Glass wrote: > Hi Caleb, > > On Tue, 5 Dec 2023 at 06:48, Caleb Connolly <caleb.connolly@linaro.org> wrote: >> >> Use the upstream gpio-ranges property instead of gpio-count, and drop >> the bank-name property for Qualcomm boards. >> >> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> >> Reviewed-by: Sumit Garg <sumit.garg@linaro.org> >> Tested-by: Sumit Garg <sumit.garg@linaro.org> >> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> >> --- >> arch/arm/dts/dragonboard410c.dts | 3 +-- >> arch/arm/dts/dragonboard820c.dts | 3 +-- >> arch/arm/dts/qcs404-evb.dts | 3 +-- >> arch/arm/dts/sdm845.dtsi | 3 +-- >> 4 files changed, 4 insertions(+), 8 deletions(-) >> > > What is the replacement for the GPIO bank name? The bank name is hardcoded to "pmic". In previous revisions of this patch I tried to keep the specific PMIC model, but after some discussion we decided that there was no benefit to this over just "pmic". > > Regards, > Simon
On 06/12/2023 11:39, Caleb Connolly wrote: > Hi Simon, > > On 06/12/2023 03:54, Simon Glass wrote: >> Hi Caleb, >> >> On Tue, 5 Dec 2023 at 06:48, Caleb Connolly <caleb.connolly@linaro.org> wrote: >>> >>> Use the upstream gpio-ranges property instead of gpio-count, and drop >>> the bank-name property for Qualcomm boards. >>> >>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> >>> Reviewed-by: Sumit Garg <sumit.garg@linaro.org> >>> Tested-by: Sumit Garg <sumit.garg@linaro.org> >>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> >>> --- >>> arch/arm/dts/dragonboard410c.dts | 3 +-- >>> arch/arm/dts/dragonboard820c.dts | 3 +-- >>> arch/arm/dts/qcs404-evb.dts | 3 +-- >>> arch/arm/dts/sdm845.dtsi | 3 +-- >>> 4 files changed, 4 insertions(+), 8 deletions(-) >>> >> >> What is the replacement for the GPIO bank name? > > The bank name is hardcoded to "pmic". In previous revisions of this > patch I tried to keep the specific PMIC model, but after some discussion > we decided that there was no benefit to this over just "pmic". Hi Simon, Just wanted to check this is ok with you before merging this series. Thanks, >> >> Regards, >> Simon >
diff --git a/arch/arm/dts/dragonboard410c.dts b/arch/arm/dts/dragonboard410c.dts index c41fee977813..6a4e3ccf17b1 100644 --- a/arch/arm/dts/dragonboard410c.dts +++ b/arch/arm/dts/dragonboard410c.dts @@ -170,9 +170,8 @@ compatible = "qcom,pm8916-gpio"; reg = <0xc000 0x400>; gpio-controller; - gpio-count = <4>; + gpio-ranges = <&pm8916_gpios 0 0 4>; #gpio-cells = <2>; - gpio-bank-name="pmic"; }; }; diff --git a/arch/arm/dts/dragonboard820c.dts b/arch/arm/dts/dragonboard820c.dts index 0d9c9f7a4922..146a0af8aafe 100644 --- a/arch/arm/dts/dragonboard820c.dts +++ b/arch/arm/dts/dragonboard820c.dts @@ -132,9 +132,8 @@ compatible = "qcom,pm8994-gpio"; reg = <0xc000 0x400>; gpio-controller; - gpio-count = <24>; + gpio-ranges = <&pm8994_gpios 0 0 22>; #gpio-cells = <2>; - gpio-bank-name="pm8994."; }; }; diff --git a/arch/arm/dts/qcs404-evb.dts b/arch/arm/dts/qcs404-evb.dts index 84224a8a3d39..bd2e303e10f4 100644 --- a/arch/arm/dts/qcs404-evb.dts +++ b/arch/arm/dts/qcs404-evb.dts @@ -378,9 +378,8 @@ compatible = "qcom,pms405-gpio"; reg = <0xc000 0x400>; gpio-controller; - gpio-count = <12>; + gpio-ranges = <&pms405_gpios 0 0 12>; #gpio-cells = <2>; - gpio-bank-name="pmic"; }; }; }; diff --git a/arch/arm/dts/sdm845.dtsi b/arch/arm/dts/sdm845.dtsi index cd5d890e9a45..a26e9f411ee0 100644 --- a/arch/arm/dts/sdm845.dtsi +++ b/arch/arm/dts/sdm845.dtsi @@ -103,9 +103,8 @@ compatible = "qcom,pm8998-gpio"; reg = <0xc000 0x1a00>; gpio-controller; - gpio-count = <21>; + gpio-ranges = <&pm8998_gpios 0 0 26>; #gpio-cells = <2>; - gpio-bank-name = "pm8998."; }; };